dd-firmware

Clone Tools

Stats

Commits this week: 61
Total Committers: 16
Last Commit: 30 Apr
Commits this week: 61

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 30 Apr
2:05 pm

Vendor - TEL - Sameer Poyil

Merging LDT-3978-switch-chamber-f-conductive-lev into develop

Options
    • -7
    • +4
    /firmware/App/Controllers/BalancingChamber.c
    • -1
    • +0
    /firmware/App/DDCommon.h
    • -2
    • +2
    /firmware/App/Monitors/Level.c
1:57 pm

Dara Navaei

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    /firmware/App/DDCommon.h
1:57 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    /firmware/App/Controllers/BalancingChamber.c
    • -1
    • +1
    /firmware/App/Controllers/DryBiCart.c
    • -1
    • +1
    /firmware/App/Controllers/DryBiCart.h
    • -2
    • +2
    /firmware/App/Controllers/Heaters.c
    • -2
    • +2
    /firmware/App/Controllers/PermeateTank.c
    • -2
    • +2
    /firmware/App/DDCommon.h
    • -2
    • +2
    /firmware/App/Modes/FPModes/ModePreGenPermeate.c
    • -2
    • +2
    /firmware/App/Modes/FPModes/StateFlushConcentrate.c
    • -2
    • +2
    /firmware/App/Modes/FPModes/StateFlushPermeate.c
    • -2
    • +2
    /firmware/App/Modes/ModeGenDialysate.c
    • -1
    • +1
    /firmware/App/Monitors/Level.c
    • -2
    • +2
    /firmware/App/Monitors/Level.h
    • -2
    • +2
    /firmware/App/Services/Messaging.c
1:54 pm

Vendor - TEL - Sameer Poyil

Merge branch LDT-3978-switch-chamber-f-conductive-lev into staging

Options
1:42 pm

Sean Nash

11:27 am

Dara Navaei

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Options
    • -2
    • +2
    /firmware/App/DDCommon.h
11:26 am

Vendor - TEL - Jashwant Gantyada

merged branch LDT-3963

Options
    • -16
    • +21
    /firmware/App/Controllers/BalancingChamber.c
    • -4
    • +9
    /firmware/App/Controllers/ConcentratePumps.c
    • -2
    • +10
    /firmware/App/DDCommon.h
    • -0
    • +3
    /firmware/App/Modes/ModeFault.c
    • -0
    • +4
    /firmware/App/Monitors/Level.c
11:19 am

Michael Garthwaite and Vinayakam Mani

11:17 am

Vendor - TEL - Sameer Poyil

LDT-3978 addressed review comments

Options
    • -2
    • +15
    /firmware/App/Controllers/DryBiCart.c
11:08 am

Raghu Kallala

LDT-4188 addressed review comments

Options
    • -0
    • +1
    /firmware/App/Services/TDInterface.c
    • -1
    • +0
    /firmware/App/Services/TDInterface.h
11:07 am

Raghu Kallala

To resolve the build failure with DD, haven't added all the features, instead added TODO comment

To resolve the build failure with DD, haven't added all the features, instead added TODO comment

11:00 am

Raghu Kallala

Idea is to have this in institutional records we implement it

Idea is to have this in institutional records we implement it

10:58 am

Vendor - TEL - Sameer Poyil

a time out for decaying D66 pressure to 3 PSI after D65 closed

a time out for decaying D66 pressure to 3 PSI after D65 closed

10:55 am

Sean Nash

If this is const, how will user add conversions (after 3rd value)?

If this is const, how will user add conversions (after 3rd value)?

10:54 am

Sean Nash

Remove extra blank line.

Remove extra blank line.

10:53 am

Vendor - TEL - Sameer Poyil

LDT-3978-addressed review comments

Options
    • -14
    • +24
    /firmware/App/Controllers/DryBiCart.c
10:44 am

Vendor - TEL - Jashwant Gantyada

LDT-3963 enabled fault mode tranisiton for switching off hetares for dilaysate flow rate testing

Options
    • -16
    • +21
    /firmware/App/Controllers/BalancingChamber.c
    • -4
    • +9
    /firmware/App/Controllers/ConcentratePumps.c
    • -1
    • +1
    /firmware/App/Controllers/RinsePump.c
    • -2
    • +1
    /firmware/App/Controllers/RinsePump.h
    • -2
    • +8
    /firmware/App/DDCommon.h
    • -0
    • +4
    /firmware/App/Drivers/BloodLeakDriver.c
    • -0
    • +4
    /firmware/App/Drivers/ConductivityTeensy.c
    • -0
    • +3
    /firmware/App/Modes/ModeFault.c
    • -0
    • +4
    /firmware/App/Monitors/Level.c
    • -0
    • +5
    /firmware/App/Monitors/Temperature.c
    • -2
    • +1
    /firmware/App/Services/AlarmMgmtDD.c
    • -0
    • +5
    /firmware/App/Services/SystemCommDD.c
10:41 am

Vinayakam Mani

remove space after <= and add space end of function call.

remove space after <= and add space end of function call.

10:40 am

Vinayakam Mani

Is this time out after D80 opening or D65 closing state? if it is D65 closed, you need to start the timer after D65 closing.

Is this time out after D80 opening or D65 closing state? if it is D65 closed, you need to start the timer after D65 closing.

10:32 am

Vinayakam Mani

if we are not checking level, this can be removed and function name also can be updated accordingly.

if we are not checking level, this can be removed and function name also can be updated accordingly.

10:30 am

Sean Nash

Is this a TODO? If so, add TODO to the comment and maybe be a little more descriptive of what needs to be done.

Is this a TODO? If so, add TODO to the comment and maybe be a little more descriptive of what needs to be done.

10:26 am

Vinayakam Mani

can we get 'runPIController' inside deadband control check?

can we get 'runPIController' inside deadband control check?

10:16 am

Vinayakam Mani

Can we add sodium and bicarb overrides now, so that we don't want to come back again for this change? Also, please get the dialin updated to reflect the new parameters additions in tdproxy and let ...

Can we add sodium and bicarb overrides now, so that we don't want to come back again for this change?
Also, please get the dialin updated to reflect the new parameters additions in tdproxy and let system team be in loop to update the required system scripts?

8:49 am

Vendor - TEL - Sameer Poyil

LDT-3978 adreesing review comments

Options
    • -2
    • +2
    /firmware/App/Monitors/Level.c
8:28 am

Vendor - TEL - Sameer Poyil

LDT-3978 fixing compilation warning

Options
    • -1
    • +0
    /firmware/App/Controllers/DryBiCart.c
8:25 am

Vendor - TEL - Sameer Poyil

LDT-3978 addressing review comments

Options
    • -55
    • +60
    /firmware/App/Controllers/DryBiCart.c
    • -8
    • +8
    /firmware/App/Controllers/DryBiCart.h
Wednesday 29 Apr
5:41 pm

Vendor - TEL - Sameer Poyil

LDT-3978 fixing compilation error

Options
    • -37
    • +103
    /firmware/App/Controllers/DryBiCart.c
    • -1
    • +2
    /firmware/App/Controllers/DryBiCart.h
    • -1
    • +1
    /firmware/App/DDCommon.h
1:49 pm

Vendor - TEL - Sameer Poyil

1:44 pm

Raghu Kallala

LDT-4188 updated set pre-gen and gen dialysate function calls

Options
    • -1
    • +1
    /firmware/App/Services/Messaging.c
    • -35
    • +97
    /firmware/App/Services/TDInterface.c
    • -3
    • +6
    /firmware/App/Services/TDInterface.h
1:36 pm

Vendor - TEL - Sameer Poyil

LDT-3978 fix for compilation error

Options
    • -4
    • +6
    /firmware/App/Controllers/DryBiCart.c