Activity dd-firmware/

7:21 pm

Vendor - TEL - Sameer Poyil

More
Re: LEAHI-DD-FIRMWARE-LDT-3963-1
commented on review

i see some of the code is for building the code , could you please remove all such code ? or create a new branch and push it , it will confuse. while pushing the code , all supporting code for buil...

i see some of the code is for building the code , could you please remove all such code ? or create a new branch and push it , it will confuse. while pushing the code , all supporting code for build / functionality should be removed.

6:02 pm

Vendor - TEL - Sameer Poyil

More
LEAHI-DD-FIRMWARE-LDT-3963-1
joined review

2:36 pm

Vendor - TEL - Jashwant Gantyada

More
Re: LEAHI-DD-FIRMWARE-LDT-3963-1
commented on review

I had this commented again to push to the develop branch. It is uncommented for my testing.

2:21 pm

Vendor - TEL - Jashwant Gantyada

added TODO above

2:21 pm

Vendor - TEL - Jashwant Gantyada

updated as suggested.

2:21 pm

Vendor - TEL - Jashwant Gantyada

More
Re: LEAHI-DD-FIRMWARE-LDT-3963-1
replied to Vendor - TEL - Arpita Srivastava

updated.

2:20 pm

Vendor - TEL - Jashwant Gantyada

updated accordingly.

2:20 pm

Vendor - TEL - Jashwant Gantyada

added TODO for all

2:20 pm

Vendor - TEL - Jashwant Gantyada

makes sense. removed it.

1:25 pm

Vendor - TEL - Jashwant Gantyada

I think we are using it to send a message to Dialin, to let the tester know whether the command has passed/failed or timed out.

1:07 pm

Vendor - TEL - Jashwant Gantyada

More
Re: LEAHI-DD-FIRMWARE-LDT-3963-1
replied to Vendor - TEL - Arpita Srivastava

restored

1:50 pm

Vendor - TEL - Sameer Poyil

This dead band control ? here is the ideal place , may be BC to incldue the .h from drybicart

10:31 am

Dara Navaei

More
LEAHI-DD-FIRMWARE-LDT-4413-1
started review

LEAHI-DD-FIRMWARE-LDT-4413_Synchronize the Change events content

9:45 pm

Vinayakam Mani

More
LEAHI-DD-FIRMWARE-LDT-4183-1
finished reviewing

11:55 am

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-3963-1
commented on review

Why did we remove this? This is needed for BC Switch only condition.

9:42 am

Raghu Kallala

9:12 am

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-4183-1
commented on review

Is this defined elsewhere? We shouldn't define this in multiple places. I think it should be in one header file - maybe balancing chamber controller.

8:51 am

Sean Nash

More
LEAHI-DD-FIRMWARE-LDT-4188-1
finished reviewing

11:30 pm

Vendor - TEL - Sameer Poyil

11:28 pm

Vendor - TEL - Sameer Poyil

1:21 pm

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3963-1
commented on review

Again, I don't like these oriented this way. Please change to #ifndef DISABLE_ALARM_4

1:19 pm

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3963-1
commented on review

If BC switching period is Zero, I would expect the Qd from TD to also be zero, right? But what if it's not? What if Qd from TD is 600 and switching period is zero? You are going to run the pump pre...

If BC switching period is Zero, I would expect the Qd from TD to also be zero, right? But what if it's not? What if Qd from TD is 600 and switching period is zero? You are going to run the pump pretty fast with no BC switching in that case.

1:10 pm

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3963-1
replied to Vendor - TEL - Arpita Srivastava

We shouldn't require something to be defined to do the right thing. We should require something to be defined to do the wrong thing (i.e. this should say #ifndef _BAD_MSG_CRC_ALARM_DISABLED_) And t...

We shouldn't require something to be defined to do the right thing. We should require something to be defined to do the wrong thing (i.e. this should say #ifndef _BAD_MSG_CRC_ALARM_DISABLED_)
And then, we don't need a TODO. These #defines are only possible in DEBUG builds. A RELEASE build will never allow thing build flags to disable things.

1:52 pm