dd-firmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
LDT-3223-dialysate-flow-rate---dd---mode-tel-dev-test-3-30-2026 : Added test cases for PIControllers.c file

LDT-3223-dialysate-flow-rate---dd---mode-tel-dev-test-3-30-2026 : Added testcases for WatchdogMgmt file

Merge branch 'LDT-3223-dialysate-flow-rate---dd---mode-tel-dev-test-3-30-2026' of bitbucket.org:diality-cloud/dd-firmware into LDT-3223-dialysate-flow-rate---dd---mode-tel-dev-test-3-30-2026

Merge branch 'staging' into LDT-3272-software-update---dd-firmware

    • -0
    • +16
    /firmware/App/Services/SystemCommDD.h
LDT-3963 addressed code review comments

restored

restored

Not sure why Crucible is showing it this way. Let's just re-review these diffs.

Not sure why Crucible is showing it this way. Let's just re-review these diffs.

Should be #ifndef

Should be #ifndef

Should be #ifndef I think.

Should be #ifndef I think.

Can we make these low priority and 999 rank?

Can we make these low priority and 999 rank?

LDT-3963 addressed code review comments and restored the fault mode transition

    • -3
    • +1
    /firmware/App/Drivers/BloodLeakDriver.c
LDT-3223-dialysate-flow-rate---dd---mode-tel-dev-test-3-30-2026 : Added test cases for AlarmMgmtDD.c and FPInterface.c

Merge branch 'staging' into LDT-4000-hdf-fw-implementation-1

    • -20
    • +24
    /firmware/App/Controllers/RinsePump.c
Merge branch 'staging' into LDT-3972-water-treatment-and-degassing-1

Merge branch 'staging' into LDT-3975-Boost-Pump

    • -2
    • +2
    /firmware/App/Modes/FPModes/ModeGenPermeate.c
Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

    • -1
    • +1
    /firmware/App/Modes/FPModes/FPOperationModes.c
    • -1
    • +1
    /firmware/App/Modes/FPModes/ModeGenPermeate.c
LDT-4413 merge latest into staging

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

resolved merge conflict for LDT-4413 into develop in handleRinsePumpOffState

    • -13
    • +22
    /firmware/App/Controllers/RinsePump.c
Fixed broadcast issue for rinse pump PWM

    • -6
    • +10
    /firmware/App/Controllers/RinsePump.c
LDT-4414 added fix to update the pwm value in broadcast and changed setpwm from count to percentage

    • -10
    • +15
    /firmware/App/Controllers/RinsePump.c
It is weird that we're responding so far from request. It is not clear to me that Dialin has requested anything at this point.

It is weird that we're responding so far from request. It is not clear to me that Dialin has requested anything at this point.

Details looks weird. Where is inputs and outputs like other function headers?

Details looks weird. Where is inputs and outputs like other function headers?

Add a blank line after banner.

Add a blank line after banner.

Please restore before you merge to staging.

Please restore before you merge to staging.

If I'm reading this right, we're saying that if bad CRC alarm is NOT enabled, initialize the alarm? That seems backward.

If I'm reading this right, we're saying that if bad CRC alarm is NOT enabled, initialize the alarm? That seems backward.

Same comments as ENABLE_ALARM_1 above.

Same comments as ENABLE_ALARM_1 above.