dd-firmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
LDT-4001: code review comments

is it a dummy parameter? where are you using it ?

is it a dummy parameter? where are you using it ?

Why pre-gen missing substitutionrate ? not required ?

Why pre-gen missing substitutionrate ? not required ?

please removed commented code

please removed commented code

please remove commented code

please remove commented code

LEAHI-DD-FIRMWARE-LDT-4183_Dialysate Composition (Dry Bicarbonate) - FW Implementation - 2/1:
LEAHI-DD-FIRMWARE-LDT-4183_Dialysate Composition (Dry Bicarbonate) - FW Implementation - 2/1:
remove blank line

remove blank line

remove blank line

remove blank line

Please see if you can define a function to handle this and call that function here, to reduce the number of code lines in this function.

Please see if you can define a function to handle this and call that function here, to reduce the number of code lines in this function.

added

added

fixed. thanks!

fixed. thanks!

fixed. thanks!

fixed. thanks!

fixed. thanks!

fixed. thanks!

added.

added.

renamed to reflect whats on staging

renamed to reflect whats on staging

fixed. thanks!

fixed. thanks!

fixed. thanks!

fixed. thanks!

LDT-4001: code review comments

    • -41
    • +68
    /firmware/App/Services/TDInterface.c
update the message ID.

update the message ID.

Update the comment for all publish counter start counts.

Update the comment for all publish counter start counts.

LDT-4183 Dialysate composition closed loop control for acid and bicarb

    • -59
    • +255
    /firmware/App/Controllers/DryBiCart.c
same comment as above

same comment as above

This was added as on bootup the registers were looking at beta 1.9 before, so the initialization was failing. Now that it is changed to look at beta 2 registers on bootup can we remove this as this...

This was added as on bootup the registers were looking at beta 1.9 before, so the initialization was failing. Now that it is changed to look at beta 2 registers on bootup can we remove this as this is no longer required?

In develop branch , its substitionrate ? need in sync with develop and staging

In develop branch , its substitionrate ? need in sync with develop and staging

LDT-4409 beta-2.1 WCID fill and supply implementation

    • -115
    • +127
    /firmware/App/Controllers/DryBiCart.c
Add Set Substitution pump target speed here.

Add Set Substitution pump target speed here.

leave blank after.

leave blank after.

leave blank after

leave blank after

Align comment please.

Align comment please.