dd-firmware

Clone Tools

Stats

Commits this week: 32
Total Committers: 17
Last Commit: 09 Jun
Commits this week: 32

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 09 Jun
1:45 pm

Michael Garthwaite

LDT-4001: code review comments

Options
    • -4
    • +4
    /firmware/App/Controllers/Heaters.c
    • -1
    • +1
    /firmware/App/Monitors/Temperature.c
1:15 pm

Vendor - TEL - Jashwant Gantyada and Vendor - TEL - Sameer Poyil

1:09 pm

Vendor - TEL - Sameer Poyil

is it a dummy parameter? where are you using it ?

is it a dummy parameter? where are you using it ?

1:08 pm

Vendor - TEL - Sameer Poyil

Why pre-gen missing substitutionrate ? not required ?

Why pre-gen missing substitutionrate ? not required ?

1:00 pm

Vendor - TEL - Sameer Poyil

please removed commented code

please removed commented code

12:59 pm

Vendor - TEL - Sameer Poyil

please remove commented code

please remove commented code

12:06 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-4183_Dialysate Composition (Dry Bicarbonate) - FW Implementation - 2/1:
LEAHI-DD-FIRMWARE-LDT-4183_Dialysate Composition (Dry Bicarbonate) - FW Implementation - 2/1:
12:03 pm

Vinayakam Mani

remove blank line

remove blank line

12:03 pm

Vinayakam Mani

remove blank line

remove blank line

12:02 pm

Vinayakam Mani

Please see if you can define a function to handle this and call that function here, to reduce the number of code lines in this function.

Please see if you can define a function to handle this and call that function here, to reduce the number of code lines in this function.

12:01 pm

Michael Garthwaite

added

added

12:01 pm

Michael Garthwaite

fixed. thanks!

fixed. thanks!

12:01 pm

Michael Garthwaite

fixed. thanks!

fixed. thanks!

12:01 pm

Michael Garthwaite

fixed. thanks!

fixed. thanks!

12:01 pm

Michael Garthwaite

added.

added.

12:00 pm

Michael Garthwaite

renamed to reflect whats on staging

renamed to reflect whats on staging

12:00 pm

Michael Garthwaite

fixed. thanks!

fixed. thanks!

12:00 pm

Michael Garthwaite

fixed. thanks!

fixed. thanks!

12:00 pm

Michael Garthwaite

LDT-4001: code review comments

Options
    • -1
    • +1
    /firmware/App/Controllers/SubstitutionPump.c
    • -0
    • +2
    /firmware/App/Services/FpgaDD.c
    • -41
    • +68
    /firmware/App/Services/TDInterface.c
11:57 am

Vinayakam Mani

update the message ID.

update the message ID.

11:53 am

Vinayakam Mani

Update the comment for all publish counter start counts.

Update the comment for all publish counter start counts.

11:49 am

Vendor - TEL - Sameer Poyil

LDT-4183 Dialysate composition closed loop control for acid and bicarb

Options
    • -59
    • +255
    /firmware/App/Controllers/DryBiCart.c
    • -2
    • +7
    /firmware/App/Controllers/DryBiCart.h
11:48 am

Vendor - TEL - Jashwant Gantyada

same comment as above

same comment as above

11:48 am

Vendor - TEL - Jashwant Gantyada

This was added as on bootup the registers were looking at beta 1.9 before, so the initialization was failing. Now that it is changed to look at beta 2 registers on bootup can we remove this as this...

This was added as on bootup the registers were looking at beta 1.9 before, so the initialization was failing. Now that it is changed to look at beta 2 registers on bootup can we remove this as this is no longer required?

11:40 am

Vendor - TEL - Sameer Poyil

In develop branch , its substitionrate ? need in sync with develop and staging

In develop branch , its substitionrate ? need in sync with develop and staging

11:36 am

Vendor - TEL - Sameer Poyil

LDT-4409 beta-2.1 WCID fill and supply implementation

Options
    • -115
    • +127
    /firmware/App/Controllers/DryBiCart.c
11:33 am

Vinayakam Mani

Add Set Substitution pump target speed here.

Add Set Substitution pump target speed here.

11:08 am

Vendor - TEL - Jashwant Gantyada

leave blank after.

leave blank after.

11:08 am

Vendor - TEL - Jashwant Gantyada

leave blank after

leave blank after

11:06 am

Vendor - TEL - Jashwant Gantyada

Align comment please.

Align comment please.