dd-firmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Change speed to rate.

Change speed to rate.

pumpTargetRate

pumpTargetRate

Change function name to say rate instead of speed

Change function name to say rate instead of speed

Is this a rate too?

Is this a rate too?

Is this a rate too?

Is this a rate too?

Change speed to rate.

Change speed to rate.

Is currentPumpSpeed actually a rate?

Is currentPumpSpeed actually a rate?

Is this comment correct? Seems like we're stopping pump if requested to turn off.

Is this comment correct? Seems like we're stopping pump if requested to turn off.

Is currentPumpSpeed also a rate? If not, we're subtracting a speed from a rate which doesn't make much sense.

Is currentPumpSpeed also a rate? If not, we're subtracting a speed from a rate which doesn't make much sense.

Align comment.

Align comment.

Align comment. Change "speed" to "rate in comment too. Also, I don't see you initializing these rates.

Align comment. Change "speed" to "rate in comment too.
Also, I don't see you initializing these rates.

fixed thanks

fixed thanks

Change to pumpTargetRate since mL/min is a rate.

Change to pumpTargetRate since mL/min is a rate.

fixed thanks

fixed thanks

fixed thanks

fixed thanks

fixed thanks

fixed thanks

Please check with TD, I have seen one of the develop branch this populated in pre gen and gen.

Please check with TD, I have seen one of the develop branch this populated in pre gen and gen.

why TODO?

why TODO?

Do we need to close D64 as well?

Do we need to close D64 as well?

Delete the commented line

Delete the commented line

handleBicarbChamberInitiateSupply?

handleBicarbChamberInitiateSupply?

Update this.

Update this.

Remove this comment.

Remove this comment.

Update Inputs and Outputs throughout the file.

Update Inputs and Outputs throughout the file.

Do we need this?

Do we need this?

when are we closing D64 valve? handle the same in else block as well.

when are we closing D64 valve? handle the same in else block as well.

Can this be assigned during declaration time?

Can this be assigned during declaration time?

are we using these?

are we using these?

Can we use one macro (instead of three) for the D66 persistence?

Can we use one macro (instead of three) for the D66 persistence?