dd-firmware

Clone Tools

Stats

Commits this week: 52
Total Committers: 18
Last Commit: 18 Jun
Commits this week: 52

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 15 Jun
12:26 pm

Michael Garthwaite

WIP on develop

Options
    • -14
    • +17
    /firmware/App/Monitors/Conductivity.c
12:19 pm

Vinayakam Mani

Update Input section: Balancing chamber state

Update Input section: Balancing chamber state

12:18 pm

Vinayakam Mani

We can keep it as handler instead of exec since this is being invoked from execMixingControl.

We can keep it as handler instead of exec since this is being invoked from execMixingControl.

12:04 pm

Vinayakam Mani

we should use get balancing chamber fill volume if balancing chamber volume been adjusted by calibration (not an immediate need, but good to have)

we should use get balancing chamber fill volume if balancing chamber volume been adjusted by calibration (not an immediate need, but good to have)

11:58 am

Vinayakam Mani

remove min in the comment.

remove min in the comment.

11:55 am

Vinayakam Mani

Remove the unused header file.

Remove the unused header file.

11:55 am

Vinayakam Mani

Remove the unused header file.

Remove the unused header file.

11:53 am

Vinayakam Mani

Update state name matching handler name.

Update state name matching handler name.

11:42 am

Vinayakam Mani

Same as above.

Same as above.

11:41 am

Vinayakam Mani

The second condition( fill request) should be checked against true?

The second condition( fill request) should be checked against true?

11:41 am

Dara Navaei

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    /firmware/App/DDCommon.h
11:39 am

Michael Garthwaite

Merge branch 'LDT-4485-dd-conductivity-sensors-d17' into develop

Options
    • -106
    • +118
    /firmware/App/Drivers/ConductivitySensors.c
11:39 am

Michael Garthwaite

LDT-4485: updates conductivity cal check test config to check FPGA data to determine if the system is communicating to a dead sensor.

Options
    • -106
    • +117
    /firmware/App/Drivers/ConductivitySensors.c
11:24 am

Vendor - TEL - Sameer Poyil

LDT-4409 fixing compilation error

Options
    • -1
    • +2
    /firmware/App/Modes/ModePreGenDialysate.c
    • -2
    • +2
    /firmware/App/Services/TDInterface.c
11:20 am

Vendor - TEL - Sameer Poyil

Merge branch staging into LDT-4409-dialysate-composition-beta-2.1-WCID-implementation

Options
    • -2
    • +6
    /firmware/App/Services/Messaging.c
11:18 am

Vendor - TEL - Sameer Poyil

LDT-4409 enable dry bicart default

Options
    • -5
    • +5
    /firmware/App/Controllers/BalancingChamber.c
    • -17
    • +12
    /firmware/App/Controllers/MixingControl.h
    • -5
    • +5
    /firmware/App/Modes/ModeGenDialysate.c
    • -1
    • +2
    /firmware/App/Modes/ModePreGenDialysate.c
    • -1
    • +1
    /firmware/App/Tasks/TaskGeneral.c
8:17 am

Vendor - TEL - Sameer Poyil

LDT-4409 dry bicart implementation plus refactoring closed loop control

Options
    • -0
    • +1
    /firmware/App/Controllers/BalancingChamber.c
    • -14
    • +25
    /firmware/App/Controllers/DryBiCart.c
    • -0
    • +3
    /firmware/App/Controllers/DryBiCart.h
    • -0
    • +1136
    /firmware/App/Controllers/MixingControl.c
    • -0
    • +96
    /firmware/App/Controllers/MixingControl.h
    • -4
    • +5
    /firmware/App/Services/Messaging.c
Friday 12 Jun
2:21 pm

Dara Navaei

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    /firmware/App/DDCommon.h
2:19 pm

Michael Garthwaite

Merge branch 'LDT-4485-dd-conductivity-sensors-d17' into develop

Options
    • -7
    • +7
    /firmware/App/Controllers/Heaters.c
    • -2
    • +2
    /firmware/App/Controllers/RinsePump.c
    • -2
    • +2
    /firmware/App/Monitors/Conductivity.c
    • -2
    • +2
    /firmware/App/Monitors/Level.c
    • -2
    • +4
    /firmware/App/Services/FpgaDD.c
2:18 pm

Michael Garthwaite

LDT-4485: fixed pumpid call

Options
    • -1
    • +1
    /firmware/App/Controllers/SubstitutionPump.c
2:13 pm

Michael Garthwaite

LDT-4485: updates to sub pump rpm measure alarm to not monitor during off state.

Options
    • -1
    • +5
    /firmware/App/Controllers/SubstitutionPump.c
2:09 pm

Michael Garthwaite

Merge branch 'staging' into LDT-4485-dd-conductivity-sensors-d17

Options
    • -25
    • +20
    /firmware/App/Monitors/Conductivity.c
9:14 am

Sean Nash

Is this normal UF volume or normal UF volume + Iso UF Volume?

Is this normal UF volume or normal UF volume + Iso UF Volume?

9:11 am

Sean Nash

Consider moving this validity check into the setTDRequestedGenDState function. And what should we do if it's not valid?

Consider moving this validity check into the setTDRequestedGenDState function.
And what should we do if it's not valid?

9:07 am

Sean Nash

Why only these states are valid?

Why only these states are valid?

9:05 am

Sean Nash

Remove list of states from comment. It is not a complete list and we shouldn't even try to list them here anyway.

Remove list of states from comment. It is not a complete list and we shouldn't even try to list them here anyway.

8:25 am

Vendor - TEL - Sameer Poyil

LDT-4409 addressed review comments

Options
    • -859
    • +103
    /firmware/App/Controllers/DryBiCart.c
    • -40
    • +0
    /firmware/App/Controllers/DryBiCart.h
7:12 am

Vendor - TEL - Sameer Poyil

We need to keep D64 opened after supply to maintain the supply to fbicarb flow filter

We need to keep D64 opened after supply to maintain the supply to fbicarb flow filter

6:49 am

Vendor - TEL - Sameer Poyil

in initial fill we are not closing D64, only in supply cycle, just before supply start, we close it and when supply end, we open it again. we need to maintain the pressure balance in chamber F

in initial fill we are not closing D64, only in supply cycle, just before supply start, we close it and when supply end, we open it again.
we need to maintain the pressure balance in chamber F

6:45 am

Vendor - TEL - Sameer Poyil

will address it in new file created for mixing

will address it in new file created for mixing