Controllers

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
LDT-3975 WIP initial draft for boost pump refactor

  1. … 7 more files in changeset.
Can we check payload.index is equal to D6_LEVL (instead of above comparision)?

Can we check payload.index is equal to D6_LEVL (instead of above comparision)?

Do we need to check if bicarb chamber level is high, ignore opening D80?

Do we need to check if bicarb chamber level is high, ignore opening D80?

This doesn't seem to be correct. Persistence should start once fill complete pressure is achieved, not after D65 opening?

This doesn't seem to be correct. Persistence should start once fill complete pressure is achieved, not after D65 opening?

Align comment

Align comment

Add comment.

Add comment.

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

LEAHI-DD-FIRMWARE-LDT-3975_Water Treatment and Degassing - FW Iteration - 4/4:
LEAHI-DD-FIRMWARE-LDT-3975_Water Treatment and Degassing - FW Iteration - 4/4:
Remove space after 'Supply'.

Remove space after 'Supply'.

Align the value declaration indentation.

Align the value declaration indentation.

looks you are already checking this state in a line above.

looks you are already checking this state in a line above.

Merge branch LDT-3978-switch-chamber-f-conductive-lev into develop

  1. … 4 more files in changeset.
LDT-3978 fix for conductive level sensor

  1. … 2 more files in changeset.
LDT-872 hetaer control

  1. … 2 more files in changeset.
Don't assign BOOL variables implicitly. Always assign a FALSE or TRUE explicitly with ternary operator or inside an if statement.

Don't assign BOOL variables implicitly. Always assign a FALSE or TRUE explicitly with ternary operator or inside an if statement.

Declare local variables at top of scope.

Declare local variables at top of scope.

Add space between ( and ?

Add space between ( and ?

Remove blank line.

Remove blank line.

Why redeclare result?

Why redeclare result?

Remove blank line.

Remove blank line.

Why are you redeclaring result? This assignment will not survive outside of the if statement.

Why are you redeclaring result? This assignment will not survive outside of the if statement.

Remove blank line.

Remove blank line.

Remove blank line.

Remove blank line.

LDT-3978 conductive level sensor implementation for chamber F fill

  1. … 4 more files in changeset.
Merge branch 'feature/LDT-3963-dialysate-flow-rate---fw-implem' into develop

LDT-3963 fixeed bal chamber issues for low qd

LDT-3978 addressed review comments

  1. … 2 more files in changeset.
LDT-872 heater control update