dd-firmware / firmware / App

Controllers

Clone Tools

Stats

Commits this week: 24
Total Committers: 15
Last Commit: 22 Jun
Commits this week: 24

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 22 Jun
1:27 pm

Vendor - TEL - Jashwant Gantyada

Merge branch 'LDT-4410-dialysate-composition-mixing-2' into develop

Options
    • -8
    • +44
    ./MixingControl.c
1:26 pm

Vendor - TEL - Jashwant Gantyada

LDT-4410 addressed code review comments

Options
    • -11
    • +15
    ./MixingControl.c
  2. … 1 more file in changeset.
12:29 pm

Vinayakam Mani

Can we move this exec at task level, independent of Drybicart operations?

Can we move this exec at task level, independent of Drybicart operations?

12:27 pm

Vinayakam Mani

Comment missing?

Comment missing?

12:18 pm

Vinayakam Mani

Leave a comment here that for acid control period, 3 cycles of balancing chamber switching time (for ex, Qd :600, 3sec is switching period, 3 * 3 = 9 Sec control interval) and for bicarb control, 5...

Leave a comment here that for acid control period, 3 cycles of balancing chamber switching time (for ex, Qd :600, 3sec is switching period, 3 * 3 = 9 Sec control interval) and for bicarb control, 5 cycles of balancing chamber switching time.

12:14 pm

Vinayakam Mani

both acid and bicarb mix volume

both acid and bicarb mix volume

12:07 pm

Vinayakam Mani

Add MULTIPLIER at the end.

Add MULTIPLIER at the end.

11:47 am

Vinayakam Mani

Initialize at init function.

Initialize at init function.

11:47 am

Vinayakam Mani

Remove sample filter ms and task interval. rename as FILTER_SIZE_MULTIPLIER.

Remove sample filter ms and task interval. rename as FILTER_SIZE_MULTIPLIER.

11:37 am

Vinayakam Mani

Lets remove this.

Lets remove this.

10:22 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-4410_Dialysate Composition (Mixing) - FW Implementation - 3/1:
LEAHI-DD-FIRMWARE-LDT-4410_Dialysate Composition (Mixing) - FW Implementation - 3/1:
10:15 am

Vendor - TEL - Jashwant Gantyada

LDT-4410 inital code for filter and control interval

Options
    • -2
    • +34
    ./MixingControl.c
    • -2
    • +3
    ./MixingControl.h
  3. … 1 more file in changeset.
Sunday 21 Jun
9:16 pm

Vendor - TEL - Sameer Poyil

7:22 pm

Vendor - TEL - Sameer Poyil

LDT-4183 closed loop mixing implementation

Options
    • -6
    • +14
    ./BalancingChamber.c
    • -79
    • +156
    ./DryBiCart.c
    • -2
    • +5
    ./DryBiCart.h
  4. … 1 more file in changeset.
Thursday 18 Jun
3:50 pm

Vendor - TEL - Sameer Poyil

Merge branch LDT-4612-dialysate-composition-integ into develop

Options
    • -2
    • +2
    ./DryBiCart.c
3:18 pm

Vendor - TEL - Sameer Poyil

LDT-4612 drybicart updates

Options
    • -2
    • +2
    ./DryBiCart.c
2:35 pm

Vendor - TEL - Sameer Poyil

Merge branch LDT-4612-dialysate-composition-integ into develop

Options
    • -11
    • +8
    ./DryBiCart.c
2:34 pm

Vendor - TEL - Sameer Poyil

LDT-4612 persistence on D66 updates

Options
    • -11
    • +8
    ./DryBiCart.c
1:53 pm

Vinayakam Mani

Looks On event handled later. One event should be fine for On condtion.

Looks On event handled later. One event should be fine for On condtion.

1:51 pm

Vinayakam Mani

Space after 0

Space after 0

1:48 pm

Vinayakam Mani

prevDryBicartState

prevDryBicartState

1:46 pm

Vinayakam Mani

I guess, you should use OnOff status as second argument, since isBalChamberSwitchingActive varirable set after this function, it won't have latest status.

I guess, you should use OnOff status as second argument, since isBalChamberSwitchingActive varirable set after this function, it won't have latest status.

1:31 pm

Vinayakam Mani

prevBalChamberState?

prevBalChamberState?

12:59 pm

Vendor - TEL - Sameer Poyil

LDT-4612 fix for mixing control

Options
    • -2
    • +10
    ./MixingControl.c
  2. … 1 more file in changeset.
10:21 am

Vendor - TEL - Arpita Srivastava

Should we also send an event when we start the heater?

Should we also send an event when we start the heater?

10:11 am

Vendor - TEL - Arpita Srivastava

We can combine all these condition checks in a single if() at line 423 separated by || and then we can send the event change in one line. The code will still work if we remove the first condition c...

We can combine all these condition checks in a single if() at line 423 separated by || and then we can send the event change in one line.
The code will still work if we remove the first condition check for prevState from line 427 and 431

10:10 am

Vendor - TEL - Sameer Poyil

LDT-4612 integrating fix for concentrate pump not running into develop

Options
    • -2
    • +2
    ./BalancingChamber.c
    • -2
    • +2
    ./ConcentratePumps.c
    • -25
    • +19
    ./DryBiCart.c
  4. … 4 more files in changeset.
10:06 am

Vendor - TEL - Sameer Poyil

LDT-4409 fix for concentrate pump not running

Options
    • -3
    • +0
    ./DryBiCart.c
    • -1
    • +1
    ./MixingControl.c
  3. … 1 more file in changeset.
4:02 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-4612_Dialysate Composition (Dry Bicarbonate) - FW Iteration - 4/1:
LEAHI-DD-FIRMWARE-LDT-4612_Dialysate Composition (Dry Bicarbonate) - FW Iteration - 4/1:
Wednesday 17 Jun
10:13 pm

Vendor - TEL - Sameer Poyil

LDT-4612 fix for micing control integration issues

Options
    • -21
    • +18
    ./DryBiCart.c
    • -3
    • +7
    ./MixingControl.c