dd-firmware / firmware / App

Controllers

Clone Tools

Stats

Commits this week: 23
Total Committers: 15
Last Commit: 30 Jun
Commits this week: 23

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 25 Jun
2:46 pm

Vendor - TEL - Sameer Poyil

LDT-4612 depressurize sanity test updates

Options
    • -11
    • +0
    ./DryBiCart.c
12:29 pm

Vendor - TEL - Sameer Poyil

LDT-4612 mixing control updates

Options
    • -0
    • +2
    ./MixingControl.c
12:27 pm

Vendor - TEL - Sameer Poyil

LDT-4612 depressurize updates

Options
    • -1
    • +4
    ./DryBiCart.c
9:15 am

Vendor - TEL - Sameer Poyil

LDT-4612 reseting the top level state machine when depressurize completed

Options
    • -0
    • +2
    ./DryBiCart.c
Wednesday 24 Jun
6:56 pm

Vendor - TEL - Sameer Poyil

LDT-4612 addressed review comments

Options
    • -2
    • +13
    ./DryBiCart.c
  2. … 1 more file in changeset.
5:15 pm

Vendor - TEL - Sameer Poyil

LDT-4612 addressed review comments

Options
    • -7
    • +61
    ./DryBiCart.c
4:54 pm

Vendor - TEL - Sameer Poyil

LDT-4612 addressed review comments

Options
    • -1
    • +1
    ./BalancingChamber.c
    • -80
    • +72
    ./DryBiCart.c
    • -2
    • +2
    ./DryBiCart.h
    • -1
    • +1
    ./MixingControl.c
  5. … 3 more files in changeset.
2:53 pm

Vendor - TEL - Sameer Poyil

2:47 pm

Vinayakam Mani

Space after if.

Space after if.

2:45 pm

Vinayakam Mani

Can we bring depressurize as well one of the states like fill, supply and drain? And the same way when one of the operations initiated and other should not kick in.

Can we bring depressurize as well one of the states like fill, supply and drain? And the same way when one of the operations initiated and other should not kick in.

2:40 pm

Vinayakam Mani

remove empty space after d66pressure variable. or match the indent to previous statement.

remove empty space after d66pressure variable. or match the indent to previous statement.

2:40 pm

Vendor - TEL - Sameer Poyil

2:36 pm

Vinayakam Mani

Add a TODO comment (remove later): this should be handled in IO/FP module.

Add a TODO comment (remove later): this should be handled in IO/FP module.

2:33 pm

Vinayakam Mani

Update comment.

Update comment.

2:32 pm

Vinayakam Mani

Add comment.

Add comment.

2:31 pm

Vinayakam Mani

Depressurize?

Depressurize?

2:22 pm

Vinayakam Mani

Fix the typo.

Fix the typo.

2:14 pm

Vendor - TEL - Sameer Poyil

LDT-4612 adressing review comments

Options
    • -4
    • +4
    ./DryBiCart.c
2:09 pm

Vendor - TEL - Sameer Poyil

LDT-4612 depressurise state machine implementation

Options
    • -0
    • +28
    ./BalancingChamber.c
    • -0
    • +2
    ./BalancingChamber.h
    • -3
    • +154
    ./DryBiCart.c
    • -0
    • +2
    ./DryBiCart.h
  5. … 3 more files in changeset.
1:49 pm

Vendor - TEL - Sameer Poyil

moved to general task

moved to general task

1:02 pm

Vendor - TEL - Sameer Poyil

12:50 pm

Vendor - TEL - Sameer Poyil

We need to keep D64 opened after supply to maintain the supply to bicarb green flow filter

We need to keep D64 opened after supply to maintain the supply to bicarb green flow filter

6:39 am

Raghu Kallala

WIP changes to concentrate pump homing command

Options
    • -36
    • +62
    ./ConcentratePumps.c
6:36 am

Raghu Kallala

Tuesday 23 Jun
3:38 pm

Vendor - TEL - Sameer Poyil

LEAHI-DD-FIRMWARE-LDT-4409_Dialysate Composition (Dry Bicarbonate) - FW Implementation - 3/1:
LEAHI-DD-FIRMWARE-LDT-4409_Dialysate Composition (Dry Bicarbonate) - FW Implementation - 3/1:
2:47 pm

Vinayakam Mani

There are multiple target bicarb conductivity calls, getBicarbTargetConductivity, getBicardConductivityPre and getBicarConductivityPost. If you are using getBicarbTargetConductivity for deadband co...

There are multiple target bicarb conductivity calls, getBicarbTargetConductivity, getBicardConductivityPre and getBicarConductivityPost. If you are using getBicarbTargetConductivity for deadband control check, use the same for 'runPIcontroller' function as well.

2:40 pm

Vinayakam Mani

This should return POST conductivity.

This should return POST conductivity.

2:20 pm

Vinayakam Mani

getBicarbConductivityPre() -> This function gets the target conductivity from the mixing algorithm. For testing, recommend using defined value and check the behavior.

getBicarbConductivityPre() -> This function gets the target conductivity from the mixing algorithm. For testing, recommend using defined value and check the behavior.

2:04 pm

Vinayakam Mani

Init PI Controls missing here.

Init PI Controls missing here.

1:57 pm

Vinayakam Mani

13734.87F

13734.87F