dd-firmware / firmware / App / Modes / FPModes

FlushPermeate.c

Clone Tools

Stats

Commits this week: 7
Total Committers: 6
Last Commit: 07:27
Commits this week: 7

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 10 Dec
4:32 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -4
    • +4
    ./FlushPermeate.c
  2. … 121 more files in changeset.
Tuesday 09 Dec
11:25 am

Raghu Kallala

11:15 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./FlushPermeate.c
  2. … 19 more files in changeset.
11:12 am

Raghu Kallala

Resolved merge conflicts

Options
    • -10
    • +37
    ./FlushPermeate.c
  2. … 19 more files in changeset.
10:43 am

Sean Nash , Vinayakam Mani and Michael Garthwaite

10:29 am

Raghu Kallala

Resolved

Resolved

10:29 am

Raghu Kallala

LDT-2936 fixed the macro comments

Options
    • -1
    • +1
    ./FlushPermeate.c
10:16 am

Sean Nash

Change comment from 3 to 5 minutes to match code.

Change comment from 3 to 5 minutes to match code.

10:14 am

Sean Nash

I don't see fix

I don't see fix

10:03 am

Raghu Kallala

Fixed the ordering

Fixed the ordering

8:36 am

Raghu Kallala

LDT-2936 fixed permeate overfill issue and added tank controls to verify state

Options
    • -1
    • +1
    ./FlushPermeate.c
  2. … 5 more files in changeset.
Monday 08 Dec
8:43 am

Vendor - TEL - Sameer Poyil

LDT-2936-iofp RO permeate flush timeout LDT-1755

Options
    • -4
    • +4
    ./FlushPermeate.c
Friday 05 Dec
3:01 pm

Sean Nash

I'm confused as to why the available alarm that this alarm replaced is in a different row within this table. That seems wrong.

I'm confused as to why the available alarm that this alarm replaced is in a different row within this table. That seems wrong.

1:26 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -4
    • +4
    ./FlushPermeate.c
  2. … 121 more files in changeset.
Thursday 04 Dec
10:30 am

Raghu Kallala

LDT-2936 address review comments to add spacing in if statements

Options
    • -3
    • +4
    ./FlushPermeate.c
  2. … 4 more files in changeset.
10:18 am

Raghu Kallala

Handled in FPOperationModes and respective states of PreGen have it.

Handled in FPOperationModes and respective states of PreGen have it.

10:17 am

Raghu Kallala

Checked with Eliza if they need it for alarm persistence time. Not needed at this time, we can add them in future

Checked with Eliza if they need it for alarm persistence time. Not needed at this time, we can add them in future

10:15 am

Raghu Kallala

Fixed. Thanks

Fixed. Thanks

10:14 am

Raghu Kallala

Fixed.

Fixed.

10:11 am

Raghu Kallala

Fixed.

Fixed.

10:10 am

Raghu Kallala

Fixed. thanks

Fixed. thanks

9:00 am

Sean Nash

I don't think the number of samples is what you want as 3rd parameter. You want number of bytes so 4 x number of samples so you should pass "sizeof( roRRSamples )".

I don't think the number of samples is what you want as 3rd parameter. You want number of bytes so 4 x number of samples so you should pass "sizeof( roRRSamples )".

8:57 am

Sean Nash

Put space between if and ( for all conditions in this function.

Put space between if and ( for all conditions in this function.

8:55 am

Sean Nash

Put first condition in () too.

Put first condition in () too.

Wednesday 03 Dec
5:58 pm

Vendor - TEL - Sameer Poyil

Small letter used

Small letter used

2:35 pm

Raghu Kallala

LDT-2936 added permeate flush exit criteria. Resolved compile errors

Options
    • -1
    • +17
    ./FlushPermeate.c
  2. … 5 more files in changeset.
10:38 am

Raghu Kallala

Resolved.

Resolved.

10:34 am

Raghu Kallala

Resolved. Thanks

Resolved. Thanks

8:43 am

Raghu Kallala

We might need to provide a possibility to override the persistence time on alarm. To be clarified.

We might need to provide a possibility to override the persistence time on alarm. To be clarified.

8:38 am

Raghu Kallala

Published in the respective modules

Published in the respective modules