dd-firmware / firmware / App / Monitors

BloodLeak.c

Clone Tools

Stats

Commits this week: 2
Total Committers: 5
Last Commit: 06 Mar
Commits this week: 2

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 05 Mar
5:12 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./BloodLeak.c
5:10 pm

Dara Navaei

4:36 pm

Vendor - TEL - Jashwant Gantyada and Sean Nash

4:25 pm

Dara Navaei

3:07 pm

Dara Navaei

LDT-3605 added code in the blood leak driver to reset its state machine once the hardware configuration has changed

Options
    • -3
    • +16
    ./BloodLeak.c
3:02 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-3605_(DD) BLD sensor intermittently does not read for B2.0 HW
LEAHI-DD-FIRMWARE-LDT-3605_(DD) BLD sensor intermittently does not read for B2.0 HW
Thursday 12 Feb
5:14 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./BloodLeak.c
  2. … 3 more files in changeset.
4:56 pm

Vendor - TEL - Jashwant Gantyada

4:55 pm

Sean Nash and Vendor - TEL - Sameer Poyil

2:02 pm

Sean Nash

Can these be done without loop (just fix the size to cover both columns of the array)?

Can these be done without loop (just fix the size to cover both columns of the array)?

2:01 pm

Sean Nash

This memset should be deleted since handled above in loop now.

This memset should be deleted since handled above in loop now.

2:00 pm

Sean Nash

Add a blank line after declaration.

Add a blank line after declaration.

1:54 pm

Vendor - TEL - Sameer Poyil

implement it in a single structure packing by moving all other pragma pack

implement it in a single structure packing by moving all other pragma pack

1:50 pm

Vendor - TEL - Jashwant Gantyada

done

done

1:45 pm

Vendor - TEL - Jashwant Gantyada

done

done

1:45 pm

Vendor - TEL - Jashwant Gantyada

changed

changed

1:45 pm

Vendor - TEL - Jashwant Gantyada

done

done

1:45 pm

Vendor - TEL - Jashwant Gantyada

done

done

1:45 pm

Vendor - TEL - Jashwant Gantyada

done

done

1:44 pm

Vendor - TEL - Jashwant Gantyada

done.

done.

1:44 pm

Vendor - TEL - Jashwant Gantyada

done.

done.

1:44 pm

Vendor - TEL - Jashwant Gantyada

done.

done.

1:44 pm

Vendor - TEL - Jashwant Gantyada

declared in the header and updated them.

declared in the header and updated them.

1:43 pm

Vendor - TEL - Jashwant Gantyada

Resolved. Thanks

Resolved. Thanks

1:43 pm

Vendor - TEL - Jashwant Gantyada

Resolved. Thanks

Resolved. Thanks

1:43 pm

Vendor - TEL - Jashwant Gantyada

LDT-2030 addressed code review comments

Options
    • -7
    • +6
    ./BloodLeak.c
  2. … 2 more files in changeset.
Wednesday 11 Feb
2:30 pm

Sean Nash

We can but not necessary - only necessary when using == operator.

We can but not necessary - only necessary when using == operator.

2:29 pm

Vendor - TEL - Arpita Srivastava

Can we write it as ( NU_EMB_MODE_CMD != expChar1 ) ?

Can we write it as ( NU_EMB_MODE_CMD != expChar1 ) ?

2:23 pm

Vendor - TEL - Arpita Srivastava

Minor: There is a typo with Inputs

Minor: There is a typo with Inputs

1:34 pm

Sean Nash

For init functions, I'm ok with saying something like "Blood leak driver unit variables initialized".

For init functions, I'm ok with saying something like "Blood leak driver unit variables initialized".