dd-firmware

Clone Tools

Stats

Commits this week: 43
Total Committers: 14
Last Commit: 14:01
Commits this week: 43

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
2 hrs ago

Sean Nash

I think cal data and count should be retrieved by same function and possibly needs some interrupt protection to ensure data and count stick together. If these functions are called from general task...

I think cal data and count should be retrieved by same function and possibly needs some interrupt protection to ensure data and count stick together. If these functions are called from general task, we could have situation where data is retrieved, then priority task updates fpga, and then counter is retrieved with wrong (incremented) counter.
If these two functions are being called from a driver that is executed in priority task, then we don't need to worry about this situation, but still ought to add a constraint/warning comment in function headers noting that these functions should only be called from priority task.

2 hrs ago

Sean Nash

Remove extra blank line.

Remove extra blank line.

2 hrs ago

Sean Nash

It is your comment, so please resolve it.

It is your comment, so please resolve it.

2 hrs ago

Sean Nash

I think Dialin will need get (or UI proxy) commands to have us send cal, s/n, and versions.

I think Dialin will need get (or UI proxy) commands to have us send cal, s/n, and versions.

2 hrs ago

Sean Nash

Do FP sensors have to be treated separately? I realize there needs to be separate messages as they will be coming from different Dialin classes, but can't we handle both messages with same function...

Do FP sensors have to be treated separately? I realize there needs to be separate messages as they will be coming from different Dialin classes, but can't we handle both messages with same function (assuming shared enum to index)?

2 hrs ago

Sean Nash

General Dialin question - does it make sense to override temperatures at driver level where they are spread out over several drivers? I would think overriding at monitor level would be simpler wher...

General Dialin question - does it make sense to override temperatures at driver level where they are spread out over several drivers? I would think overriding at monitor level would be simpler where they are all in one place and could be indexed by enum with single command.

2 hrs ago

Sean Nash

Do we need to say Value?

Do we need to say Value?

2 hrs ago

Sean Nash

Add a blank line after public defs banner. Add a dox comment to the right. I believe they reserve space for 12 bytes, not 10. Not really for calibration - it's for s/n and versions.

Add a blank line after public defs banner.
Add a dox comment to the right.
I believe they reserve space for 12 bytes, not 10.
Not really for calibration - it's for s/n and versions.

2 hrs ago

Sean Nash

Are these really going to be different types? I assumed they would all be floats.

Are these really going to be different types? I assumed they would all be floats.

2 hrs ago

Sean Nash

Structures need a top level dox comment.

Structures need a top level dox comment.

2 hrs ago

Sean Nash

enums need a top level dox comment.

enums need a top level dox comment.

2 hrs ago

Vendor - TEL - Sameer Poyil

This function also not using u32ArrayOverride()

This function also not using u32ArrayOverride()

2 hrs ago

Vendor - TEL - Sameer Poyil

is it possible to use the function u32ArrayOverride() here ?

is it possible to use the function u32ArrayOverride() here ?

2 hrs ago

Sean Nash

I believe conductivity and temperature data will be F32s.

I believe conductivity and temperature data will be F32s.

2 hrs ago

Sean Nash

Do we not need this anymore? I still see it in code all over the place and I don't think we're done w/ Teensy until Beta 1.9 units are obsolete.

Do we not need this anymore? I still see it in code all over the place and I don't think we're done w/ Teensy until Beta 1.9 units are obsolete.

2 hrs ago

Sean Nash

Are we sure about the reversing of states here? If we had this backward, I would think the Systems team would have had a much bigger complaint. The description of their issue suggests that the 8 BC...

Are we sure about the reversing of states here? If we had this backward, I would think the Systems team would have had a much bigger complaint.
The description of their issue suggests that the 8 BC valves were correctly commanded to requested state except for the one they separately commanded earlier.
If we had this backward, I would think they would have said that all 8 valves did the wrong thing.

2 hrs ago

Sean Nash

I don't think mask or pos require initialization either.

I don't think mask or pos require initialization either.

3 hrs ago

Sean Nash

I don't think valve needs to be initialized here. The for loop initializes it.

I don't think valve needs to be initialized here. The for loop initializes it.

4 hrs ago

Vendor - TEL - Sameer Poyil

It is replied by Vinay , there is no need to maintain two different rpm. so we can close this.

It is replied by Vinay , there is no need to maintain two different rpm. so we can close this.

4 hrs ago

Sean Nash

For these functions that set specific valves, we should specify which (e.g. recovery valves or balancing chamber valves, or ...).

For these functions that set specific valves, we should specify which (e.g. recovery valves or balancing chamber valves, or ...).

4 hrs ago

Sean Nash

Remove blank line.

Remove blank line.

5 hrs ago

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-3222_Command to override all balancing chamber valves states should be the same priority as setting individual valve state overrides
LEAHI-DD-FIRMWARE-LDT-3222_Command to override all balancing chamber valves states should be the same priority as setting individual valve state overrides
5 hrs ago

Vendor - TEL - Sameer Poyil

It will be fixed in Balancing chamber re-implementation

It will be fixed in Balancing chamber re-implementation

5 hrs ago

Michael Garthwaite

LDT-2004: comment updates

Options
    • -11
    • +9
    /firmware/App/Drivers/ConductivitySensors.c
5 hrs ago

Vendor - TEL - Sameer Poyil

I would prefer to fix this in balancing chamber new algorithm implementation. That is why i didn't mark it as Unresolved.

I would prefer to fix this in balancing chamber new algorithm implementation. That is why i didn't mark it as Unresolved.

6 hrs ago

Michael Garthwaite

LDT-2004: cal data and read functionality.

Options
    • -35
    • +357
    /firmware/App/Drivers/ConductivitySensors.c
    • -1
    • +1
    /firmware/App/Drivers/ConductivitySensors.h
    • -1
    • +1
    /firmware/App/Monitors/Conductivity.c
6 hrs ago

Michael Garthwaite

10 hrs ago

Michael Garthwaite

LDT-2004: data structures and public functions

Options
    • -3
    • +0
    /firmware/App/DDCommon.h
    • -754
    • +266
    /firmware/App/Drivers/ConductivitySensors.c
    • -29
    • +79
    /firmware/App/Drivers/ConductivitySensors.h
    • -1
    • +1
    /firmware/App/Monitors/Conductivity.h
    • -1
    • +1
    /firmware/App/Monitors/Temperature.c
    • -49
    • +720
    /firmware/App/Services/FpgaDD.c
    • -91
    • +43
    /firmware/App/Services/FpgaDD.h
    • -4
    • +4
    /firmware/App/Services/Messaging.c
Monday 02 Feb
3:41 pm

Vendor - TEL - Sameer Poyil

fixed it

fixed it

3:39 pm

Vendor - TEL - Sameer Poyil

fixed it

fixed it