Services

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
WIP on LDT-4000-hdf-fw-implementation-1

  1. … 5 more files in changeset.
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 12 more files in changeset.
LDT-4188 addressed review comments

To resolve the build failure with DD, haven't added all the features, instead added TODO comment

To resolve the build failure with DD, haven't added all the features, instead added TODO comment

Idea is to have this in institutional records we implement it

Idea is to have this in institutional records we implement it

a time out for decaying D66 pressure to 3 PSI after D65 closed

a time out for decaying D66 pressure to 3 PSI after D65 closed

If this is const, how will user add conversions (after 3rd value)?

If this is const, how will user add conversions (after 3rd value)?

Remove extra blank line.

Remove extra blank line.

LDT-3963 enabled fault mode tranisiton for switching off hetares for dilaysate flow rate testing

  1. … 10 more files in changeset.
remove space after <= and add space end of function call.

remove space after <= and add space end of function call.

Is this time out after D80 opening or D65 closing state? if it is D65 closed, you need to start the timer after D65 closing.

Is this time out after D80 opening or D65 closing state? if it is D65 closed, you need to start the timer after D65 closing.

if we are not checking level, this can be removed and function name also can be updated accordingly.

if we are not checking level, this can be removed and function name also can be updated accordingly.

Is this a TODO? If so, add TODO to the comment and maybe be a little more descriptive of what needs to be done.

Is this a TODO? If so, add TODO to the comment and maybe be a little more descriptive of what needs to be done.

can we get 'runPIController' inside deadband control check?

can we get 'runPIController' inside deadband control check?

Can we add sodium and bicarb overrides now, so that we don't want to come back again for this change? Also, please get the dialin updated to reflect the new parameters additions in tdproxy and let ...

Can we add sodium and bicarb overrides now, so that we don't want to come back again for this change?
Also, please get the dialin updated to reflect the new parameters additions in tdproxy and let system team be in loop to update the required system scripts?

LDT-4188 updated set pre-gen and gen dialysate function calls

First two logics ANDed correct (first cycle and close period). the third one (BC switch only must be ANDed only with close period), not to include first cycle..

First two logics ANDed correct (first cycle and close period). the third one (BC switch only must be ANDed only with close period), not to include first cycle..

LDT-3975 WIP initial draft for boost pump refactor

  1. … 8 more files in changeset.
LEAHI-DD-FIRMWARE-LDT-4188_SW/FW integration to run a Treatment from UI
LEAHI-DD-FIRMWARE-LDT-4188_SW/FW integration to run a Treatment from UI
Can we check payload.index is equal to D6_LEVL (instead of above comparision)?

Can we check payload.index is equal to D6_LEVL (instead of above comparision)?

LEAHI-DD-FIRMWARE-LDT-3975_Water Treatment and Degassing - FW Iteration - 4/4:
LEAHI-DD-FIRMWARE-LDT-3975_Water Treatment and Degassing - FW Iteration - 4/4:
Remove space after 'Supply'.

Remove space after 'Supply'.

Align the value declaration indentation.

Align the value declaration indentation.

looks you are already checking this state in a line above.

looks you are already checking this state in a line above.

LEAHI-DD-FIRMWARE-LDT-4000_HDF - FW Implementation - 1/4:
LEAHI-DD-FIRMWARE-LDT-4000_HDF - FW Implementation - 1/4: