dd-firmware / firmware

App

Clone Tools

Stats

Commits this week: 20
Total Committers: 15
Last Commit: 19 Feb
Commits this week: 20

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 11 Feb
6:58 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./Monitors/Temperature.c
    • -2
    • +2
    ./Monitors/Temperature.h
6:11 am

Sean Nash

6:11 am

Vendor - TEL - Jashwant Gantyada

changed.

changed.

Tuesday 10 Feb
5:25 pm

Sean Nash

Add a comment to right listing math functions used.

Add a comment to right listing math functions used.

5:24 pm

Sean Nash

Remove blank line.

Remove blank line.

5:20 pm

Sean Nash

Can you follow up with whoever commented it out and find out if that was intentional? And, if so, will it be coming back? And, if so, should we at least put a TODO on this to restore later?

Can you follow up with whoever commented it out and find out if that was intentional? And, if so, will it be coming back? And, if so, should we at least put a TODO on this to restore later?

5:17 pm

Sean Nash

Why not "TRUE == "?

Why not "TRUE == "?

5:16 pm

Sean Nash

Why not "TRUE == "?

Why not "TRUE == "?

5:15 pm

Sean Nash

Remove blank line.

Remove blank line.

5:14 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

5:13 pm

Sean Nash

Outputs in none now I think.

Outputs in none now I think.

5:12 pm

Sean Nash

Looks like you updated wrong function (the one below instead of this one). It's an output in function below and it's an input in this function.

Looks like you updated wrong function (the one below instead of this one). It's an output in function below and it's an input in this function.

5:10 pm

Sean Nash

Why did this file get deleted?

Why did this file get deleted?

5:03 pm

Sean Nash

Add blank line between declarations and rest of code.

Add blank line between declarations and rest of code.

5:02 pm

Sean Nash

Add comment to right listing which math functions we're using.

Add comment to right listing which math functions we're using.

3:33 pm

Vendor - TEL - Sameer Poyil

It is there in line 131 It would be nice to have it clubbed it together like #ifdef _TEENSY_CONDUCTIVITY_DRIVER_ place all code for teensy here { MSG_ID_DD_SET_CONDUCTIVITY_MODEL_REQUEST, &testSe...

It is there in line 131

It would be nice to have it clubbed it together like

#ifdef _TEENSY_CONDUCTIVITY_DRIVER_
place all code for teensy here

Unknown macro: { MSG_ID_DD_SET_CONDUCTIVITY_MODEL_REQUEST, &testSetTeenyConductivityModel }

,
#else
// move the all code under #ifndef _TEENSY_CONDUCTIVITY_DRIVER_ here

#endif

3:13 pm

Michael Garthwaite

fixed.

fixed.

3:12 pm

Michael Garthwaite

reordered and wrapped in a macro

reordered and wrapped in a macro

3:12 pm

Michael Garthwaite

see other comment.

see other comment.

3:12 pm

Michael Garthwaite

reordered MSG IDs such that the teensy specific ones are wrapped in a macro and are far enough in sequence to not cause trouble when we are ready to remove them.

reordered MSG IDs such that the teensy specific ones are wrapped in a macro and are far enough in sequence to not cause trouble when we are ready to remove them.

3:11 pm

Dara Navaei

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./DDCommon.h
3:11 pm

Michael Garthwaite

fixed.

fixed.

3:11 pm

Michael Garthwaite

removed

removed

3:10 pm

Michael Garthwaite

fixed.

fixed.

3:10 pm

Michael Garthwaite

it stop gap to see if it was valve specific. Its been reverted.

it stop gap to see if it was valve specific. Its been reverted.

3:09 pm

Michael Garthwaite

Merge branch 'LDT-3173-io-pressure-sensors' into develop

LDT-3372: code review comments. re ordered messaging

Options
    • -12
    • +13
    ./Services/Messaging.c
3:07 pm

Michael Garthwaite

LDT-3372: code review comments. fixes to valve pwm configuration. reordered msg look up table for messages in relation to teensy

Options
    • -3
    • +3
    ./Controllers/Valves.c
    • -1
    • +1
    ./Drivers/ConductivityTeensy.c
    • -12
    • +11
    ./Services/Messaging.c
2:52 pm

Dara Navaei

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./DDCommon.h
2:49 pm

Michael Garthwaite

Merge branch 'LDT-3173-io-pressure-sensors' into develop

Options
    • -0
    • +8
    ./Services/Messaging.c
2:45 pm

Michael Garthwaite

Merge branch 'staging' into LDT-3173-io-pressure-sensors

Options
    • -126
    • +147
    ./Controllers/Valves.c
    • -2
    • +10
    ./Services/Messaging.c