dd-firmware / firmware

App

Clone Tools

Stats

Commits this week: 35
Total Committers: 16
Last Commit: 23 Apr
Commits this week: 35

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 17 Feb
4:36 pm

Vendor - TEL - Jashwant Gantyada

LDT-3103 addressed code review comments

Options
    • -3
    • +2
    ./Controllers/BalancingChamber.c
    • -5
    • +4
    ./Modes/ModeGenDialysate.c
4:36 pm

Vendor - TEL - Jashwant Gantyada

LDT-3750 cherry-picked 3bafab7

Options
    • -3
    • +2
    ./Controllers/BalancingChamber.c
    • -2
    • +2
    ./Modes/ModeGenDialysate.c
4:31 pm

Vendor - TEL - Jashwant Gantyada

Vinayakam Mani had it removed. Can you please let us know why you have this commented out in latest staging?

Vinayakam Mani had it removed. Can you please let us know why you have this commented out in latest staging?

3:35 pm

Vendor - TEL - Jashwant Gantyada

done. added a TODO.

done. added a TODO.

3:34 pm

Vendor - TEL - Jashwant Gantyada

I have added the mentioned ones.

I have added the mentioned ones.

3:34 pm

Vendor - TEL - Jashwant Gantyada

done.

done.

3:34 pm

Vendor - TEL - Jashwant Gantyada

done.

done.

3:34 pm

Vendor - TEL - Jashwant Gantyada

done.

done.

3:32 pm

Vendor - TEL - Jashwant Gantyada

done

done

3:32 pm

Vendor - TEL - Jashwant Gantyada

done

done

3:32 pm

Vendor - TEL - Jashwant Gantyada

added a todo.

added a todo.

3:32 pm

Vendor - TEL - Jashwant Gantyada

removed.

removed.

3:31 pm

Michael Garthwaite

3:30 pm

Vendor - TEL - Jashwant Gantyada

LDT-3344 addressed code review comments

Options
    • -37
    • +22
    ./Controllers/RinsePump.c
    • -16
    • +17
    ./Services/FpgaDD.c
1:34 pm

Vinayakam Mani

we can start with 500msec. if we change the speed during runtime, say 10% to 20% PWM, need to see how long it takes to stabilize and accordingly this persistence can be set.

we can start with 500msec. if we change the speed during runtime, say 10% to 20% PWM, need to see how long it takes to stabilize and accordingly this persistence can be set.

11:22 am

Michael Garthwaite

Merge branch 'staging' into LDT-2004-v2-conductivity-sensors

Options
    • -1
    • +1
    ./DDCommon.h
10:19 am

Dara Navaei

LDT-3552 added a #define for the blood leak response buffer

Options
    • -1
    • +3
    ./Drivers/BloodLeakDriver.h
10:16 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-3552_The FW Message List generated aren't able to decode some messages
LEAHI-DD-FIRMWARE-LDT-3552_The FW Message List generated aren't able to decode some messages
9:57 am

Raghu Kallala

Vinay, based on your work with rinsepump, Do you have any persistence value in mind?

Vinay, based on your work with rinsepump, Do you have any persistence value in mind?

9:54 am

Raghu Kallala

LDT-3344 set D79 to default PWM to 45%

Options
    • -1
    • +1
    ./Controllers/RinsePump.c
9:27 am

Michael Garthwaite

LDT-3218: init commit to have flow curve based on recovery settings.

Options
    • -0
    • +5
    ./Controllers/ROPump.c
    • -1
    • +14
    ./Controllers/Valves.c
    • -0
    • +1
    ./Controllers/Valves.h
    • -1
    • +0
    ./Modes/FPModes/ModePreGenPermeate.c
    • -1
    • +0
    ./Modes/FPModes/StateFlushPermeate.c
Friday 13 Feb
5:08 pm

Vinayakam Mani

Can we check some persistence before declaring alarm?

Can we check some persistence before declaring alarm?

5:07 pm

Vinayakam Mani

recommend running the pump at few sample speeds and observe the measured feedback and fix the tolerance number.

recommend running the pump at few sample speeds and observe the measured feedback and fix the tolerance number.

4:46 pm

Vinayakam Mani

Rinse pump fault? do we have one? remove concentrate references, commented codes, empty lines.

Rinse pump fault? do we have one? remove concentrate references, commented codes, empty lines.

4:17 pm

Vinayakam Mani

LDT-3352 resolving merge conflicts

Options
    • -4
    • +1
    ./Modes/ModeGenDialysate.c
3:47 pm

Sean Nash

Looks like we are doing a lot of the dialysate temp control in Gen Dialysate mode. Do we not do any heating in PreGen mode? Even if all dialysate heating is done in this mode, should we consider cr...

Looks like we are doing a lot of the dialysate temp control in Gen Dialysate mode. Do we not do any heating in PreGen mode?
Even if all dialysate heating is done in this mode, should we consider creating a service controller (like BC controller) to manage this complex temperature control?

3:38 pm

Sean Nash

Resolve merge conflicts.

Resolve merge conflicts.

1:54 pm

Michael Garthwaite

LDT-3372: Reduced warnings in relation to teensy driver. Removed unused functions. Fixed overrides

Options
    • -131
    • +28
    ./Drivers/ConductivityTeensy.c
    • -2
    • +2
    ./Drivers/ConductivityTeensy.h
    • -8
    • +8
    ./Monitors/Conductivity.c
1:33 pm

Vendor - TEL - Jashwant Gantyada

LDT-3344 addressed code review comments

Options
    • -8
    • +119
    ./Controllers/RinsePump.c
    • -2
    • +6
    ./Controllers/RinsePump.h
    • -1
    • +37
    ./Drivers/GPIO.c
    • -0
    • +12
    ./Drivers/GPIO.h
    • -13
    • +11
    ./Monitors/Level.c
    • -39
    • +30
    ./Services/FpgaDD.c
    • -0
    • +4
    ./Tasks/TaskPriority.c
12:00 pm

Michael Garthwaite

LDT-2004: updates to v2 driver. changed data types for cal coefficents to f32. Implemented calculated resistance, temp, and conductivity based on raw data from sensor.

Options
    • -21
    • +129
    ./Drivers/ConductivitySensors.c
    • -8
    • +8
    ./Drivers/ConductivitySensors.h
    • -17
    • +8
    ./Monitors/Conductivity.c