Activity dd-firmware/firmware/App

Tree
Accordion

Stats

Commits this week: 31

Total Committers:	15
Last Commit:	05 Mar
Commits this week:	31

Lines of code count not available

Commit Activity

last updated a few seconds ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

Start Date:

End Date:

End Date:

Tuesday 03 Mar

3:32 pm

Dara Navaei

More
4ea0591
changed 2 files
LDT-2004-v2-conductivity-sensors, LDT-3218-update-iofp-permeate-target-flow and 7 more LEAHI-DD-FIRMWARE-LDT-2004-4

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -2
- +2
./Controllers/BalancingChamber.c
- History
- Source
- Diff
./Controllers/BalancingChamber.c
- -1
- +1
./Modes/ModeStandby.c
- History
- Source
- Diff
./Modes/ModeStandby.c

3:30 pm

Dara Navaei

More
3a449bc
changed 1 file
develop

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

- -1
- +1
./DDCommon.h
- History
- Source
- Diff
./DDCommon.h

3:27 pm

Vendor - TEL - Jashwant Gantyada and Vinayakam Mani

More
LEAHI-DD-FIRMWARE-LDT-3219-3
finished reviewing

3:27 pm

Vendor - TEL - Jashwant Gantyada and Vinayakam Mani

More
LEAHI-DD-FIRMWARE-LDT-3219-3
joined review

2:44 pm

Dara Navaei

More
LEAHI-DD-FIRMWARE-LDT-3219-3
started review

LDT-3219 removing D3 open in standby mode

LDT-3219 removing D3 open in standby mode

2:16 pm

Dara Navaei

More
b115c2f
changed 1 file
LDT-2004-v2-conductivity-sensors, LDT-3218-update-iofp-permeate-target-flow and 7 more

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

- -1
- +1
./DDCommon.h
- History
- Source
- Diff
./DDCommon.h

2:16 pm

Dara Navaei

More
adb60c3
changed 1 file
LDT-2004-v2-conductivity-sensors, LDT-3218-update-iofp-permeate-target-flow and 7 more

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -2
- +2
./Monitors/WaterQualityMonitor.c
- History
- Source
- Diff
./Monitors/WaterQualityMonitor.c

2:13 pm

Michael Garthwaite

1:40 pm

Vinayakam Mani

More
LEAHI-DD-FIRMWARE-LDT-3514-1
finished reviewing

9:28 am

Michael Garthwaite

More
6ffea00
changed 2 files
LDT-3218-update-iofp-permeate-target-flow LEAHI-DD-FIRMWARE-LDT-3218-3

Merge branch 'staging' into LDT-3218-update-iofp-permeate-target-flow

- -3
- +3
./Controllers/Valves.c
- History
- Source
- Diff
./Controllers/Valves.c
- -8
- +3
./Controllers/Valves.h
- History
- Source
- Diff
./Controllers/Valves.h

Monday 02 Mar

3:11 pm

Michael Garthwaite

More
4643a4b
changed 10 files
LDT-2004-v2-conductivity-sensors LEAHI-DD-FIRMWARE-LDT-2004-4

LDT-2004: warning reduction relating to teensy driver. Removed Ifdefs for teensy and replaced some of them as beta 1.9 test config. WIP.

- -5
- +12
./Controllers/Heaters.c
- History
- Source
- Diff
./Controllers/Heaters.c
- -2
- +11
./Drivers/ConductivitySensors.c
- History
- Source
- Diff
./Drivers/ConductivitySensors.c
- -17
- +1
./Drivers/ConductivitySensors.h
- History
- Source
- Diff
./Drivers/ConductivitySensors.h
- -17
- +17
./Drivers/ConductivityTeensy.c
- History
- Source
- Diff
./Drivers/ConductivityTeensy.c
- -19
- +3
./Drivers/ConductivityTeensy.h
- History
- Source
- Diff
./Drivers/ConductivityTeensy.h
- -16
- +20
./Monitors/Conductivity.c
- History
- Source
- Diff
./Monitors/Conductivity.c
- -3
- +1
./Monitors/Conductivity.h
- History
- Source
- Diff
./Monitors/Conductivity.h
- -25
- +33
./Monitors/Temperature.c
- History
- Source
- Diff
./Monitors/Temperature.c
- -5
- +3
./Services/Interrupts.c
- History
- Source
- Diff
./Services/Interrupts.c
- -3
- +3
./Services/Messaging.c
- History
- Source
- Diff
./Services/Messaging.c

1:52 pm

Raghu Kallala

More
LEAHI-DD-FIRMWARE-LDT-3514-1
finished reviewing

1:18 pm

Dara Navaei

More
e900731
changed 1 file
develop

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

- -1
- +1
./DDCommon.h
- History
- Source
- Diff
./DDCommon.h

1:13 pm

Michael Garthwaite

More
77d2a00
changed 1 file
LDT-2004-v2-conductivity-sensors, LDT-3218-update-iofp-permeate-target-flow and 8 more LEAHI-DD-FIRMWARE-LDT-3514-1

LDT-3514: wrapped ALARM_ID_FP_POWER_BUDGET_OUT_OF_RANGE around test config TEST_CONFIG_FP_DISABLE_RO_CURRENT_ALARM.

- -1
- +5
./Monitors/WaterQualityMonitor.c
- History
- Source
- Diff
./Monitors/WaterQualityMonitor.c

1:03 pm

Dara Navaei

More
LEAHI-DD-FIRMWARE-LDT-3514-1
started review

LEAHI-DD-FIRMWARE-LDT-3514_Dialin config request to disable IOFP current monitoring

LEAHI-DD-FIRMWARE-LDT-3514_Dialin config request to disable IOFP current monitoring

12:57 pm

Michael Garthwaite

More
333baf3
changed 2 files
LDT-2004-v2-conductivity-sensors LEAHI-DD-FIRMWARE-LDT-2004-4

LDT-2004: warning reductions for teensy driver

- -2
- +4
./Drivers/ConductivitySensors.h
- History
- Source
- Diff
./Drivers/ConductivitySensors.h
- -109
- +5
./Drivers/ConductivityTeensy.c
- History
- Source
- Diff
./Drivers/ConductivityTeensy.c

11:40 am

Michael Garthwaite

added

added

11:40 am

Michael Garthwaite

added

added

11:40 am

Michael Garthwaite

More
3b97a99
changed 1 file
LDT-3372-v1-conductivity-fixes LEAHI-DD-FIRMWARE-LDT-3372-2

LDT-3372: code review comments.

- -13
- +10
./Drivers/ConductivityTeensy.c
- History
- Source
- Diff
./Drivers/ConductivityTeensy.c

11:40 am

Michael Garthwaite

fixed.

fixed.

11:39 am

Michael Garthwaite

then we return false as expected

then we return false as expected

11:33 am

Michael Garthwaite

These are correct variable names based on their coefficient names in calculations of conductivity.

These are correct variable names based on their coefficient names in calculations of conductivity.

11:31 am

Michael Garthwaite

Can you clarify? this is allowing us to switch conductivity calculations based on the needs of the dialin user. ( systems team testing for accuracy )

Can you clarify? this is allowing us to switch conductivity calculations based on the needs of the dialin user. ( systems team testing for accuracy )

11:30 am

Michael Garthwaite

removed. thanks!

removed. thanks!

11:30 am

Michael Garthwaite

parameter check happens in getTeensyCondId

parameter check happens in getTeensyCondId

11:25 am

Michael Garthwaite

Yes as it is a way for us to identify if the teensy is not responding to us correctly. This along with no LED activity on the board helps us identify teensy failures

Yes as it is a way for us to identify if the teensy is not responding to us correctly. This along with no LED activity on the board helps us identify teensy failures

11:24 am

Michael Garthwaite

Not for this situation since its an array of structs and looks like a 2d array. Please see static const FP_OP_MODE_T MODE_TRANSITION_TABLE in FPOperationModes.c static const DD_OP_MODE_T MODE_TRAN...

Not for this situation since its an array of structs and looks like a 2d array. Please see

static const FP_OP_MODE_T MODE_TRANSITION_TABLE in FPOperationModes.c
static const DD_OP_MODE_T MODE_TRANSITION_TABLE in OperationModes.c
static PI_CONTROLLER_T piControllers in PIControllers.c ( FWCommon repo )

11:17 am

Dara Navaei

More
50951be
changed 1 file
develop

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

- -1
- +1
./DDCommon.h
- History
- Source
- Diff
./DDCommon.h

11:15 am

Michael Garthwaite

More
37e25a9
changed 1 file
LDT-3372-v1-conductivity-fixes, develop LEAHI-DD-FIRMWARE-LDT-3372-2

LDT-3372: fixes to conductivity calculation.

- -5
- +5
./Drivers/ConductivityTeensy.c
- History
- Source
- Diff
./Drivers/ConductivityTeensy.c

9:58 am

Dara Navaei

More
24efc54
changed 1 file
develop

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

- -1
- +1
./DDCommon.h
- History
- Source
- Diff
./DDCommon.h

Atlassian Fisheye Git analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2026-03-06 01:00 -0800