dd-firmware / firmware

App

Clone Tools

Stats

Commits this week: 48
Total Committers: 15
Last Commit: 14:29
Commits this week: 48

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 04 Mar
12:19 pm

Michael Garthwaite

WIP on LDT-2004-v2-conductivity-sensors

temp populated calibration values for beta2-5 bring up.

Options
    • -13
    • +15
    ./Drivers/ConductivitySensors.c
12:18 pm

Michael Garthwaite

Merge branch 'staging' into LDT-2004-v2-conductivity-sensors

Options
    • -5
    • +7
    ./Controllers/BalancingChamber.c
    • -2
    • +5
    ./Controllers/Heaters.c
    • -1
    • +1
    ./DDCommon.h
11:51 am

Michael Garthwaite

function removed. DD will now fault if we hit a failed state per execConductivityTeensy

function removed. DD will now fault if we hit a failed state per execConductivityTeensy

11:23 am

Michael Garthwaite

LDT-3372: removed functions per code review.

Options
    • -52
    • +0
    ./Drivers/ConductivityTeensy.c
10:43 am

Vendor - TEL - Sameer Poyil

10:35 am

Michael Garthwaite

how are unsigned integers negative?

how are unsigned integers negative?

10:15 am

Vinayakam Mani

10:15 am

Vinayakam Mani

9:55 am

Vendor - TEL - Jashwant Gantyada

potential fixes added for pressure profile

Options
    • -0
    • +6
    ./Controllers/BalancingChamber.c
    • -7
    • +56
    ./Modes/ModeGenDialysate.c
9:52 am

Vendor - TEL - Sameer Poyil

LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
9:38 am

Dara Navaei

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./DDCommon.h
9:38 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./Controllers/Heaters.c
9:24 am

Dara Navaei

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./DDCommon.h
9:23 am

Vinayakam Mani

LDT-3597 resolving merge issues

Options
    • -2
    • +2
    ./Controllers/BalancingChamber.c
    • -0
    • +1
    ./DDCommon.h
9:15 am

Vendor - TEL - Jashwant Gantyada and Vendor - TEL - Sameer Poyil

9:09 am

Sean Nash

9:02 am

Sean Nash

Use uppercase F

Use uppercase F

9:01 am

Sean Nash

Please declare local variables at top of scope (line 309 in this case).

Please declare local variables at top of scope (line 309 in this case).

7:53 am

Vendor - TEL - Sameer Poyil

The provided formula calculates electrolytic conductivity (k) by relating impedance measurements from a sensor to known calibration coefficients (B1,B2,B3) and an offset (B0). k: The calculated con...

The provided formula calculates electrolytic conductivity (k) by relating impedance measurements from a sensor to known calibration coefficients (B1,B2,B3) and an offset (B0).
k: The calculated conductivity.
impRz : The impedance of the solution, typically measured at a specific frequency (e.g., 100 kHz).
rtdRZ: The resistance of the Resistance Temperature Detector (RTD), used to perform temperature compensation.
B1,B2,B3, B0 : Empirical calibration coefficients specific to the sensor's geometry and electronic characteristics.

Linear Term (B3): Represents the primary relationship between conductance (1/impRZ) ) and conductivity. The factor of 1000 often scales the result into standard units like mS/cm or uS/cm

Temperature Compensation (B2 and B1): Since conductivity is highly temperature-dependent, these terms use rtdRZ
to adjust the calculation based on the actual temperature of the fluid. The logarithmic term (ln(rtdRz) accounts for non-linearities in the temperature response.

Offset (B0): Corrects for any residual signal or "zero-point" error in the measurement electronics.
.

7:43 am

Vendor - TEL - Sameer Poyil

at least mention what is the difference between the two apparoach?

at least mention what is the difference between the two apparoach?

7:42 am

Vendor - TEL - Sameer Poyil

There is no default case in that function switch ( sensorId ){ case P9_COND: sensorNum = TEENSY_SENSOR_0; break; case P18_COND: sensorNum = TEENSY_SENSOR_1; break; case D17_COND: sensorNum = TEENSY...

There is no default case in that function
switch ( sensorId )

Unknown macro: { case P9_COND}
7:38 am

Vendor - TEL - Sameer Poyil

typedef enum Conductivity_Models{ STANDARD, ///< standard equation for conductivity ALY_LINEAR, ///< Aly's high range model for conductivity UPDATED_STANDARD, ///< Updated stand equation with a lin...

typedef enum Conductivity_Models

Unknown macro: { STANDARD, ///< standard equation for conductivity ALY_LINEAR, ///< Aly's high range model for conductivity UPDATED_STANDARD, ///< Updated stand equation with a linear transformation. NUM_OF_MODELS, ///< Number of models used for conductivity calculation. }

COND_MODELS_T;

Its enumeration , if user send -1, -1 < NUM_OF_MODELS, this check passes

Tuesday 03 Mar
7:31 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-3597_(DD) D5 Heater not turning on on B2.0 HW
LEAHI-DD-FIRMWARE-LDT-3597_(DD) D5 Heater not turning on on B2.0 HW
7:25 pm

Vinayakam Mani

LDT-3597 heater update

Options
    • -0
    • +3
    ./Controllers/Heaters.c
4:56 pm

Sean Nash

Since this driver is temporary, I don't think we need to document the approaches.

Since this driver is temporary, I don't think we need to document the approaches.

4:53 pm

Sean Nash

Doesn't look like this switch statement is doing anything. Can we remove it?

Doesn't look like this switch statement is doing anything. Can we remove it?

4:50 pm

Sean Nash

The Teensy driver is temporary - we will be deleting this driver in a few months. Let's just look for problems that might affect proper functionality.

The Teensy driver is temporary - we will be deleting this driver in a few months. Let's just look for problems that might affect proper functionality.

4:00 pm

Vendor - TEL - Sameer Poyil

3:33 pm

Dara Navaei

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./DDCommon.h
3:32 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./Controllers/BalancingChamber.c
    • -1
    • +1
    ./Modes/ModeStandby.c