dd-firmware / firmware

App

Clone Tools

Stats

Commits this week: 43
Total Committers: 15
Last Commit: 10:45
Commits this week: 43

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 06 Mar
1:51 pm

Vendor - TEL - Jashwant Gantyada

LDT-3103 implemented new pump changes

Options
    • -2
    • +2
    ./Controllers/BalancingChamber.c
    • -2
    • +2
    ./Controllers/BalancingChamber.h
    • -27
    • +129
    ./Controllers/DialysatePumps.c
    • -13
    • +6
    ./Controllers/DialysatePumps.h
    • -8
    • +25
    ./Modes/ModeGenDialysate.c
1:33 pm

Michael Garthwaite

LDT-3218: fp tuning. WIP

Options
    • -4
    • +4
    ./Controllers/ROPump.c
12:47 pm

Raghu Kallala

Shall I add the SW_Fault as an else case if an invalid submode was requested for an opmode? Sean NashMichael Garthwaite please confirm

Shall I add the SW_Fault as an else case if an invalid submode was requested for an opmode?
Sean NashMichael Garthwaite please confirm

12:47 pm

Raghu Kallala

LDT-3603 converted all signal functions to void functions

Options
    • -6
    • +2
    ./Modes/FPModes/ModeGenPermeate.c
    • -1
    • +1
    ./Modes/FPModes/ModeGenPermeate.h
    • -6
    • +2
    ./Modes/FPModes/ModeGenPermeateDefeatured.c
    • -1
    • +1
    ./Modes/FPModes/ModeGenPermeateDefeatured.h
    • -10
    • +2
    ./Modes/FPModes/ModePreGenPermeate.c
    • -1
    • +1
    ./Modes/FPModes/ModePreGenPermeate.h
    • -6
    • +2
    ./Modes/FPModes/ModePreGenPermeateDefeatured.c
    • -1
    • +1
    ./Modes/FPModes/ModePreGenPermeateDefeatured.h
12:37 pm

Raghu Kallala

I was thinking we could return BOOL to check if the request was successful, added it. But as you clarified the dialin response will only confirm the delivery of message successfully, I can change ...

I was thinking we could return BOOL to check if the request was successful, added it.

But as you clarified the dialin response will only confirm the delivery of message successfully, I can change all these signal functions to void
Thanks!

12:31 pm

Dara Navaei

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./DDCommon.h
12:30 pm

Michael Garthwaite

WIP on develop

LDT-3372: fixed error on release builds

Options
    • -1
    • +1
    ./Monitors/Conductivity.c
12:18 pm

Dara Navaei

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./DDCommon.h
12:18 pm

Michael Garthwaite

Merge branch 'staging' into LDT-2004-v2-conductivity-sensors

Options
    • -1
    • +1
    ./DDCommon.h
12:16 pm

Michael Garthwaite

added

added

12:16 pm

Michael Garthwaite

removed check. the check now happens on before the get.

removed check. the check now happens on before the get.

12:16 pm

Michael Garthwaite

removed check. the check now happens on before the get.

removed check. the check now happens on before the get.

12:15 pm

Michael Garthwaite

fixed

fixed

12:15 pm

Michael Garthwaite

added. DD will now fault

added. DD will now fault

12:14 pm

Michael Garthwaite

fixed.

fixed.

12:14 pm

Michael Garthwaite

fixed

fixed

12:14 pm

Michael Garthwaite

updated.

updated.

12:14 pm

Michael Garthwaite

LDT-3372: code review comments.

Options
    • -22
    • +19
    ./Drivers/ConductivityTeensy.c
    • -18
    • +1
    ./Drivers/ConductivityTeensy.h
    • -6
    • +23
    ./Monitors/Conductivity.c
    • -3
    • +1
    ./Monitors/Conductivity.h
    • -3
    • +13
    ./Monitors/Temperature.c
10:55 am

Dara Navaei

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./DDCommon.h
9:58 am

Michael Garthwaite

Yes since you're not using the return value in execOpModes()

Yes since you're not using the return value in execOpModes()

7:48 am

Vendor - TEL - Sameer Poyil

LDT-2004 Dry bicart fixing merge issue

Options
    • -1
    • +0
    ./Services/Messaging.c
7:41 am

Raghu Kallala

LDT-3603 updated comment wording

Options
    • -1
    • +1
    ./Modes/FPModes/FPOperationModes.c
7:38 am

Raghu Kallala

LDT-3603 initial draft for FP set operation sub mode

Options
    • -0
    • +88
    ./Modes/FPModes/FPOperationModes.c
    • -0
    • +2
    ./Modes/FPModes/FPOperationModes.h
    • -0
    • +35
    ./Modes/FPModes/ModeGenPermeate.c
    • -1
    • +1
    ./Modes/FPModes/ModeGenPermeate.h
    • -0
    • +37
    ./Modes/FPModes/ModeGenPermeateDefeatured.c
    • -1
    • +1
    ./Modes/FPModes/ModeGenPermeateDefeatured.h
    • -0
    • +62
    ./Modes/FPModes/ModePreGenPermeate.c
    • -7
    • +8
    ./Modes/FPModes/ModePreGenPermeate.h
    • -0
    • +41
    ./Modes/FPModes/ModePreGenPermeateDefeatured.c
    • -1
    • +1
    ./Modes/FPModes/ModePreGenPermeateDefeatured.h
    • -0
    • +1
    ./Services/Messaging.c
5:36 am

Vendor - TEL - Sameer Poyil

LDT-2004 Dry bicart fixing merge issue

Options
    • -5
    • +6
    ./Services/Messaging.c
Thursday 05 Mar
7:52 pm

Vendor - TEL - Sameer Poyil

All comments should start with capital letter

All comments should start with capital letter

7:37 pm

Vendor - TEL - Sameer Poyil

comment alignment issue

comment alignment issue

7:37 pm

Vendor - TEL - Sameer Poyil

it should be mentioned what function is used for calculating the equation.

it should be mentioned what function is used for calculating the equation.

7:30 pm

Vendor - TEL - Sameer Poyil

above comment applicable here .

above comment applicable here .

7:29 pm

Vendor - TEL - Sameer Poyil

if sensor id is not in the finite state enum value , it return 0 and here it calculate for P9

if sensor id is not in the finite state enum value , it return 0 and here it calculate for P9

7:21 pm

Vendor - TEL - Sameer Poyil

parameter is sensorId, not sensor

parameter is sensorId, not sensor