dd-firmware / firmware

App

Clone Tools

Stats

Commits this week: 43
Total Committers: 15
Last Commit: 10:45
Commits this week: 43

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 06 Mar
2:22 pm

Michael Garthwaite

LDT-3372: code review comments

Options
    • -1
    • +1
    ./Monitors/Conductivity.c
2:21 pm

Michael Garthwaite

J1 - P9 J2 - P18 J3 - D17 J4 - D27 J5 - D29 J6 - D43 No sensor - D74 (redundant, so we should be able to live without it in short run)

J1 - P9
J2 - P18
J3 - D17
J4 - D27
J5 - D29
J6 - D43
No sensor - D74 (redundant, so we should be able to live without it in short run)

2:20 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

2:20 pm

Michael Garthwaite

build switch fixes will be completed in the v2 conductivity sensor branch. Per what was agreed on back in November: J1 - P9 J2 - P18 J3 - D17 J4 - D27 J5 - D29 J6 - D43 No sensor - D74 (redundant,...

build switch fixes will be completed in the v2 conductivity sensor branch. Per what was agreed on back in November:

J1 - P9
J2 - P18
J3 - D17
J4 - D27
J5 - D29
J6 - D43
No sensor - D74 (redundant, so we should be able to live without it in short run)

2:20 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

2:18 pm

Michael Garthwaite

LDT-3372: code review comments

Options
    • -1
    • +0
    ./Monitors/Conductivity.h
2:18 pm

Sean Nash

Remove blank line.

Remove blank line.

2:17 pm

Sean Nash

Remove blank line.

Remove blank line.

2:17 pm

Sean Nash

Add blank line after declarations.

Add blank line after declarations.

2:17 pm

Sean Nash

Same question.

Same question.

2:16 pm

Sean Nash

Why is D74 not a Teensy? And I though you were getting ride of this build switch and using test config (run time switch)?

Why is D74 not a Teensy? And I though you were getting ride of this build switch and using test config (run time switch)?

2:14 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

2:13 pm

Vendor - TEL - Jashwant Gantyada

LDT-3103 merget latest staging

Options
    • -2
    • +2
    ./Controllers/BalancingChamber.c
    • -1
    • +1
    ./Controllers/BalancingChamber.h
    • -2
    • +3
    ./Controllers/DialysatePumps.h
    • -7
    • +8
    ./DDCommon.h
    • -26
    • +78
    ./Modes/ModeGenDialysate.c
    • -2
    • +3
    ./Modes/ModeGenDialysate.h
1:51 pm

Vendor - TEL - Jashwant Gantyada

LDT-3103 implemented new pump changes

Options
    • -2
    • +2
    ./Controllers/BalancingChamber.c
    • -2
    • +2
    ./Controllers/BalancingChamber.h
    • -27
    • +129
    ./Controllers/DialysatePumps.c
    • -13
    • +6
    ./Controllers/DialysatePumps.h
    • -8
    • +25
    ./Modes/ModeGenDialysate.c
1:33 pm

Michael Garthwaite

LDT-3218: fp tuning. WIP

Options
    • -4
    • +4
    ./Controllers/ROPump.c
12:47 pm

Raghu Kallala

Shall I add the SW_Fault as an else case if an invalid submode was requested for an opmode? Sean NashMichael Garthwaite please confirm

Shall I add the SW_Fault as an else case if an invalid submode was requested for an opmode?
Sean NashMichael Garthwaite please confirm

12:47 pm

Raghu Kallala

LDT-3603 converted all signal functions to void functions

Options
    • -6
    • +2
    ./Modes/FPModes/ModeGenPermeate.c
    • -1
    • +1
    ./Modes/FPModes/ModeGenPermeate.h
    • -6
    • +2
    ./Modes/FPModes/ModeGenPermeateDefeatured.c
    • -1
    • +1
    ./Modes/FPModes/ModeGenPermeateDefeatured.h
    • -10
    • +2
    ./Modes/FPModes/ModePreGenPermeate.c
    • -1
    • +1
    ./Modes/FPModes/ModePreGenPermeate.h
    • -6
    • +2
    ./Modes/FPModes/ModePreGenPermeateDefeatured.c
    • -1
    • +1
    ./Modes/FPModes/ModePreGenPermeateDefeatured.h
12:37 pm

Raghu Kallala

I was thinking we could return BOOL to check if the request was successful, added it. But as you clarified the dialin response will only confirm the delivery of message successfully, I can change ...

I was thinking we could return BOOL to check if the request was successful, added it.

But as you clarified the dialin response will only confirm the delivery of message successfully, I can change all these signal functions to void
Thanks!

12:31 pm

Dara Navaei

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./DDCommon.h
12:30 pm

Michael Garthwaite

WIP on develop

LDT-3372: fixed error on release builds

Options
    • -1
    • +1
    ./Monitors/Conductivity.c
12:18 pm

Dara Navaei

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./DDCommon.h
12:18 pm

Michael Garthwaite

Merge branch 'staging' into LDT-2004-v2-conductivity-sensors

Options
    • -1
    • +1
    ./DDCommon.h
12:16 pm

Michael Garthwaite

added

added

12:16 pm

Michael Garthwaite

removed check. the check now happens on before the get.

removed check. the check now happens on before the get.

12:16 pm

Michael Garthwaite

removed check. the check now happens on before the get.

removed check. the check now happens on before the get.

12:15 pm

Michael Garthwaite

fixed

fixed

12:15 pm

Michael Garthwaite

added. DD will now fault

added. DD will now fault

12:14 pm

Michael Garthwaite

fixed.

fixed.

12:14 pm

Michael Garthwaite

fixed

fixed

12:14 pm

Michael Garthwaite

updated.

updated.