dd-firmware / firmware

App

Clone Tools

Stats

Commits this week: 35
Total Committers: 16
Last Commit: 11:49
Commits this week: 35

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 03 Apr
4:20 pm

Dara Navaei

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./DDCommon.h
4:19 pm

Vinayakam Mani

LDT-3352 resolving merge conflicts

Options
    • -5
    • +216
    ./Controllers/Heaters.c
    • -246
    • +14
    ./Modes/ModeGenDialysate.c
    • -129
    • +86
    ./Monitors/Temperature.c
    • -1
    • +3
    ./Monitors/Temperature.h
    • -0
    • +1
    ./Services/Messaging.c
3:58 pm

Vinayakam Mani

LDT-3352 heater control update

Options
    • -4
    • +6
    ./Controllers/Heaters.c
    • -4
    • +4
    ./Monitors/Temperature.c
3:35 pm

Vinayakam Mani

Done.

Done.

3:34 pm

Vinayakam Mani

Done

Done

3:34 pm

Vinayakam Mani

Done.

Done.

3:17 pm

Vinayakam Mani

LDT-3522 updating heater control

Options
    • -1
    • +210
    ./Controllers/Heaters.c
    • -0
    • +1
    ./Controllers/Heaters.h
    • -246
    • +14
    ./Modes/ModeGenDialysate.c
    • -1
    • +1
    ./Modes/ModeGenDialysate.h
    • -126
    • +82
    ./Monitors/Temperature.c
    • -1
    • +3
    ./Monitors/Temperature.h
    • -0
    • +1
    ./Services/Messaging.c
1:20 pm

Sean Nash

Same comment.

Same comment.

1:19 pm

Sean Nash

Having much larger P coeff is likely to cause a lot of oscillations and very slow to get to stable target.

Having much larger P coeff is likely to cause a lot of oscillations and very slow to get to stable target.

1:14 pm

Sean Nash

Input is d78TempAvgC

Input is d78TempAvgC

1:13 pm

Sean Nash

I don't think these min/max (for control output in output units i.e. PWM) are appropriate for limiting maximum error sum step size (error is in feedback/target units i.e. RPM).

I don't think these min/max (for control output in output units i.e. PWM) are appropriate for limiting maximum error sum step size (error is in feedback/target units i.e. RPM).

9:33 am

Dara Navaei

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./DDCommon.h
9:32 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./Controllers/RinsePump.c
    • -1
    • +1
    ./Controllers/RinsePump.h
    • -2
    • +2
    ./Controllers/Valves.c
    • -2
    • +2
    ./Controllers/Valves.h
    • -2
    • +2
    ./Modes/OperationModes.c
    • -2
    • +2
    ./Modes/OperationModes.h
9:31 am

Vendor - TEL - Jashwant Gantyada

9:27 am

Dara Navaei

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./DDCommon.h
9:26 am

Vendor - TEL - Jashwant Gantyada

Merge branch 'LDT-3627-fp-dd-valves-the-valves-sensed-' into develop

Options
    • -0
    • +1
    ./Controllers/RinsePump.c
    • -0
    • +31
    ./Controllers/Valves.c
    • -2
    • +2
    ./Controllers/Valves.h
8:32 am

Sean Nash

Thursday 02 Apr
3:43 pm

Vinayakam Mani

Done.

Done.

3:43 pm

Vinayakam Mani

Just following the current style of code implementation to keep it uniform. These defines are temporary and will be removed.

Just following the current style of code implementation to keep it uniform. These defines are temporary and will be removed.

3:40 pm

Vinayakam Mani

Done.

Done.

3:39 pm

Vinayakam Mani

Done.

Done.

3:39 pm

Vinayakam Mani

Done.

Done.

3:35 pm

Vinayakam Mani

3:28 pm

Vinayakam Mani

Done.

Done.

3:28 pm

Vinayakam Mani

Done.

Done.

3:27 pm

Vinayakam Mani

Done.

Done.

3:27 pm

Vinayakam Mani

Done.

Done.

3:24 pm

Vinayakam Mani

LDT-1477 addressing code review comments

Options
    • -2
    • +2
    ./Controllers/BalancingChamber.c
    • -1
    • +1
    ./Controllers/Ultrafiltration.c
    • -2
    • +2
    ./Modes/ModeGenDialysate.c
2:50 pm

Vendor - TEL - Jashwant Gantyada

LDT-3627 resolved implicit declaration for rinse pump function

Options
    • -0
    • +1
    ./Controllers/RinsePump.c
    • -1
    • +0
    ./Controllers/RinsePump.h
10:35 am

Vinayakam Mani