Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
LDT-3978-addressed review comments

LDT-3963 enabled fault mode tranisiton for switching off hetares for dilaysate flow rate testing

    • -16
    • +21
    ./Controllers/BalancingChamber.c
remove space after <= and add space end of function call.

remove space after <= and add space end of function call.

Is this time out after D80 opening or D65 closing state? if it is D65 closed, you need to start the timer after D65 closing.

Is this time out after D80 opening or D65 closing state? if it is D65 closed, you need to start the timer after D65 closing.

if we are not checking level, this can be removed and function name also can be updated accordingly.

if we are not checking level, this can be removed and function name also can be updated accordingly.

Is this a TODO? If so, add TODO to the comment and maybe be a little more descriptive of what needs to be done.

Is this a TODO? If so, add TODO to the comment and maybe be a little more descriptive of what needs to be done.

can we get 'runPIController' inside deadband control check?

can we get 'runPIController' inside deadband control check?

Can we add sodium and bicarb overrides now, so that we don't want to come back again for this change? Also, please get the dialin updated to reflect the new parameters additions in tdproxy and let ...

Can we add sodium and bicarb overrides now, so that we don't want to come back again for this change?
Also, please get the dialin updated to reflect the new parameters additions in tdproxy and let system team be in loop to update the required system scripts?

LDT-3978 adreesing review comments

LDT-3978 fixing compilation warning

LDT-3978 addressing review comments

LDT-3978 fixing compilation error

LDT-4188 updated set pre-gen and gen dialysate function calls

LDT-3978 fix for compilation error

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Merge branch LDT-3980-dialysate-composition-dry-bicarb---fw-impl into develop

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Merge branch LDT-3980-dialysate-composition-dry-bicarb---fw-impl into staging

LDT-3980 addressed review comments

Initialize the 'dryBicartPersistantStartTime' back to zero after timeout done, for the next iterations.

Initialize the 'dryBicartPersistantStartTime' back to zero after timeout done, for the next iterations.

LDT-3980 addressed review comments

Nope. Since we are here after level is LOW (fill request from balancing chamber control state machine) and not filled yet. So level is still LOW

Nope. Since we are here after level is LOW (fill request from balancing chamber control state machine) and not filled yet. So level is still LOW

LDT-3978 firmware implementation for ocean spray

First two logics ANDed correct (first cycle and close period). the third one (BC switch only must be ANDed only with close period), not to include first cycle..

First two logics ANDed correct (first cycle and close period). the third one (BC switch only must be ANDed only with close period), not to include first cycle..

LDT-3975 WIP initial draft for boost pump refactor

    • -3
    • +3
    ./Modes/FPModes/StateFlushConcentrate.c
    • -1
    • +1
    ./Modes/FPModes/StateInletPressureCheck.c