dd-firmware / firmware

App

Clone Tools

Stats

Commits this week: 20
Total Committers: 17
Last Commit: 12:10
Commits this week: 20

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 22 May
11:09 am

Dara Navaei

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./DDCommon.h
11:08 am

Vendor - TEL - Jashwant Gantyada

resolved merge conflicts and merged LDT-3963

Options
    • -40
    • +19
    ./Controllers/BalancingChamber.c
    • -2
    • +2
    ./Controllers/ConcentratePumps.c
    • -2
    • +2
    ./Controllers/RinsePump.c
    • -8
    • +8
    ./DDCommon.h
    • -4
    • +4
    ./Drivers/ConductivitySensors.c
    • -2
    • +2
    ./Modes/FPModes/ModePreGenPermeate.c
    • -0
    • +1
    ./Monitors/Level.c
    • -1
    • +1
    ./Monitors/Temperature.c
10:50 am

Sean Nash and Vinayakam Mani

9:05 am

Vendor - TEL - Jashwant Gantyada

Merge branch 'staging' into feature/LDT-3963-dialysate-flow-rate---fw-implem

Options
    • -15
    • +24
    ./Controllers/RinsePump.c
    • -1
    • +1
    ./DDCommon.h
8:00 am

Vendor - TEL - Sameer Poyil

LDT-4183-dry bicart firmeware implementation2/1: addressing review comments

Options
    • -1
    • +0
    ./Controllers/DryBiCart.c
7:51 am

Vinayakam Mani

7:49 am

Vendor - TEL - Sameer Poyil

LDT-4183-dry bicart firmeware implementation2/1: for dialysis calculator

Options
    • -18
    • +81
    ./Controllers/DryBiCart.c
Thursday 21 May
8:51 pm

Dara Navaei

Merge branch 'staging' into LDT-3272-software-update---dd-firmware

Options
    • -0
    • +16
    ./Services/SystemCommDD.h
3:36 pm

Vendor - TEL - Jashwant Gantyada

LDT-3963 addressed code review comments

Options
    • -4
    • +4
    ./Drivers/ConductivitySensors.c
    • -1
    • +1
    ./Services/SystemCommDD.c
3:24 pm

Vendor - TEL - Jashwant Gantyada

restored

restored

3:24 pm

Sean Nash

Not sure why Crucible is showing it this way. Let's just re-review these diffs.

Not sure why Crucible is showing it this way. Let's just re-review these diffs.

3:18 pm

Sean Nash

Should be #ifndef

Should be #ifndef

3:13 pm

Sean Nash

Should be #ifndef I think.

Should be #ifndef I think.

3:06 pm

Sean Nash

Can we make these low priority and 999 rank?

Can we make these low priority and 999 rank?

1:32 pm

Vendor - TEL - Jashwant Gantyada

LDT-3963 addressed code review comments and restored the fault mode transition

Options
    • -40
    • +19
    ./Controllers/BalancingChamber.c
    • -2
    • +1
    ./Controllers/BalancingChamber.h
    • -2
    • +2
    ./Controllers/ConcentratePumps.c
    • -8
    • +8
    ./DDCommon.h
    • -3
    • +1
    ./Drivers/BloodLeakDriver.c
    • -4
    • +4
    ./Drivers/ConductivitySensors.c
    • -0
    • +1
    ./Monitors/Level.c
    • -1
    • +1
    ./Monitors/Temperature.c
    • -1
    • +1
    ./Services/AlarmMgmtDD.c
    • -2
    • +2
    ./Services/SystemCommDD.c
Wednesday 20 May
2:30 pm

Raghu Kallala

10:44 am

Michael Garthwaite

Merge branch 'staging' into LDT-4000-hdf-fw-implementation-1

Options
    • -20
    • +24
    ./Controllers/RinsePump.c
    • -2
    • +2
    ./Monitors/Level.c
10:43 am

Michael Garthwaite

Merge branch 'staging' into LDT-3975-Boost-Pump

Options
    • -2
    • +2
    ./Modes/FPModes/ModeGenPermeate.c
    • -3
    • +3
    ./Modes/FPModes/ModePreGenPermeate.c
10:39 am

Dara Navaei

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./DDCommon.h
10:39 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./Controllers/RinsePump.c
    • -1
    • +1
    ./Modes/FPModes/FPOperationModes.c
    • -1
    • +1
    ./Modes/FPModes/ModeGenPermeate.c
    • -2
    • +2
    ./Modes/FPModes/ModeGenPermeateDefeatured.c
    • -2
    • +2
    ./Modes/FPModes/ModePreGenPermeate.c
    • -1
    • +1
    ./Modes/FPModes/ModePreGenPermeateDefeatured.c
Tuesday 19 May
5:50 pm

Vinayakam Mani and Sean Nash

3:06 pm

Dara Navaei

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./DDCommon.h
3:05 pm

Raghu Kallala

resolved merge conflict for LDT-4413 into develop in handleRinsePumpOffState

Options
    • -13
    • +22
    ./Controllers/RinsePump.c
    • -1
    • +1
    ./Modes/FPModes/ModePreGenPermeate.c
2:19 pm

Raghu Kallala

Fixed broadcast issue for rinse pump PWM

Options
    • -6
    • +10
    ./Controllers/RinsePump.c
Monday 18 May
2:59 pm

Raghu Kallala

LDT-4414 added fix to update the pwm value in broadcast and changed setpwm from count to percentage

Options
    • -10
    • +15
    ./Controllers/RinsePump.c
Sunday 17 May
11:34 pm

Sean Nash

It is weird that we're responding so far from request. It is not clear to me that Dialin has requested anything at this point.

It is weird that we're responding so far from request. It is not clear to me that Dialin has requested anything at this point.

11:26 pm

Sean Nash

Details looks weird. Where is inputs and outputs like other function headers?

Details looks weird. Where is inputs and outputs like other function headers?

11:19 pm

Sean Nash

Add a blank line after banner.

Add a blank line after banner.

11:19 pm

Sean Nash

Please restore before you merge to staging.

Please restore before you merge to staging.

11:16 pm

Sean Nash

If I'm reading this right, we're saying that if bad CRC alarm is NOT enabled, initialize the alarm? That seems backward.

If I'm reading this right, we're saying that if bad CRC alarm is NOT enabled, initialize the alarm? That seems backward.