Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Merged staging

LEAHI-DD-FIRMWARE-LDT-4022_Disinfection (DD heat, heat+descale) - FW Implementation - 1/4:
LEAHI-DD-FIRMWARE-LDT-4022_Disinfection (DD heat, heat+descale) - FW Implementation - 1/4:
The current implementation and OR and AND logic is a problem , We need a better logic here. for the time being OR is better so that it won't suck up till pressure drops to 4PSI

The current implementation and OR and AND logic is a problem , We need a better logic here. for the time being OR is better so that it won't suck up till pressure drops to 4PSI

removed

removed

updated

updated

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

LDT-5409 force commit for develop

updated

updated

updated

updated

removed

removed

Merge branch 'staging' into LDT-5209-pre-treatment

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Merge branch 'LDT-5409-dd-balancing-chamber-stops-duri' into develop

LDT-5409 code changes and added debug variables

    • -35
    • +57
    ./Controllers/BalancingChamber.c
Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Merge branch 'LDT-3975-water-treatment-and-degassing--' into develop

LDT-3975: fixed temp compensation only choosing high bounds alpha

LDT-4049: Added msg hanlers

Are we done testing? Can we remote test variables and code?

Are we done testing? Can we remote test variables and code?

Remove Sequence step states if not being used.

Remove Sequence step states if not being used.

Update comments ( remove start/end states)

Update comments ( remove start/end states)

Update TD to DD.

Update TD to DD.

Update alarm properties (DD fault, Priority eti,.)

Update alarm properties (DD fault, Priority eti,.)

Remove the empty line.

Remove the empty line.

Or User cancels drain request: To cancel the ongoing drain process. Could you please add the condition as well?

Or User cancels drain request: To cancel the ongoing drain process. Could you please add the condition as well?

Remove commented code.

Remove commented code.

Remove D34 valve close.

Remove D34 valve close.

Add a TODO comment that D83 will be updated to new valve once new valve driver added.

Add a TODO comment that D83 will be updated to new valve once new valve driver added.

void inside paranthesis.

void inside paranthesis.

You can remove the above condition and do the rest of code, except D65 valve opening. Initially this state was waiting for balancing chamber fill to be completed and open D65 valve later. Now that ...

You can remove the above condition and do the rest of code, except D65 valve opening. Initially this state was waiting for balancing chamber fill to be completed and open D65 valve later. Now that this function will check the condition and skip the valves actions if not met. this is not the expected behavior.