dd-firmware

firmware

Clone Tools

Stats

Commits this week: 54
Total Committers: 16
Last Commit: 08:45
Commits this week: 54

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 13 Mar
10:53 am

Vendor - TEL - Jashwant Gantyada

LDT-3103 updated fill timeout alarm logic and handling

Options
    • -12
    • +3
    ./App/Controllers/BalancingChamber.c
10:53 am

Vendor - TEL - Jashwant Gantyada

LDT-3103 updated fill timeout alarm logic and handling

Options
    • -12
    • +3
    ./App/Controllers/BalancingChamber.c
9:38 am

Vendor - TEL - Arpita Srivastava

LDT-1195: Updated function comments and requestBalChamberSwitching

Options
    • -4
    • +12
    ./App/Controllers/BalancingChamber.c
    • -2
    • +0
    ./App/Modes/ModeGenDialysate.c
9:33 am

Sean Nash

Remove extra blank line.

Remove extra blank line.

9:31 am

Sean Nash

Should we create a structure for these moving average filters and make an array of them based on enum of temp sensors? It looks kind of messy having separate handling for each sensor - can we conso...

Should we create a structure for these moving average filters and make an array of them based on enum of temp sensors?
It looks kind of messy having separate handling for each sensor - can we consolidate some of this code?

9:28 am

Sean Nash

Should we maybe just have a constant array of sample counts based on enum of temp sensors?

Should we maybe just have a constant array of sample counts based on enum of temp sensors?

9:24 am

Sean Nash

Should min and max be properties of the controller instead of global (assumes all controllers will want same min/max)? Controller properties already include a min and max field - can we use those?

Should min and max be properties of the controller instead of global (assumes all controllers will want same min/max)?
Controller properties already include a min and max field - can we use those?

9:16 am

Sean Nash

Remove blank line.

Remove blank line.

Thursday 12 Mar
10:01 pm

Vendor - TEL - Praneeth Bunne

9:59 pm

Vendor - TEL - Jashwant Gantyada

changed

changed

9:59 pm

Vendor - TEL - Jashwant Gantyada

removed from everywhere

removed from everywhere

9:58 pm

Vendor - TEL - Jashwant Gantyada

removed

removed

9:58 pm

Vendor - TEL - Jashwant Gantyada

LDY-3103 addressed code review comments

Options
    • -20
    • +1
    ./App/Controllers/BalancingChamber.c
9:58 pm

Vendor - TEL - Jashwant Gantyada

LDY-3103 addressed code review comments

Options
    • -20
    • +1
    ./App/Controllers/BalancingChamber.c
7:25 pm

Dara Navaei

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./App/DDCommon.h
7:25 pm

Dara Navaei

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./App/DDCommon.h
7:25 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./App/Modes/ModeGenDialysate.c
    • -2
    • +2
    ./App/Modes/ModeGenDialysate.h
7:25 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./App/Modes/ModeGenDialysate.c
    • -2
    • +2
    ./App/Modes/ModeGenDialysate.h
6:14 pm

Vinayakam Mani

Result is a BOOL variable, use FALSE.

Result is a BOOL variable, use FALSE.

5:24 pm

Vendor - TEL - Jashwant Gantyada

updated.

updated.

5:24 pm

Vendor - TEL - Jashwant Gantyada

done.

done.

5:24 pm

Vendor - TEL - Jashwant Gantyada

done

done

5:24 pm

Vendor - TEL - Jashwant Gantyada

changed accordingly.

changed accordingly.

5:23 pm

Vendor - TEL - Jashwant Gantyada

LDT-3103 addressed code review comments

Options
    • -8
    • +21
    ./App/Controllers/BalancingChamber.c
    • -2
    • +2
    ./App/Modes/ModeGenDialysate.c
5:23 pm

Vendor - TEL - Jashwant Gantyada

LDT-3103 addressed code review comments

Options
    • -6
    • +19
    ./App/Controllers/BalancingChamber.c
    • -2
    • +2
    ./App/Modes/ModeGenDialysate.c
5:18 pm

Vinayakam Mani and Sean Nash

5:12 pm

Vendor - TEL - Praneeth Bunne

Fix getFreshDialPumpInitialRpm function name and brief inputs comment

Options
    • -9
    • +9
    ./App/Modes/ModeGenDialysate.c
5:12 pm

Vendor - TEL - Praneeth Bunne

LDT-3750 cherry-picked ca27c61

Options
    • -9
    • +9
    ./App/Modes/ModeGenDialysate.c
4:53 pm

Sean Nash

I think the 2 initial rpm constants are inputs. The test config we would normally not include.

I think the 2 initial rpm constants are inputs. The test config we would normally not include.

4:52 pm

Sean Nash

I think the word "Initial" should be in the function name (i.e. getFreshDialPumpInitialRpm).

I think the word "Initial" should be in the function name (i.e. getFreshDialPumpInitialRpm).