firmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Merge branch 'staging' into LDT-3777-sprint-25-fixes

LDT-2008: code review comments.

per formatting for the test support function header. it is format used across many files

per formatting for the test support function header. it is format used across many files

fixed

fixed

fixed

fixed

fixed

fixed

fixed

fixed

fixed

fixed

fixed

fixed

fixed

fixed

fixed

fixed

Merge branch 'staging' into LDT-2008-v2-conductivity-sensors-CLEAN

LDT-2008: code review comments

    • -10
    • +10
    ./App/Drivers/ConductivitySensors.h
    • -10
    • +10
    ./App/Drivers/ConductivityTeensy.h
both drivers need to be initialized since we dont know what Beta unit we are running until the FW receives test configuration(s).

both drivers need to be initialized since we dont know what Beta unit we are running until the FW receives test configuration(s).

LDT-3735: Updated logic to send record to dialin

Dry bicart closed loop

    • -331
    • +457
    ./App/Controllers/DryBiCart.c
Yes, this needs to be corrected. I don't see any controller existing properties defining these min and max. Will discuss further with you on this.

Yes, this needs to be corrected. I don't see any controller existing properties defining these min and max. Will discuss further with you on this.

Since feedforward output is same as control signal output, checking control signal min and max seems to be correct.

Since feedforward output is same as control signal output, checking control signal min and max seems to be correct.

Reduced gain and testing in progress.

Reduced gain and testing in progress.

Reduced gain and testing in progress.

Reduced gain and testing in progress.

Done.

Done.

Done.

Done.

LDT-3352 code review comments update

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces