leahi-common

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
LDT-2749 addressed code review comments

done

done

LDT-1415-pressures-monitoring-td

Not an override command. We want to update bubbleDetectionEnabled[] for the venous sensor (index 0) to the given T/F state.

Not an override command. We want to update bubbleDetectionEnabled[] for the venous sensor (index 0) to the given T/F state.

MSG_ID_TD_ENABLE_VENOUS_BUBBLE_ALARM

MSG_ID_TD_ENABLE_VENOUS_BUBBLE_ALARM

Check msg payload length, set result to TRUE and set enable only if length is correct.

Check msg payload length, set result to TRUE and set enable only if length is correct.

LDT-2749 added msg id for bubble enable

Update function name to match actual name. Remove references to standby mode - function should work in any mode.

Update function name to match actual name. Remove references to standby mode - function should work in any mode.

LDT-1415-pressures-monitoring-td

Not needed. Remove.

Not needed. Remove.

This is not necessary - bubbleDetectionEnabled[] above takes care of this. Remove.

This is not necessary - bubbleDetectionEnabled[] above takes care of this. Remove.

MSG_ID_TD_ENABLE_VENOUS_BUBBLE_ALARM?

MSG_ID_TD_ENABLE_VENOUS_BUBBLE_ALARM?

testEnableVenousBubbleAlarm?

testEnableVenousBubbleAlarm?

LEAHI-TD-FIRMWARE-LDT-2749_Ability to Enable Air Bubble Alarm in Standby Mode
LEAHI-TD-FIRMWARE-LDT-2749_Ability to Enable Air Bubble Alarm in Standby Mode
Merge branch 'staging' into LDT-2004-dialysate-composition-dd

Merge branch 'staging' into LDT-2004-dialysate-composition-dd

You added them, but you're not really using them and you're not using the tmp override either as far as I can see. Do we need any of these?

You added them, but you're not really using them and you're not using the tmp override either as far as I can see. Do we need any of these?

I don't see it.

I don't see it.

Fix spelling in comment (membrane should not have a 'c' in it).

Fix spelling in comment (membrane should not have a 'c' in it).

Missing param.

Missing param.

This function does not return next state.

This function does not return next state.

I would say inputs and outputs are "none".

I would say inputs and outputs are "none".

Align function name with others (1 more space before name).

Align function name with others (1 more space before name).

TMP low and high pressure alarms should be here I think.

TMP low and high pressure alarms should be here I think.

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Once I get latest staging I will update this

Once I get latest staging I will update this

Updated

Updated

Fixed

Fixed

Yes, deleted

Yes, deleted