leahi-common

Clone Tools

Stats

Commits this week: 19
Total Committers: 16
Last Commit: 10:38
Commits this week: 19

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 23 Feb
1:18 pm

Vendor - TEL - Jashwant Gantyada

LEAHI-DD-FIRMWARE-LDT-3344_Firmware support for Beta 2 FPGA updates.
LEAHI-DD-FIRMWARE-LDT-3344_Firmware support for Beta 2 FPGA updates.
1:04 pm

Sean Nash

Add spaces inside of ().

Add spaces inside of ().

1:03 pm

Sean Nash

Stop button is a "hard" pause which would take us to Treatment: Paused state (out of blood prime completely). We want to go to our internal paused state when UI sends us a "soft" blood prime pause ...

Stop button is a "hard" pause which would take us to Treatment: Paused state (out of blood prime completely).
We want to go to our internal paused state when UI sends us a "soft" blood prime pause commands message.

1:01 pm

Sean Nash

Remove blank line.

Remove blank line.

1:00 pm

Sean Nash

Should we add this test config? Systems team will likely want it eventually since they wanted it in Denali.

Should we add this test config? Systems team will likely want it eventually since they wanted it in Denali.

12:56 pm

Sean Nash

Put each condition in (). Also, should the setAirPumpState function be checking power is in range instead of here?

Put each condition in ().
Also, should the setAirPumpState function be checking power is in range instead of here?

12:53 pm

Sean Nash

You have these MIN/MAX definitions in both this unit and AirPump unit. Can we put these in header file for this unit and remove from AirPump unit?

You have these MIN/MAX definitions in both this unit and AirPump unit. Can we put these in header file for this unit and remove from AirPump unit?

12:52 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

12:50 pm

Vendor - TEL - Varshini Nagabooshanam

Removed

Removed

12:50 pm

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

12:50 pm

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

12:50 pm

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

12:50 pm

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

12:49 pm

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

12:49 pm

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

12:49 pm

Vendor - TEL - Varshini Nagabooshanam

I will Update as per Raghu treatment parameter

I will Update as per Raghu treatment parameter

12:47 pm

Sean Nash

This looks like develop branch got merged into your branch. We should not be doing that. Always merge your branch to develop in that direction only.

This looks like develop branch got merged into your branch. We should not be doing that. Always merge your branch to develop in that direction only.

Saturday 21 Feb
7:10 pm

Vendor - TEL - Sameer Poyil

capital F

capital F

Friday 20 Feb
3:01 pm

Vendor - TEL - Jashwant Gantyada

2:19 pm

Vendor - TEL - Sameer Poyil

This is total mess up . that is what I want it a clean implementation. created a ticket LDT-3563 and closing all review comments.

This is total mess up . that is what I want it a clean implementation. created a ticket LDT-3563 and closing all review comments.

2:17 pm

Vendor - TEL - Sameer Poyil

Removing all the review comments and created a ticket to handle it in separate ticket -LDT-3563

Removing all the review comments and created a ticket to handle it in separate ticket -LDT-3563

1:48 pm

Sean Nash

1:42 pm

Vendor - TEL - Jashwant Gantyada

removed.

removed.

1:42 pm

Raghu Kallala

Updated

Updated

1:42 pm

Vendor - TEL - Jashwant Gantyada

changed.

changed.

1:41 pm

Vendor - TEL - Jashwant Gantyada

removed.

removed.

1:36 pm

Raghu Kallala

Updated

Updated

1:35 pm

Sean Nash

I think this function should be in ModeTreatment or Messaging.

I think this function should be in ModeTreatment or Messaging.

1:34 pm

Sean Nash

update params in header.

update params in header.

1:34 pm

Raghu Kallala

you are right, I missed it here. Fixed.

you are right, I missed it here.
Fixed.