leahi-common

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
LDT-1903 Adding Air pump duty cycle out of range alarm

Actually, I think we should have the local variable to copy the payload into, then we should range check it (and potentially reject it if out of range), and if it is in range, only then should we a...

Actually, I think we should have the local variable to copy the payload into, then we should range check it (and potentially reject it if out of range), and if it is in range, only then should we assign new rate to your static variable.

I think this can just be an else since resume is the only remaining possibility.

I think this can just be an else since resume is the only remaining possibility.

Should we set resume state here? I know it's initialized to ramp state already, but in case we come back to ramp it may be safer to set it here.

Should we set resume state here? I know it's initialized to ramp state already, but in case we come back to ramp it may be safer to set it here.

You moved it, but didn't change anything. The comment says it's a timer counter but the variable name suggests it is actually a flow rate. I want you to fix the comment.

You moved it, but didn't change anything. The comment says it's a timer counter but the variable name suggests it is actually a flow rate. I want you to fix the comment.

I think system messages (non Dialin (test) functions should come first in this table so that they are found faster.

I think system messages (non Dialin (test) functions should come first in this table so that they are found faster.

I think this would be a TD s/w fault (alarm already define). Just need a new TD s/w fault ID in AlarmMgmtSWFaults.h.

I think this would be a TD s/w fault (alarm already define). Just need a new TD s/w fault ID in AlarmMgmtSWFaults.h.

This structure doesn't seem necessary - it's just a middle man. Why not just pass the #defines directly into the quadratic macro?

This structure doesn't seem necessary - it's just a middle man. Why not just pass the #defines directly into the quadratic macro?

Fixed

Fixed

removed from here

removed from here

fixed

fixed

We need new alarm . That should be included in SRS right ? or shall i use SET_ALARM_WITH_2_U32_DATA( ALARM_ID_TD_SOFTWARE_FAULT) ?

We need new alarm . That should be included in SRS right ? or shall i use SET_ALARM_WITH_2_U32_DATA( ALARM_ID_TD_SOFTWARE_FAULT) ?

Add blank line after declarations.

Add blank line after declarations.

Alarm should be handled inside of setAirPumpState().

Alarm should be handled inside of setAirPumpState().

Alarm should be handled inside of setAirPumpState().

Alarm should be handled inside of setAirPumpState().

Alarm should be handled inside of setAirPumpState().

Alarm should be handled inside of setAirPumpState().

Alarm should be handled inside of setAirPumpState().

Alarm should be handled inside of setAirPumpState().

Alarm should be handled inside of setAirPumpState().

Alarm should be handled inside of setAirPumpState().

Alarm should be handled inside of setAirPumpState().

Alarm should be handled inside of setAirPumpState().

Add blank line after declarations.

Add blank line after declarations.

I think alarm should be handled inside the setAirPumpState() function.

I think alarm should be handled inside the setAirPumpState() function.

Should we have alarm here?

Should we have alarm here?

duty misspelled.

duty misspelled.

Can we remove inclusion of fpga here? It shouldn't be needed.

Can we remove inclusion of fpga here? It shouldn't be needed.

Added

Added

Updated

Updated

Removed and replaced

Removed and replaced

Added

Added

Updated

Updated