leahi-common

Clone Tools

Stats

Commits this week: 33
Total Committers: 19
Last Commit: 14:13
Commits this week: 33

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
2 hrs ago

Sean Nash

Remove extra blank line.

Remove extra blank line.

3 hrs ago

Sean Nash

This looks like leftover from merge conflict. Remove this line.

This looks like leftover from merge conflict. Remove this line.

3 hrs ago

Vendor - TEL - Jashwant Gantyada

3 hrs ago

Sean Nash

What do we do if BP module reports an error? Do we just go to idle state and there is no alarm?

What do we do if BP module reports an error? Do we just go to idle state and there is no alarm?

3 hrs ago

Sean Nash and Vinayakam Mani

4 hrs ago

Vendor - TEL - Varshini Nagabooshanam

Thats for error register so not required now

Thats for error register so not required now

5 hrs ago

Vendor - TEL - Varshini Nagabooshanam

You’re right. I should also check the busy status before transitioning to the GET_DATA state. I’ll update the measurement completion logic to first verify the busy bit is cleared, then validate the...

You’re right. I should also check the busy status before transitioning to the GET_DATA state. I’ll update the measurement completion logic to first verify the busy bit is cleared, then validate the BP data response code before moving to BP_DRIVER_GET_DATA_STATE.

Thursday 21 May
10:46 pm

Sean Nash

Why do you have {} in the cases?

Why do you have {} in the cases?

10:45 pm

Sean Nash

You are getting bpResults, but not doing anything with them. Should you pass as parameter to checkBloodPressureReading() function?

You are getting bpResults, but not doing anything with them. Should you pass as parameter to checkBloodPressureReading() function?

10:43 pm

Sean Nash

Where are these get functions defined? I can't find them.

Where are these get functions defined? I can't find them.

4:27 pm

Vendor - TEL - Arpita Srivastava

3:24 pm

Vendor - TEL - Jashwant Gantyada

restored

restored

3:24 pm

Sean Nash

Not sure why Crucible is showing it this way. Let's just re-review these diffs.

Not sure why Crucible is showing it this way. Let's just re-review these diffs.

3:18 pm

Sean Nash

Should be #ifndef

Should be #ifndef

3:13 pm

Sean Nash

Should be #ifndef I think.

Should be #ifndef I think.

3:06 pm

Sean Nash

Can we make these low priority and 999 rank?

Can we make these low priority and 999 rank?

3:06 pm

Vendor - TEL - Jashwant Gantyada and Sean Nash

12:11 pm

Vendor - TEL - Varshini Nagabooshanam

Removed

Removed

12:02 pm

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

11:28 am

Sean Nash

Do we not need the module error alarm?

Do we not need the module error alarm?

11:27 am

Sean Nash

This is not an atomic assignment, so we have to consider thread safety. If this driver is running from General Task (I believe it is since ModeTreatment's exec will be calling the BPModule's exec w...

This is not an atomic assignment, so we have to consider thread safety.
If this driver is running from General Task (I believe it is since ModeTreatment's exec will be calling the BPModule's exec which calls this driver's exec) and if the caller to this function will also be running from General Task (I believe it is since BPModule controller is the caller), then there is no thread safety issue and we should mention in the function header brief that this function should only be called from within the General Task.
If another task is involved (e.g. Priority Task is calling this function), this function could be interrupting the get data state while it is populating bpResults with new results and the caller would get a mix of old and new results (we would not want that).

11:21 am

Sean Nash

same.

same.

11:20 am

Sean Nash

same.

same.

11:20 am

Sean Nash

Just like driver state machine, we should only set a request flag to TRUE here and let the state machine handle the transition.

Just like driver state machine, we should only set a request flag to TRUE here and let the state machine handle the transition.

11:19 am

Sean Nash

How do we get out of Idle state?

How do we get out of Idle state?

11:18 am

Sean Nash

This should be called in all states (so in controller's exec function).

This should be called in all states (so in controller's exec function).

11:17 am

Sean Nash

I don't think we want to zero this count here.

I don't think we want to zero this count here.

11:16 am

Sean Nash

We need to call the driver exec function from this exec function - either before or after the switch statement.

We need to call the driver exec function from this exec function - either before or after the switch statement.

11:10 am

Sean Nash

We need to call this from ModeTreatment transition function.

We need to call this from ModeTreatment transition function.

11:09 am

Sean Nash

We need to call this function from ModeTreatment exec function.

We need to call this function from ModeTreatment exec function.