leahi-common

Clone Tools

Stats

Commits this week: 32
Total Committers: 19
Last Commit: 09:59
Commits this week: 32

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 27 May
10:59 am

Vendor - TEL - Vijay Pamula

LDT:3970 Addressed review comments for Edit treatment parameters

Options
    • -2
    • +2
    /TDDefs.h
10:57 am

Vinayakam Mani

Can we change the MACRO name to 64 step, if we are using 64 micro steps for HDF?

Can we change the MACRO name to 64 step, if we are using 64 micro steps for HDF?

10:33 am

Vinayakam Mani

Do we need to add the D92 pump speed read registers and handle appropriate monitor functions in Substitution Pump controller file?

Do we need to add the D92 pump speed read registers and handle appropriate monitor functions in Substitution Pump controller file?

10:31 am

Dara Navaei

Done

Done

10:26 am

Dara Navaei

Done

Done

10:26 am

Vinayakam Mani

add a blank line.

add a blank line.

10:25 am

Vinayakam Mani

Change to HDF pump. also update D92 instead of D76.

Change to HDF pump. also update D92 instead of D76.

10:24 am

Sean Nash

Non-Dialin messages should be higher in this list than Dialin messages. Move this above all of the "test" handlers.

Non-Dialin messages should be higher in this list than Dialin messages. Move this above all of the "test" handlers.

10:24 am

Dara Navaei

If the check RAM ECC is disabled in the HALCoGen, this code will not be created.

If the check RAM ECC is disabled in the HALCoGen, this code will not be created.

10:23 am

Vinayakam Mani

Remove blank line

Remove blank line

10:22 am

Dara Navaei

If the check RAM ECC is disabled in the HALCoGen, this code will not be created.

If the check RAM ECC is disabled in the HALCoGen, this code will not be created.

10:22 am

Dara Navaei

If you disable mpu in the HALCoGen, this code will not be created.

If you disable mpu in the HALCoGen, this code will not be created.

10:16 am

Sean Nash

This is auto generated code. How do we keep this code from re-appearing when somebody regenerates this code?

This is auto generated code. How do we keep this code from re-appearing when somebody regenerates this code?

10:14 am

Sean Nash

same.

same.

10:14 am

Sean Nash

same.

same.

10:13 am

Sean Nash

We shouldn't delete Halcogen code. Add a #if 0 in this user code section and add a #endif in the user code section following _coreEnableFlashEcc() call.

We shouldn't delete Halcogen code.
Add a #if 0 in this user code section and add a #endif in the user code section following _coreEnableFlashEcc() call.

9:54 am

Sean Nash

Should this be commented out before merge?

Should this be commented out before merge?

9:53 am

Sean Nash

These are not in alphabetical order. See ModeStandby and ModeService and ModeFault.

These are not in alphabetical order. See ModeStandby and ModeService and ModeFault.

9:47 am

Sean Nash

These should come before PC channels (higher priority).

These should come before PC channels (higher priority).

9:36 am

Dara Navaei

Done

Done

9:36 am

Dara Navaei

Done

Done

9:35 am

Dara Navaei

Done

Done

9:32 am

Dara Navaei

LDT-3259 merged staging and resolved the conflicts

Options
    • -71
    • +38
    /AlarmDefs.h
    • -4
    • +5
    /DDDefs.h
    • -3
    • +2
    /MsgDefs.h
    • -6
    • +7
    /TDDefs.h
9:07 am

Sean Nash

Alphabetize.

Alphabetize.

9:04 am

Sean Nash

Comment this out before merge.

Comment this out before merge.

9:03 am

Sean Nash

Comment this out before merge.

Comment this out before merge.

Tuesday 26 May
5:37 pm

Vendor - TEL - Varshini Nagabooshanam

LDT-2240-disposable-tube-set-self-test

Options
    • -2
    • +1
    /AlarmDefs.h
2:59 pm

Dara Navaei

Yes. The integrity module is in leahi-fwcommon repository, and it serves both TD and DD.

Yes. The integrity module is in leahi-fwcommon repository, and it serves both TD and DD.

2:56 pm

Dara Navaei

These are located in the integrity.c

These are located in the integrity.c

2:55 pm

Dara Navaei

Yes the ECC checks are done in the bootloader stack.

Yes the ECC checks are done in the bootloader stack.