leahi-common

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Can we be a little more specific about what conductivity we are returning in these functions? And I think we should include constants in the Inputs section of function headers.

Can we be a little more specific about what conductivity we are returning in these functions?
And I think we should include constants in the Inputs section of function headers.

Should the word "GENERIC" be in here somewhere?

Should the word "GENERIC" be in here somewhere?

Is ADJUST appropriate in context of this message? What are we adjusting?

Is ADJUST appropriate in context of this message? What are we adjusting?

What is the 3rd modality?

What is the 3rd modality?

Return type should be an enum (TREATMENT_TYPE_T).

Return type should be an enum (TREATMENT_TYPE_T).

Return type should be an enum (FLUID_BOLUS_MEDIUM_T).

Return type should be an enum (FLUID_BOLUS_MEDIUM_T).

Move after Modes so they are alphabetized.

Move after Modes so they are alphabetized.

updated

updated

updated

updated

updated

updated

moved.

moved.

updated

updated

Remove extra ;

Remove extra ;

Can we align comments?

Can we align comments?

updated

updated

Where did this get moved to?

Where did this get moved to?

Missing pinch valves (H1 and H19).

Missing pinch valves (H1 and H19).

Remove this blank line.

Remove this blank line.

Move below Messaging.h to keep list in alphabetical order.

Move below Messaging.h to keep list in alphabetical order.

balancingError is an input.

balancingError is an input.

Same here. Let's use only D29.

Same here. Let's use only D29.

Suppose to use D74, Instead of D17 (for Control only).

Suppose to use D74, Instead of D17 (for Control only).

Move these functions to top area where all public functions defined. let's keep the static function after the public function.

Move these functions to top area where all public functions defined. let's keep the static function after the public function.

Missing Comment.

Missing Comment.

yes

yes