leahi-common

Clone Tools

Stats

Commits this week: 59
Total Committers: 19
Last Commit: 13:00
Commits this week: 59

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 30 Jul
5:52 pm

Sean Nash

5:07 pm

Vendor - TEL - Arpita Srivastava

align comments

align comments

5:02 pm

Vendor - TEL - Arpita Srivastava

All the else if should always have an ending else block. add a blank else block or change line 232 as else { if() { } }

All the else if should always have an ending else block.

add a blank else block or change line 232 as
else
{
if() { }
}

4:58 pm

Vendor - TEL - Arpita Srivastava

Add @alarms

Add @alarms

3:20 pm

Vendor - TEL - Jashwant Gantyada

will create a branch for dialin and make the necessary changes. Before merging will talk to Caitlynn to change the variable in automated testing as well.

will create a branch for dialin and make the necessary changes. Before merging will talk to Caitlynn to change the variable in automated testing as well.

3:04 pm

Vendor - TEL - Arpita Srivastava

2:50 pm

Vendor - TEL - Vijay Pamula

Updated to store the result in a local BOOL

Updated to store the result in a local BOOL

2:35 pm

Sean Nash and Michael Garthwaite

2:35 pm

Vendor - TEL - Suresh Dharnala

Yes, these are low-priority alarms

Yes, these are low-priority alarms

2:35 pm

Vendor - TEL - Suresh Dharnala

Yes, these are low-priority alarms

Yes, these are low-priority alarms

2:32 pm

Sean Nash

Set to local BOOL and then return the BOOL.

Set to local BOOL and then return the BOOL.

2:31 pm

Sean Nash

Make a #define up top for the 5.

Make a #define up top for the 5.

2:30 pm

Sean Nash

Initialize this in the init function instead of here.

Initialize this in the init function instead of here.

2:29 pm

Vendor - TEL - Vijay Pamula

Yes,I Added the Dial-in override function for the publish interval.

Yes,I Added the Dial-in override function for the publish interval.

2:24 pm

Vendor - TEL - Arpita Srivastava

Please confirm if these are low-priority alarms at rank 999?

Please confirm if these are low-priority alarms at rank 999?

2:23 pm

Vendor - TEL - Arpita Srivastava

Please confirm if these are low-priority alarms at rank 999?

Please confirm if these are low-priority alarms at rank 999?

2:02 pm

Dara Navaei

LEAHI-COMMON-LDT-5184_System Data and Logs (DD) - Conductivity Sensor Calibration (3/3)
LEAHI-COMMON-LDT-5184_System Data and Logs (DD) - Conductivity Sensor Calibration (3/3)
1:42 pm

Vendor - TEL - Arpita Srivastava

1:38 pm

Vinayakam Mani

Remove empty line

Remove empty line

1:33 pm

Vinayakam Mani

Please sync this payload in DD firmware, Leahi-dialin and System Scripts.

Please sync this payload in DD firmware, Leahi-dialin and System Scripts.

1:28 pm

Vinayakam Mani

Align the indent

Align the indent

12:08 pm

Vinayakam Mani

Add the header description.

Add the header description.

12:04 pm

Vinayakam Mani

Do we need to transition to next state DD_PREGEN_DRY_BICART_INITIAL_FILL here?

Do we need to transition to next state DD_PREGEN_DRY_BICART_INITIAL_FILL here?

11:57 am

Vinayakam Mani

Remove empty lines.

Remove empty lines.

11:49 am

Vinayakam Mani

Add comments across the file.

Add comments across the file.

11:42 am

Vinayakam Mani

Add comment.

Add comment.

11:41 am

Vinayakam Mani

Add a test support for Pregen fill request.

Add a test support for Pregen fill request.

11:27 am

Vinayakam Mani

Update header description for all newly added functions.

Update header description for all newly added functions.

11:23 am

Vendor - TEL - Arpita Srivastava

11:04 am

Vinayakam Mani

You may need to check other flags such as DryBicartFillRequested( Initial Fill), bicarbChamberFillRequested (Filling Chamber F), instead of 'bicarbChamberPregenFillRequested'. Keep Drain and Depres...

You may need to check other flags such as DryBicartFillRequested( Initial Fill), bicarbChamberFillRequested (Filling Chamber F), instead of 'bicarbChamberPregenFillRequested'. Keep Drain and DepressurizeRequest flag as is. This makes sure at any given point, dryBicartExec calls one of the service only.