leahi-common

AlarmDefs.h

Clone Tools

Stats

Commits this week: 22
Total Committers: 15
Last Commit: 22 May
Commits this week: 22

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 18 May
4:28 pm

suresh

LDT-4072: Fix battery alarm priority rank and add message IDs

Options
    • -4
    • +6
    /AlarmDefs.h
  2. … 1 more file in changeset.
11:44 am

Sean Nash

10:10 am

Vendor - TEL - Varshini Nagabooshanam

Yes Noe said to replace with new register

Yes Noe said to replace with new register

10:09 am

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

10:09 am

Vendor - TEL - Varshini Nagabooshanam

Sure

Sure

9:45 am

Vendor - TEL - Arpita Srivastava

please add bpLeftHomeTimerCounter to inputs and outputs.

please add bpLeftHomeTimerCounter to inputs and outputs.

9:44 am

Vendor - TEL - Arpita Srivastava

please add bpLeftHomeTimerCounter to inputs and outputs.

please add bpLeftHomeTimerCounter to inputs and outputs.

Sunday 17 May
11:34 pm

Sean Nash

It is weird that we're responding so far from request. It is not clear to me that Dialin has requested anything at this point.

It is weird that we're responding so far from request. It is not clear to me that Dialin has requested anything at this point.

11:26 pm

Sean Nash

Details looks weird. Where is inputs and outputs like other function headers?

Details looks weird. Where is inputs and outputs like other function headers?

11:19 pm

Sean Nash

Add a blank line after banner.

Add a blank line after banner.

11:19 pm

Sean Nash

Please restore before you merge to staging.

Please restore before you merge to staging.

11:16 pm

Sean Nash

If I'm reading this right, we're saying that if bad CRC alarm is NOT enabled, initialize the alarm? That seems backward.

If I'm reading this right, we're saying that if bad CRC alarm is NOT enabled, initialize the alarm? That seems backward.

11:14 pm

Sean Nash

Same comments as ENABLE_ALARM_1 above.

Same comments as ENABLE_ALARM_1 above.

11:13 pm

Sean Nash

Same comments as ENABLE_ALARM_1 above.

Same comments as ENABLE_ALARM_1 above.

11:13 pm

Sean Nash

This definitions has a terrible name (I have no idea what it does) and I think it should be reversed (i.e. alarms are disabled when defined so that a release build will have alarms enabled).

This definitions has a terrible name (I have no idea what it does) and I think it should be reversed (i.e. alarms are disabled when defined so that a release build will have alarms enabled).

10:38 pm

Sean Nash

If we don't set this pwm time anymore, we don't need this. Please make sure we really don't need this anymore though.

If we don't set this pwm time anymore, we don't need this. Please make sure we really don't need this anymore though.

10:37 pm

Sean Nash

I don't think these definitions need to be public. Some of these should probably be inside the FpgaTD.c and some should probably be inside your driver's .c file.

I don't think these definitions need to be public. Some of these should probably be inside the FpgaTD.c and some should probably be inside your driver's .c file.

10:35 pm

Sean Nash

create a local BOOL result and use a ternary to assign FALSE or TRUE explicitly.

create a local BOOL result and use a ternary to assign FALSE or TRUE explicitly.

10:25 pm

Sean Nash

Did Noe delete the H12 period register? According to this structure, syrPumpDACControl is 2 bytes (U16), so next register should be 42 (40+2). So why do you have 41? Something is out of sync with H...

Did Noe delete the H12 period register?
According to this structure, syrPumpDACControl is 2 bytes (U16), so next register should be 42 (40+2). So why do you have 41? Something is out of sync with HDD here. Please align with the HDD.

10:23 pm

Sean Nash

What is in registers 378..383? We need to add those registers or incoming data won't overlay properly into structure.

What is in registers 378..383? We need to add those registers or incoming data won't overlay properly into structure.

Friday 15 May
6:12 pm

Sean Nash

Call the init for the battery driver here.

Call the init for the battery driver here.

6:11 pm

Sean Nash

INVALID_BATTERY

INVALID_BATTERY

5:52 pm

Sean Nash

Remove repeating entries.

Remove repeating entries.

5:49 pm

Sean Nash

remove extra blank line.

remove extra blank line.

5:48 pm

Sean Nash

Remove this comment.

Remove this comment.

5:48 pm

Sean Nash

Remove blank line.

Remove blank line.

5:47 pm

Sean Nash

initialize all of these in init function.

initialize all of these in init function.

5:47 pm

Sean Nash

Missing doxygen group

Missing doxygen group

5:46 pm

Sean Nash

These should be in alphabetical order.

These should be in alphabetical order.

5:45 pm

Sean Nash

Update all function headers to Leahi format (e.g. input and output have a \b to make them bold).

Update all function headers to Leahi format (e.g. input and output have a \b to make them bold).