leahi-common

AlarmDefs.h

Clone Tools

Stats

Commits this week: 8
Total Committers: 15
Last Commit: 29 May
Commits this week: 8

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 26 May
10:34 am

Vendor - TEL - Varshini Nagabooshanam

Friday 22 May
3:39 pm

Vendor - TEL - Praneeth Bunne

1:31 pm

Sean Nash and Vendor - TEL - Arpita Srivastava

1:14 pm

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

12:22 pm

Vendor - TEL - Jashwant Gantyada and Sean Nash

12:09 pm

Vendor - TEL - Varshini Nagabooshanam

Removed

Removed

12:09 pm

Vendor - TEL - Varshini Nagabooshanam

Fixed

Fixed

12:03 pm

Vendor - TEL - Varshini Nagabooshanam

Removed

Removed

12:03 pm

Vendor - TEL - Varshini Nagabooshanam

Added alarm

Added alarm

12:02 pm

Vendor - TEL - Varshini Nagabooshanam

Added back

Added back

11:28 am

Sean Nash

Add alarm here.

Add alarm here.

11:26 am

Sean Nash

Make h10DACControl a U08.

Make h10DACControl a U08.

11:17 am

Sean Nash

Remove extra blank line.

Remove extra blank line.

11:15 am

Sean Nash

This looks like leftover from merge conflict. Remove this line.

This looks like leftover from merge conflict. Remove this line.

11:11 am

Vendor - TEL - Jashwant Gantyada

11:09 am

Sean Nash

What do we do if BP module reports an error? Do we just go to idle state and there is no alarm?

What do we do if BP module reports an error? Do we just go to idle state and there is no alarm?

10:50 am

Sean Nash and Vinayakam Mani

10:04 am

Vendor - TEL - Varshini Nagabooshanam

Thats for error register so not required now

Thats for error register so not required now

9:14 am

Vendor - TEL - Varshini Nagabooshanam

You’re right. I should also check the busy status before transitioning to the GET_DATA state. I’ll update the measurement completion logic to first verify the busy bit is cleared, then validate the...

You’re right. I should also check the busy status before transitioning to the GET_DATA state. I’ll update the measurement completion logic to first verify the busy bit is cleared, then validate the BP data response code before moving to BP_DRIVER_GET_DATA_STATE.

Thursday 21 May
10:46 pm

Sean Nash

Why do you have {} in the cases?

Why do you have {} in the cases?

10:45 pm

Sean Nash

You are getting bpResults, but not doing anything with them. Should you pass as parameter to checkBloodPressureReading() function?

You are getting bpResults, but not doing anything with them. Should you pass as parameter to checkBloodPressureReading() function?

10:43 pm

Sean Nash

Where are these get functions defined? I can't find them.

Where are these get functions defined? I can't find them.

4:27 pm

Vendor - TEL - Arpita Srivastava

3:24 pm

Vendor - TEL - Jashwant Gantyada

restored

restored

3:24 pm

Sean Nash

Not sure why Crucible is showing it this way. Let's just re-review these diffs.

Not sure why Crucible is showing it this way. Let's just re-review these diffs.

3:18 pm

Sean Nash

Should be #ifndef

Should be #ifndef

3:13 pm

Sean Nash

Should be #ifndef I think.

Should be #ifndef I think.

3:06 pm

Sean Nash

Can we make these low priority and 999 rank?

Can we make these low priority and 999 rank?

3:06 pm

Vendor - TEL - Jashwant Gantyada and Sean Nash

12:11 pm

Vendor - TEL - Varshini Nagabooshanam

Removed

Removed