leahi-common

AlarmDefs.h

Clone Tools

Stats

Commits this week: 23
Total Committers: 17
Last Commit: 03 Aug
Commits this week: 23

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 29 Jul
5:37 pm

Dara Navaei

4:19 pm

Sean Nash

10:55 am

Vendor - TEL - Suresh Dharnala

Fixed.

Fixed.

10:54 am

Vendor - TEL - Suresh Dharnala

Moved.

Moved.

10:53 am

Sean Nash

Move buttons down just above "Comm.h". And why is buttons being included here?

Move buttons down just above "Comm.h". And why is buttons being included here?

10:53 am

Vendor - TEL - Suresh Dharnala

This reason code is not used anywhere, and the existing REQUEST_REJECT_REASON_NOT_ALLOWED_IN_CURRENT_MODE can be used if a rejection response is needed. I removed the new reason code.

This reason code is not used anywhere, and the existing REQUEST_REJECT_REASON_NOT_ALLOWED_IN_CURRENT_MODE can be used if a rejection response is needed. I removed the new reason code.

10:50 am

Sean Nash

I don't see it.

I don't see it.

10:50 am

Sean Nash

I don't see it.

I don't see it.

10:43 am

Sean Nash

I would think reason code 1 would work for this - do we really need to add this one?

I would think reason code 1 would work for this - do we really need to add this one?

10:42 am

Sean Nash

Fix this.

Fix this.

Tuesday 28 Jul
4:37 pm

Vendor - TEL - Arpita Srivastava

2:47 pm

Vendor - TEL - Arpita Srivastava

break this line

break this line

2:39 pm

Vendor - TEL - Arpita Srivastava

add an empty else block after the last else if block in these functions handlePreTxHeparinPreloadState handlePreTxHeparinAwaitSyringeLoadConfirmationState handlePreTxHeparinSeekState handlePreTxHep...

add an empty else block after the last else if block in these functions
handlePreTxHeparinPreloadState
handlePreTxHeparinAwaitSyringeLoadConfirmationState
handlePreTxHeparinSeekState
handlePreTxHeparinPrimeState
handlePreTxHeparinBolusState

2:32 pm

Vendor - TEL - Arpita Srivastava

break this line

break this line

12:57 pm

Vendor - TEL - Suresh Dharnala

Updated as suggested by removing the unnecessary else block and reject command. Retested the power-off confirmation and shutdown flow successfully.

Updated as suggested by removing the unnecessary else block and reject command. Retested the power-off confirmation and shutdown flow successfully.

12:56 pm

Vendor - TEL - Suresh Dharnala

Updated to remove the return from the middle of the function. The function now sets newID and returns only once at the end. Retested successfully.

Updated to remove the return from the middle of the function. The function now sets newID and returns only once at the end. Retested successfully.

10:44 am

Vendor - TEL - Arpita Srivastava

Add initialization for heparinSetupResumeRequested and syringeLoadConfirmed

Add initialization for heparinSetupResumeRequested and syringeLoadConfirmed

10:42 am

Vendor - TEL - Arpita Srivastava

Align all the function comments

Align all the function comments

10:19 am

Vendor - TEL - Arpita Srivastava

Delete this row.

Delete this row.

Monday 27 Jul
11:21 am

Vendor - TEL - Arpita Srivastava

Added but crucible is not showing this change. Please check bitbucket.

Added but crucible is not showing this change. Please check bitbucket.

11:17 am

Vendor - TEL - Arpita Srivastava

These variables are correctly initialized to the first enum in the list.

These variables are correctly initialized to the first enum in the list.

11:16 am

Vendor - TEL - Arpita Srivastava

Not needed because the retry mechanism is going to be deleted in the next ticket.

Not needed because the retry mechanism is going to be deleted in the next ticket.

11:16 am

Vendor - TEL - Arpita Srivastava

I would rather keep it. Anyways, we need an else block after else if, as per MISRA guidelines.

I would rather keep it. Anyways, we need an else block after else if, as per MISRA guidelines.

11:15 am

Vendor - TEL - Arpita Srivastava

I would rather keep it. Anyways, we need an else block after else if, as per MISRA guidelines.

I would rather keep it. Anyways, we need an else block after else if, as per MISRA guidelines.

11:14 am

Vendor - TEL - Arpita Srivastava

Not needed because the retry mechanism is going to be deleted in the next ticket.

Not needed because the retry mechanism is going to be deleted in the next ticket.

Sunday 26 Jul
8:37 pm

Sean Nash

Should this be the "Load Syringe" alarm that you just added?

Should this be the "Load Syringe" alarm that you just added?

Friday 24 Jul
4:37 pm

Sean Nash

Can't return in middle of function code.

Can't return in middle of function code.

4:29 pm

Sean Nash

Remove else and reject command in it and re-test.

Remove else and reject command in it and re-test.

Thursday 23 Jul
4:57 pm

Vendor - TEL - Jashwant Gantyada

3:58 pm

Vinayakam Mani