leahi-dialin / leahi_dialin / common

msg_ids.py

Clone Tools

Stats

Commits this week: 5
Total Committers: 16
Last Commit: 10:13
Commits this week: 5

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 21 Jul
4:15 pm

Nicholas Ramirez

LDT-5235 HDF - SW - 01 - HDF - Messaging & Models - R&I - 03: DEV - Feature Implementation & Code Document [& Diagnostics]

add HDF mesaging

Options
    • -7
    • +7
    ./msg_ids.py
  2. … 1 more file in changeset.
10:19 am

Dara Navaei

LEAHI-DIALIN-LDT-5232_HDF - SW - 01 - HDF - Messaging & Models - R&I
LEAHI-DIALIN-LDT-5232_HDF - SW - 01 - HDF - Messaging & Models - R&I
9:52 am

Vendor - TEL - Arpita Srivastava

9:50 am

Zoltan Miskolci

Merge branch 'LDT-3735-non-volatile-memory' into staging

Options
    • -69
    • +92
    ./msg_ids.py
  2. … 4 more files in changeset.
9:15 am

Zoltan Miskolci

Merge branch 'LDT-3735-non-volatile-memory' into develop

Options
    • -69
    • +92
    ./msg_ids.py
  2. … 7 more files in changeset.
7:29 am

Raghu Kallala

Friday 17 Jul
4:04 pm

Dara Navaei

LEAHI-DIALIN-LDT-4767_SW Misc & Enhc - SW - 01 - Isolated UF - R&I
LEAHI-DIALIN-LDT-4767_SW Misc & Enhc - SW - 01 - Isolated UF - R&I
Thursday 16 Jul
4:38 pm

Nicholas Ramirez

LDT-4775 SW Misc & Enhc - SW - 01 - Isolated UF - R&I - 08: DEV - Dialin Implementation

added iso uf dialin state

Options
    • -2
    • +2
    ./msg_ids.py
  2. … 1 more file in changeset.
2:24 pm

Michael Garthwaite

LDT-4611: add HDF module

Options
    • -0
    • +5
    ./msg_ids.py
  2. … 5 more files in changeset.
Wednesday 15 Jul
3:04 pm

Dara Navaei

LEAHI-DIALIN-LDT-4611_HDF - FW Implementation - 5/4:
LEAHI-DIALIN-LDT-4611_HDF - FW Implementation - 5/4:
Tuesday 14 Jul
9:08 am

Sean Nash

Monday 13 Jul
2:46 pm

Tiffany Mejia and Michael Garthwaite

11:51 am

Zoltan Miskolci

10:17 am

Dara Navaei

LEAHI-DIALIN-LDT-5074_SW Misc & Enhc - SW - 01 - Feature Complete - R&I
LEAHI-DIALIN-LDT-5074_SW Misc & Enhc - SW - 01 - Feature Complete - R&I
Sunday 12 Jul
11:44 pm

Behrouz NematiPour

Zoltan and I had a meeting, and the counter solution he provided works better than mine. He explained to me that my proposed solution has flaws. RESOLVED.

Zoltan and I had a meeting, and the counter solution he provided works better than mine.
He explained to me that my proposed solution has flaws.
RESOLVED.

Friday 10 Jul
11:45 am

Tiffany Mejia and Michael Garthwaite

Wednesday 08 Jul
12:03 pm

Nicholas Ramirez

LDT-5082 SW Misc & Enhc - SW - 01 - Miscellaneous - Feature Complete - R&I - 08: DEV - Dialin Implementation

add dd ro water mode plugin

Options
    • -1
    • +2
    ./msg_ids.py
  2. … 2 more files in changeset.
Tuesday 07 Jul
2:03 pm

Zoltan Miskolci

Merge branch 'LDT-4872-patient_vitals' into develop

Options
    • -2
    • +2
    ./msg_ids.py
  2. … 2 more files in changeset.
Monday 06 Jul
4:20 pm

Zoltan Miskolci

patient vitals module

Options
    • -2
    • +2
    ./msg_ids.py
  2. … 3 more files in changeset.
3:08 pm

Vendor - TEL - Santhoshkumar Reddy Alasandagutti

12:55 pm

Sean Nash

Thursday 02 Jul
3:39 pm

Nicholas Ramirez

3:38 pm

Behrouz NematiPour and Stephen Quong

3:36 pm

Nicholas Ramirez

bn approves

bn approves

3:11 pm

Vinayakam Mani

Wednesday 01 Jul
3:02 pm

Zoltan Miskolci

The approach of what this code does and the conversion module are similar in function but a differ on maintenance and flexibility. 1. The conversion module's bytearray to value methods work, but th...

The approach of what this code does and the conversion module are similar in function but a differ on maintenance and flexibility.
1. The conversion module's bytearray to value methods work, but they require manual logistic around the indexing. It's the user's responsibility to handle where the reading starts and you need to code the handler for that (previous approach with MsgFieldPositions), It's inflating the method. I worked hard to remove the need for indexing where the value starts. Instead of the previous struct.unpack approach, where you needed to maintain the type, you will be needing to maintain the conversion methods that are being called, so it would be the same as before, you still need to mind the indexing, which was the main reason of changing from this approach.

2. In the current approach, you declare the type and pass it to a processor that dynamically handling the unpack type (based on the set datatype) and the indexing for that. This works much better and easier to maintain, as you can just insert a new value when it's added to the FW, and don't need to adjust all your indexes for the reading.

Example #1, changing build type from U16 to U08:

  • with the conversion approach, you need to change the function used, and update the starting index for all the following methods.
  • with the current approach you change the Datatype.U16 to Datatype.U08 and that's all you need to do.


Example #2: adding a new variable fpga_micro after fpga_minor, with U08 type:

  • with the conversion approach, you add the bytearray_to_byte, update the indexes for all the following reads.
  • with the current approach you insert an element after the fpga_minor with a value ('fpga_micro', Datatype.U08), and nothing more needed
12:33 pm

Behrouz NematiPour

RESOLVED for now.

RESOLVED for now.

12:32 pm

Behrouz NematiPour

I would not do that because the function names and messages for each project should be different to avoid confusion. I think that is fine for now. RESOLVED.

I would not do that because the function names and messages for each project should be different to avoid confusion.
I think that is fine for now.

RESOLVED.

12:17 pm

Vendor - TEL - Santhoshkumar Reddy Alasandagutti

even though we are sending U08 at Firmware. Due to structure padding Raw message for priority is converted as 16 bits. While receiving we need to read them as U16. Here is my debug values [CortexR4...

even though we are sending U08 at Firmware. Due to structure padding Raw message for priority is converted as 16 bits. While receiving we need to read them as U16. Here is my debug values [CortexR4] ALARM_PROP_T size = 22 bytes
byte[0] = 0x03
byte[1] = 0x00
byte[2] = 0x6F
byte[3] = 0x00
byte[4] = 0x01
byte[5] = 0x00
byte[6] = 0x00
byte[7] = 0x01
byte[8] = 0x00
byte[9] = 0x00
byte[10] = 0x01
byte[11] = 0x00
byte[12] = 0x00
byte[13] = 0x01
byte[14] = 0x00
byte[15] = 0x00
byte[16] = 0x01
byte[17] = 0x00
byte[18] = 0x00
byte[19] = 0x01
byte[20] = 0x0A
byte[21] = 0x00

This is structure defined at firmware side
struct AlarmTableRequestPayload

Unknown macro: { U08 alarmPriority; U16 alarmSubRank; U08 alarmSource; U08 alarmIsFault; U08 alarmIsDDFault; U08 alarmStops; U08 alarmConditionClearImmed; ///< Alarm condition is cleared immediately (does not persist after alarm triggered) U08 alarmNoClear; ///< Alarm cannot be cleared (unrecoverable)? U08 alarmNoResume; ///< Alarm prevents treatment resume U08 alarmNoRinseback; ///< Alarm prevents rinseback U08 alarmNoEndTreatment; ///< Alarm prevents ending treatment U08 alarmBlockRinseback; ///< Alarm should not trigger while in rinseback states U08 alarmBlockEndTx; ///< Alarm should not trigger while in post-treatment mode U08 alarmNoBloodRecirc; ///< Alarm prevents blood re-circulation U08 alarmNoDialysateRecirc; ///< Alarm prevents dialysate re-circulation U08 alarmAutoResume; ///< Alarm should resume automatically once the condition is cleared U08 alarmClearOnly; ///< Clear only this alarm on user acknowledgment U08 alarmTreatmentLog; ///< Log alarm to treatment log if active during treatment U16 alarmID; ///< Alarm ID }

;
typedef struct AlarmTableRequestPayload ALARM_PROP_T;

12:11 pm

Behrouz NematiPour

So the same channels are used for both the Leahi and Denali? I am not talking about how collisions are handled; that is handled by the CAN driver, not the FW or SW. My point is that the CAN Channel...

So the same channels are used for both the Leahi and Denali?
I am not talking about how collisions are handled; that is handled by the CAN driver, not the FW or SW.
My point is that the CAN Channels by themselves do not have the meaning we want; they are only a priority.
As we defined them, we gave them a meaning as a category; therefore, it is better to name them the Denali/Leahi Channels rather than the CAN Channels.