leahi-dialin / leahi_dialin

fp

Clone Tools

Stats

Commits this week: 2
Total Committers: 7
Last Commit: 03 Feb
Commits this week: 2

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 26 Jan
4:19 pm

Vendor - TEL - Varshini Nagabooshanam and Sean Nash

Friday 23 Jan
3:18 pm

Michael Garthwaite

Thursday 22 Jan
10:07 am

Zoltan Miskolci

Wednesday 21 Jan
12:39 pm

Zoltan Miskolci

12:35 pm

Sean Nash

12:32 pm

Sean Nash and Raghu Kallala

12:22 pm

Zoltan Miskolci

11:08 am

Zoltan Miskolci

10:31 am

Raghu Kallala and Michael Garthwaite

9:47 am

Zoltan Miskolci

8:58 am

Sean Nash , Michael Garthwaite and Raghu Kallala

8:42 am

Raghu Kallala

8:42 am

Raghu Kallala

8:35 am

Zoltan Miskolci

Updated

Updated

Tuesday 20 Jan
3:33 pm

Tiffany Mejia

2:29 pm

Zoltan Miskolci

I didn't added any code for override. I also can't stop anyone to send in an override command with random numbers. The allowing of override should be on the FW part, where sending the override with...

I didn't added any code for override.
I also can't stop anyone to send in an override command with random numbers.
The allowing of override should be on the FW part, where sending the override with (sensor_id, value, no reset) should return false for those that are not accepted.

11:00 am

Raghu Kallala

We should not allow overrides for newly added internal temperatures

We should not allow overrides for newly added internal temperatures

10:42 am

Zoltan Miskolci

10:28 am

Michael Garthwaite

10:21 am

Zoltan Miskolci

Renamed

Renamed

10:21 am

Zoltan Miskolci

Moved it into login request

Moved it into login request

10:14 am

Zoltan Miskolci

I added the unique decorator back, except for the few that have aliases

I added the unique decorator back, except for the few that have aliases

9:32 am

Zoltan Miskolci

Renamed, also flagged for future type change.

Renamed, also flagged for future type change.

9:04 am

Dara Navaei

LEAHI-DIALIN-LDT-2980_Request: add ability to get the flowmeter measured internal temperature
LEAHI-DIALIN-LDT-2980_Request: add ability to get the flowmeter measured internal temperature
9:00 am

Zoltan Miskolci

8:41 am

Raghu Kallala

Monday 19 Jan
12:26 pm

Michael Garthwaite

This will always return 0 and delay init from completing by up to 0.5s as the user is not logged in at the time of init.

This will always return 0 and delay init from completing by up to 0.5s as the user is not logged in at the time of init.

12:25 pm

Michael Garthwaite

The naming of this method is misleading as it sends the message to request defeatured status and it is retrieved in a separate callback. The 'get' implies that the value returned from this method i...

The naming of this method is misleading as it sends the message to request defeatured status and it is retrieved in a separate callback. The 'get' implies that the value returned from this method is the defeatured status. The value returned is not the defeatured status but rather a T/F condition on if the FW replied back to dialin successfully.

suggestion: cmd_request_defeatured_status()

12:17 pm

Michael Garthwaite and Sean Nash

11:52 am

Michael Garthwaite

"No one should interact with it or be aware of it's existence, so the name shouldn't matter." *it matters to those who read the code in inconsistent intervals ( like those who participate in code...

"No one should interact with it or be aware of it's existence, so the name shouldn't matter."

  • it matters to those who read the code in inconsistent intervals ( like those who participate in code review or teaching ).


"As we only have 2 version in test at the same time."

  • Currently. By summer, i'd expect dialin to be considering 1.0's, 1.9s, and 2.0s/DVTs.


We have the choice to handle the redesign effort then or now.


Edit:
Follow up comment.

Looking at the other files. Users of dialin will not be aware of existence, but developers of dialin will as it impacts the behavior of overrides like temp & pressure.