leahi-dialin / leahi_dialin

fp

Clone Tools

Stats

Commits this week: 1
Total Committers: 8
Last Commit: 11:25
Commits this week: 1

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 21 May
5:09 pm

Zoltan Miskolci

references to Denali has been removed

references to Denali has been removed

11:31 am

Zoltan Miskolci

Removed Denali reference

Options
    • -19
    • +19
    ./filtration_purification.py
    • -9
    • +9
    ./modules/alarms.py
    • -8
    • +8
    ./modules/boost_pump.py
    • -13
    • +13
    ./modules/conductivity_sensors.py
    • -6
    • +6
    ./modules/events.py
    • -9
    • +9
    ./modules/flow_sensors.py
    • -7
    • +7
    ./modules/fp_test_configs.py
    • -6
    • +6
    ./modules/levels.py
    • -4
    • +4
    ./modules/permeate_tank.py
    • -6
    • +6
    ./modules/pressure_sensors.py
    • -8
    • +8
    ./modules/ro_pump.py
    • -6
    • +6
    ./modules/temperatures.py
    • -8
    • +8
    ./modules/valves.py
    • -5
    • +5
    ./modules/water_pumps.py
    • -4
    • +4
    ./proxies/dd_proxy.py
  16. … 61 more files in changeset.
7:44 am

Raghu Kallala

Shouldn't we use Leahi instead of Denali?

Shouldn't we use Leahi instead of Denali?

Thursday 07 May
10:12 am

Zoltan Miskolci

Added missing data for conversion

Options
    • -8
    • +8
    ./modules/events.py
  2. … 2 more files in changeset.
Wednesday 06 May
5:51 pm

Zoltan Miskolci

Added desc

Options
    • -1
    • +11
    ./modules/events.py
5:45 pm

Zoltan Miskolci

- Updated FP events

Options
    • -94
    • +103
    ./modules/events.py
4:07 pm

Zoltan Miskolci

- Updated Event enum - Updated Datatypes enum - Added some debugging print to abstract class - Removed some init import to remove cyclic dependencies - Updated alarms

Options
    • -25
    • +16
    ./modules/alarms.py
    • -14
    • +13
    ./modules/events.py
    • -1
    • +1
    ./modules/permeate_tank.py
  4. … 11 more files in changeset.
Tuesday 05 May
3:10 pm

Zoltan Miskolci

- Updated events

Options
    • -56
    • +35
    ./modules/events.py
  2. … 3 more files in changeset.
2:25 pm

Zoltan Miskolci

- Updated DD and TD module - Updaterd TDValvePosition enum

Options
    • -56
    • +54
    ./filtration_purification.py
    • -53
    • +52
    ./modules/alarms.py
    • -25
    • +21
    ./modules/boost_pump.py
    • -22
    • +27
    ./modules/conductivity_sensors.py
    • -1
    • +2
    ./modules/events.py
    • -10
    • +14
    ./modules/flow_sensors.py
    • -4
    • +6
    ./modules/fp_test_configs.py
    • -9
    • +14
    ./modules/levels.py
    • -9
    • +12
    ./modules/permeate_tank.py
    • -19
    • +18
    ./modules/pressure_sensors.py
    • -25
    • +22
    ./modules/ro_pump.py
    • -26
    • +23
    ./modules/temperatures.py
    • -7
    • +10
    ./modules/valves.py
    • -4
    • +6
    ./modules/water_pumps.py
    • -2
    • +3
    ./proxies/dd_proxy.py
  16. … 40 more files in changeset.
Monday 04 May
5:46 pm

Dara Navaei

LEAHI-DIALIN-LDT-3904_[OpMode] The operation mode broadcasts does not return the 3rd and 4th level modes
LEAHI-DIALIN-LDT-3904_[OpMode] The operation mode broadcasts does not return the 3rd and 4th level modes
5:24 pm

Zoltan Miskolci

- DD refactor Changes in FP and TD module

Options
    • -1
    • +2
    ./filtration_purification.py
    • -7
    • +8
    ./modules/alarms.py
    • -3
    • +4
    ./modules/boost_pump.py
    • -3
    • +4
    ./modules/conductivity_sensors.py
    • -17
    • +17
    ./modules/events.py
    • -3
    • +4
    ./modules/flow_sensors.py
    • -4
    • +4
    ./modules/fp_test_configs.py
    • -3
    • +4
    ./modules/levels.py
    • -3
    • +4
    ./modules/permeate_tank.py
    • -3
    • +4
    ./modules/pressure_sensors.py
    • -3
    • +4
    ./modules/ro_pump.py
    • -3
    • +4
    ./modules/temperatures.py
    • -3
    • +4
    ./modules/valves.py
    • -3
    • +3
    ./modules/water_pumps.py
    • -2
    • +2
    ./proxies/dd_proxy.py
  16. … 18 more files in changeset.
Friday 01 May
9:11 am

Zoltan Miskolci

It's present in fp_defs as FPRecoveryOptions

It's present in fp_defs as FPRecoveryOptions

Thursday 30 Apr
2:23 pm

Vendor - TEL - Sameer Poyil

Wednesday 29 Apr
12:05 pm

Vendor - TEL - Sameer Poyil

LDT-3984 addressed review comments

Options
    • -1
    • +1
    ./modules/levels.py
Tuesday 28 Apr
9:30 am

Zoltan Miskolci

What's the point of this line if you overwrite the lvl_sen value in the next 2 lines? I think the second lvl_sen is not needed, the one without the offset.

What's the point of this line if you overwrite the lvl_sen value in the next 2 lines?
I think the second lvl_sen is not needed, the one without the offset.

9:29 am

Zoltan Miskolci

LAST_DD_LEVL is in FW not in dialin. In dialin, you use the Num_of_levels, so this one is correct here. Example: In this case Num_of_levels is 4 (D6,D63,D98,D46), if in the override adding 4 to the...

LAST_DD_LEVL is in FW not in dialin.
In dialin, you use the Num_of_levels, so this one is correct here.
Example:
In this case Num_of_levels is 4 (D6,D63,D98,D46), if in the override adding 4 to the fp level sensor, which is 0, the payload will provide 4, which will be between the FIRST_FP_LEVL and LAST_FP_LEVL FW value as P25 index is 4.

9:15 am

Zoltan Miskolci

Why increment the number when you didn't add a new sensor?

Why increment the number when you didn't add a new sensor?

9:02 am

Raghu Kallala

This should be LAST_DD_LEVL not NUM_OF_LEVELS if DD and FP levels are in same enum

This should be LAST_DD_LEVL not NUM_OF_LEVELS if DD and FP levels are in same enum

9:00 am

Raghu Kallala

LEVEL_OFFSET?

LEVEL_OFFSET?

Monday 27 Apr
8:46 pm

Sean Nash and Raghu Kallala

8:44 pm

Vendor - TEL - Sameer Poyil

LDT-3984 fix for conductivie level sensors d46, d63,d98

Options
    • -1
    • +3
    ./modules/levels.py
  2. … 3 more files in changeset.
Sunday 26 Apr
2:46 pm

Sean Nash

Should this be an enumeration somewhere?

Should this be an enumeration somewhere?

Friday 24 Apr
10:45 pm

Vendor - TEL - Sameer Poyil

LDT-3984 conductive level sensor dialin implementation

Options
    • -3
    • +5
    ./modules/levels.py
  2. … 2 more files in changeset.
Thursday 23 Apr
8:02 am

Dara Navaei

LEAHI-DIALIN-LDT-3984_(DD, SW) D46 reads 0 with and without liquid in chamber
LEAHI-DIALIN-LDT-3984_(DD, SW) D46 reads 0 with and without liquid in chamber
Friday 10 Apr
10:20 am

Zoltan Miskolci

Thursday 09 Apr
3:48 pm

Zoltan Miskolci

Merge branch 'LDT-3910-td_test_conf' into develop

Options
    • -9
    • +8
    ./filtration_purification.py
3:20 pm

Raghu Kallala and Michael Garthwaite

3:03 pm

Zoltan Miskolci

-Added TD test config - Updated fp get requests based on latest change in FW

Options
    • -9
    • +8
    ./filtration_purification.py
  2. … 1 more file in changeset.
3:00 pm

Dara Navaei

LEAHI-DIALIN-LDT-3910_Request: add TD config flag so that alarms originating from other subsystems don't put the TD into fault mode
LEAHI-DIALIN-LDT-3910_Request: add TD config flag so that alarms originating from other subsystems don't put the TD into fault mode
Wednesday 08 Apr
11:26 am

Zoltan Miskolci