leahi-fwcommon

Clone Tools

Stats

Commits this week: 20
Total Committers: 13
Last Commit: 21:04
Commits this week: 20

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 10 Apr
10:25 am

Vendor - TEL - Sameer Poyil

its auto generated . should not change it manually. any way when merging its added correct value

its auto generated . should not change it manually. any way when merging its added correct value

10:24 am

Vendor - TEL - Sameer Poyil

Now we don't need this macro ?

Now we don't need this macro ?

10:17 am

Vendor - TEL - Sameer Poyil

now we are initializing sensor simultaneously?

now we are initializing sensor simultaneously?

10:16 am

Vendor - TEL - Sameer Poyil

comments missing

comments missing

10:15 am

Vendor - TEL - Sameer Poyil

comments missing

comments missing

10:15 am

Vendor - TEL - Sameer Poyil

This is not clear- please give a detailed description for this variable

This is not clear- please give a detailed description for this variable

10:14 am

Vendor - TEL - Sameer Poyil

use capital for starting letter

use capital for starting letter

10:13 am

Vendor - TEL - Sameer Poyil

please align the comments

please align the comments

10:13 am

Vendor - TEL - Sameer Poyil

please Alignment the comments

please Alignment the comments

10:10 am

Vendor - TEL - Sameer Poyil

Why the order is important here ? please document it

Why the order is important here ? please document it

10:06 am

Vendor - TEL - Sameer Poyil

10:06 am

Vendor - TEL - Sameer Poyil

do we need bracket here ? all text should start with capital

do we need bracket here ? all text should start with capital

10:00 am

Vendor - TEL - Sameer Poyil

Why a * here ?

Why a * here ?

9:43 am

Vendor - TEL - Sameer Poyil

is it write states or read state ?

is it write states or read state ?

9:43 am

Vendor - TEL - Sameer Poyil

is documentation correct ?

is documentation correct ?

Wednesday 08 Apr
12:25 pm

Sean Nash

Why do some functions take sensor as a U32 and some as a CONDUCTIVITY_SENSORS_T? The latter seems appropriate.

Why do some functions take sensor as a U32 and some as a CONDUCTIVITY_SENSORS_T? The latter seems appropriate.

12:24 pm

Sean Nash

Remove blank line.

Remove blank line.

12:24 pm

Sean Nash

Remove blank line.

Remove blank line.

12:23 pm

Sean Nash

Add blank line before return.

Add blank line before return.

12:22 pm

Sean Nash

Add blank line before return.

Add blank line before return.

12:19 pm

Sean Nash

Remove blank line.

Remove blank line.

10:39 am

Raghu Kallala

From what I see in UI, it is just a range value not an enum/index

From what I see in UI, it is just a range value not an enum/index

Monday 06 Apr
2:12 pm

Vinayakam Mani

2:12 pm

Sean Nash

1:37 pm

Sean Nash

Is it an enum/index like Denali then?

Is it an enum/index like Denali then?

1:06 pm

Raghu Kallala

12:43 pm

Raghu Kallala

No we are not getting conv factor from UI on it I will have to confirm with Nick to see if we will get the bicarbConvFactor

No we are not getting conv factor from UI on it
I will have to confirm with Nick to see if we will get the bicarbConvFactor

11:52 am

Vendor - TEL - Jashwant Gantyada

11:01 am

Michael Garthwaite

11:01 am

Sean Nash

Align comments.

Align comments.