leahi-fwcommon

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
LDT-3735: Pulled staging

LDT-3735: Addressed review comments

Merge branch 'staging' into LDT-4011-isolated-uf-dd---fw-implementat

I would keep blank line between library includes and regular includes.

I would keep blank line between library includes and regular includes.

We can't have 2 alarms with ID 196. The enum only has the empty saline bag alarm. Looks like alarm 197 is duplicate of this 196 alarm you've added. I think you should just remove this new alarm 196...

We can't have 2 alarms with ID 196. The enum only has the empty saline bag alarm. Looks like alarm 197 is duplicate of this 196 alarm you've added.
I think you should just remove this new alarm 196 that you've added here.

Fix merge conflict stuff here.

Fix merge conflict stuff here.

Fix merge conflict stuff here.

Fix merge conflict stuff here.

Fixed merge conflicts.

LDT-4873: Added new test config to disable alarm 71 when chamber H is empty.

LEAHI-DD-FIRMWARE-LDT-4873_(Request) Add config to disable conductive level sensor fault
LEAHI-DD-FIRMWARE-LDT-4873_(Request) Add config to disable conductive level sensor fault
LDT-3735: Updated initNVMgmt

please remove extra line

please remove extra line

Output is none

Output is none

Please add message id.

Please add message id.

Output is none

Output is none

Message id MSG_ID_OFF_BUTTON_PRESS_REQUEST looks wrong

Message id MSG_ID_OFF_BUTTON_PRESS_REQUEST looks wrong

Can we restore this code?

Can we restore this code?

Remove FANS test.

Remove FANS test.

Remove.

Remove.

Move this to Messaging.c

Move this to Messaging.c

Remove. Replaced by generic confirmation functions and messages.

Remove. Replaced by generic confirmation functions and messages.

Remove this function - replaced by generic confirmation functions.

Remove this function - replaced by generic confirmation functions.

Remove this timer code and replace with getConfirmationRequestStatus() and, if status is Accepted, do confirmation code above. If status is Rejected or TimedOut, clear offRequestAwaitingUserConfirm...

Remove this timer code and replace with getConfirmationRequestStatus() and, if status is Accepted, do confirmation code above. If status is Rejected or TimedOut, clear offRequestAwaitingUserConfirmation flag.

Replace with request code above.

Replace with request code above.

Remove this function after you've moved what we need.

Remove this function after you've moved what we need.