td-firmware

Clone Tools

Stats

Commits this week: 57
Total Committers: 13
Last Commit: 24 Feb
Commits this week: 57

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 24 Feb
2:47 pm

Sean Nash

10:01 am

Sean Nash

I don't see why we need the extra precision here. I suspect a 64-bit division is expensive (s/w library implementation instead of co-processor) so I don't like to use doubles unless it is truly nec...

I don't see why we need the extra precision here. I suspect a 64-bit division is expensive (s/w library implementation instead of co-processor) so I don't like to use doubles unless it is truly necessary.

9:59 am

Sean Nash

Add blank line before return.

Add blank line before return.

9:58 am

Sean Nash

0.0F

0.0F

9:58 am

Sean Nash

Use "F64" macro instead of double.

Use "F64" macro instead of double.

9:48 am

Vendor - TEL - Sameer Poyil

Yes , right now its void , so that's why i didn't change that . I will push new code

Yes , right now its void , so that's why i didn't change that . I will push new code

9:30 am

Sean Nash

setAirPumpState could return a BOOL (FALSE if range check fails or state invalid) that you can set result to.

setAirPumpState could return a BOOL (FALSE if range check fails or state invalid) that you can set result to.

9:24 am

Sean Nash

Inputs is none or FPGA.

Inputs is none or FPGA.

8:15 am

Vendor - TEL - Sameer Poyil

done

done

8:14 am

Vendor - TEL - Sameer Poyil

done , but I need to check it here

done , but I need to check it here

8:14 am

Vendor - TEL - Sameer Poyil

done

done

Monday 23 Feb
6:18 pm

Vendor - TEL - Sameer Poyil

Yes, without checking the changes in this file, I pushed it. It is OK when I merge the code. There is no option to correct since my local branch shows 28.its auto generated and it will take next ve...

Yes, without checking the changes in this file, I pushed it. It is OK when I merge the code. There is no option to correct since my local branch shows 28.its auto generated and it will take next version during the merge with staging.

6:08 pm

Vendor - TEL - Sameer Poyil

If I don't check it here, Dialin get a true for even invalid range. I need to pass the result immediately to user so that user can take the action.

If I don't check it here, Dialin get a true for even invalid range. I need to pass the result immediately to user so that user can take the action.

1:04 pm

Sean Nash

Add spaces inside of ().

Add spaces inside of ().

1:03 pm

Sean Nash

Stop button is a "hard" pause which would take us to Treatment: Paused state (out of blood prime completely). We want to go to our internal paused state when UI sends us a "soft" blood prime pause ...

Stop button is a "hard" pause which would take us to Treatment: Paused state (out of blood prime completely).
We want to go to our internal paused state when UI sends us a "soft" blood prime pause commands message.

1:01 pm

Sean Nash

Remove blank line.

Remove blank line.

1:00 pm

Sean Nash

Should we add this test config? Systems team will likely want it eventually since they wanted it in Denali.

Should we add this test config? Systems team will likely want it eventually since they wanted it in Denali.

12:56 pm

Sean Nash

Put each condition in (). Also, should the setAirPumpState function be checking power is in range instead of here?

Put each condition in ().
Also, should the setAirPumpState function be checking power is in range instead of here?

12:53 pm

Sean Nash

You have these MIN/MAX definitions in both this unit and AirPump unit. Can we put these in header file for this unit and remove from AirPump unit?

You have these MIN/MAX definitions in both this unit and AirPump unit. Can we put these in header file for this unit and remove from AirPump unit?

12:52 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

12:50 pm

Vendor - TEL - Varshini Nagabooshanam

Removed

Removed

12:50 pm

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

12:50 pm

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

12:50 pm

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

12:50 pm

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

12:49 pm

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

12:49 pm

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

12:49 pm

Vendor - TEL - Varshini Nagabooshanam

I will Update as per Raghu treatment parameter

I will Update as per Raghu treatment parameter

12:47 pm

Sean Nash

This looks like develop branch got merged into your branch. We should not be doing that. Always merge your branch to develop in that direction only.

This looks like develop branch got merged into your branch. We should not be doing that. Always merge your branch to develop in that direction only.

Saturday 21 Feb
7:10 pm

Vendor - TEL - Sameer Poyil

capital F

capital F