Activity td-firmware/

Tree
Accordion

Stats

Commits this week: 38

Total Committers:	16
Last Commit:	01 Jun
Commits this week:	38

Lines of code count not available

Commit Activity

last updated a few seconds ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

Start Date:

End Date:

End Date:

Monday 01 Jun

7:53 pm

Vendor - TEL - Varshini Nagabooshanam

More
29b0218
changed 2 files
LDT-4033-patient-vitals-fw-implementation LEAHI-TD-FIRMWARE-LDT-4033-1

LDT-4033-patient-vitals-fw-implementation

- -3
- +3
/firmware/App/Controllers/BPModule.c
- History
- Source
- Diff
/firmware/App/Controllers/BPModule.c
- -3
- +3
/firmware/App/Drivers/BPDriver.h
- History
- Source
- Diff
/firmware/App/Drivers/BPDriver.h

7:09 pm

Dara Navaei

More
7cd00b1
changed 1 file
develop

Bamboo Commit: Updated TDCommon.h with build versions from Bamboo.

- -1
- +1
/firmware/App/TDCommon.h
- History
- Source
- Diff
/firmware/App/TDCommon.h

7:08 pm

Vendor - TEL - Varshini Nagabooshanam

More
68d0f04
changed 1 file
develop

Fixes

- -1
- +1
/firmware/App/Controllers/AirPump.c
- History
- Source
- Diff
/firmware/App/Controllers/AirPump.c

7:02 pm

Vendor - TEL - Varshini Nagabooshanam

More
LEAHI-TD-FIRMWARE-LDT-3215-1
started review

LEAHI-TD-FIRMWARE-LDT-3215_Measured venous pressure decreases to atmosphere if H12 air pump is dead headed

LEAHI-TD-FIRMWARE-LDT-3215_Measured venous pressure decreases to atmosphere if H12 air pump is dead headed

7:01 pm

Vendor - TEL - Varshini Nagabooshanam

More
d4f6840
changed 1 file
LDT-3215-measured-venous-pressure-decreases, develop LEAHI-TD-FIRMWARE-LDT-3215-1

LDT-3215-measured-venous-pressure-decreases

- -2
- +0
/firmware/App/Controllers/AirPump.c
- History
- Source
- Diff
/firmware/App/Controllers/AirPump.c

6:14 pm

Vendor - TEL - Varshini Nagabooshanam

More
3afb9f7
changed 2 files
LDT-2240-disposable-tube-set-self-test LEAHI-TD-FIRMWARE-LDT-2240-1

Fixes

- -1
- +1
/firmware/App/Services/Messaging.c
- History
- Source
- Diff
/firmware/App/Services/Messaging.c
- -2
- +3
/firmware/App/Services/StateServices/DrySelfTests.c
- History
- Source
- Diff
/firmware/App/.../DrySelfTests.c

4:34 pm

Vinayakam Mani

More
Re: LEAHI-TD-FIRMWARE-LDT-4009-1
commented on review

Maintain alphabetical order.

Maintain alphabetical order.

4:02 pm

Sean Nash

Eliza says we do allow multiple iso UF sessions in a treatment. So do we still need this else if, but looking at <= iso UF elapsed session time?

Eliza says we do allow multiple iso UF sessions in a treatment. So do we still need this else if, but looking at <= iso UF elapsed session time?

3:56 pm

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-4009-1
commented on review

What about HDF?

What about HDF?

2:34 pm

Vendor - TEL - Jashwant Gantyada

Once UI software sends the volume and/or duration change request and once we change them, the UI software will send another request to confirm the displayed settings to the user and that is what is...

Once UI software sends the volume and/or duration change request and once we change them, the UI software will send another request to confirm the displayed settings to the user and that is what is being handled in this function.

1:54 pm

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-4009-1
commented on review

return result;

return result;

1:53 pm

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-4009-1
commented on review

Keep local result and set to TRUE or FALSE with a ternary.

Keep local result and set to TRUE or FALSE with a ternary.

1:50 pm

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-4009-1
commented on review

Which setting does this message confirm (duration or volume)?

Which setting does this message confirm (duration or volume)?

11:59 am

Vendor - TEL - Jashwant Gantyada

More
96604b7
changed 7 files
LDT-4009-isolated-uf-td LEAHI-TD-FIRMWARE-LDT-4009-1

LDT-4009 addreessed code review comments

- -42
- +64
/firmware/App/Modes/ModeTreatment.c
- History
- Source
- Diff
/firmware/App/Modes/ModeTreatment.c
- -1
- +3
/firmware/App/Modes/ModeTreatment.h
- History
- Source
- Diff
/firmware/App/Modes/ModeTreatment.h
- -1
- +16
/firmware/App/Modes/StateTxIsolatedUF.c
- History
- Source
- Diff
/firmware/App/Modes/StateTxIsolatedUF.c
- -5
- +6
/firmware/App/Modes/StateTxIsolatedUF.h
- History
- Source
- Diff
/firmware/App/Modes/StateTxIsolatedUF.h
- -10
- +10
/firmware/App/Services/Messaging.h
- History
- Source
- Diff
/firmware/App/Services/Messaging.h
- -83
- +109
/firmware/App/Services/TxParams.c
- History
- Source
- Diff
/firmware/App/Services/TxParams.c
- -0
- +2
/firmware/App/Services/TxParams.h
- History
- Source
- Diff
/firmware/App/Services/TxParams.h

11:02 am

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-4009-1
commented on review

Align comment.

Align comment.

10:28 am

Vendor - TEL - Jashwant Gantyada

More
Re: LEAHI-TD-FIRMWARE-LDT-4013-1
commented on review

where are we calling an alarm? i think we are only sending event change data in completeBolusToCumulative() right?

where are we calling an alarm?
i think we are only sending event change data in completeBolusToCumulative() right?

10:25 am

Vendor - TEL - Jashwant Gantyada

More
Re: LEAHI-TD-FIRMWARE-LDT-4013-1
commented on review

do we need this block?

do we need this block?

10:09 am

Vinayakam Mani

More
Re: LEAHI-TD-FIRMWARE-LDT-4013-1
commented on review

update the comment as required: ml or L?

update the comment as required: ml or L?

10:00 am

Sean Nash

10:00 am

Sean Nash

More
LEAHI-TD-FIRMWARE-LDT-4013-1
removed Behrouz NematiPour , Nicholas Ramirez and 3 others

9:22 am

Sean Nash

More
LEAHI-TD-FIRMWARE-LDT-4013-1
finished reviewing

Saturday 30 May

12:26 pm

suresh

More
2e75c0c
changed 3 files
LDT-4072-power-loss---fw-implementation- LEAHI-TD-FIRMWARE-LDT-4072-2

LDT-4072: addressed review comments

- -9
- +16
/firmware/App/Drivers/BatteryDriver.c
- History
- Source
- Diff
/firmware/App/Drivers/BatteryDriver.c
- -3
- +3
/firmware/App/Drivers/BatteryDriver.h
- History
- Source
- Diff
/firmware/App/Drivers/BatteryDriver.h
- -9
- +22
/firmware/App/Monitors/Battery.c
- History
- Source
- Diff
/firmware/App/Monitors/Battery.c

Friday 29 May

3:25 pm

Dara Navaei

More
99ff711
changed 1 file
LDT-4027-pre-treatment---fw-implementation, staging

Bamboo Commit: Updated TDCommon.h with build versions from Bamboo.

- -1
- +1
/firmware/App/TDCommon.h
- History
- Source
- Diff
/firmware/App/TDCommon.h

3:24 pm

Dara Navaei

More
a12f3ce
changed 9 files
LDT-4027-pre-treatment---fw-implementation, staging

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -2
- +2
/firmware/App/Modes/ModePreTreat.c
- History
- Source
- Diff
/firmware/App/Modes/ModePreTreat.c
- -2
- +2
/firmware/App/Modes/ModeTreatment.c
- History
- Source
- Diff
/firmware/App/Modes/ModeTreatment.c
- -2
- +2
/firmware/App/Modes/ModeTreatment.h
- History
- Source
- Diff
/firmware/App/Modes/ModeTreatment.h
- -2
- +2
/firmware/App/Monitors/Pressures.c
- History
- Source
- Diff
/firmware/App/Monitors/Pressures.c
- -2
- +2
/firmware/App/Monitors/Pressures.h
- History
- Source
- Diff
/firmware/App/Monitors/Pressures.h
- -2
- +2
/firmware/App/Services/Messaging.c
- History
- Source
- Diff
/firmware/App/Services/Messaging.c
- -2
- +2
/firmware/App/Services/Messaging.h
- History
- Source
- Diff
/firmware/App/Services/Messaging.h
- -2
- +2
/firmware/App/Services/TxParams.c
- History
- Source
- Diff
/firmware/App/Services/TxParams.c
- -2
- +2
/firmware/App/Services/TxParams.h
- History
- Source
- Diff
/firmware/App/Services/TxParams.h

2:57 pm

Sean Nash and Vendor - TEL - Arpita Srivastava

More
LEAHI-TD-FIRMWARE-LDT-3970-1
finished reviewing

2:43 pm

Vendor - TEL - Praneeth Bunne

More
83163b2
changed 3 files
LDT-4013-fluid-bolus LEAHI-TD-FIRMWARE-LDT-4013-1

LDT-4013: Address CR comments

- -9
- +17
/firmware/App/Modes/StateTxDialysis.c
- History
- Source
- Diff
/firmware/App/Modes/StateTxDialysis.c
- -6
- +8
/firmware/App/Modes/StateTxPaused.c
- History
- Source
- Diff
/firmware/App/Modes/StateTxPaused.c
- -2
- +2
/firmware/App/Services/FluidBolus.c
- History
- Source
- Diff
/firmware/App/Services/FluidBolus.c

2:43 pm

Vendor - TEL - Vijay Pamula

More
15f43f3
changed 1 file
LDT-3970-edit-treatment-parameters-during-treatment, LDT-4027-pre-treatment---fw-implementation, staging LEAHI-TD-FIRMWARE-LDT-3970-1

LDT-3970: Addressed review comments for edit treatment parameters

- -1
- +1
/firmware/App/Monitors/Pressures.c
- History
- Source
- Diff
/firmware/App/Monitors/Pressures.c

2:33 pm

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-3970-1
commented on review

Please add the min and max for tmp as well in the outputs.

Please add the min and max for tmp as well in the outputs.

2:25 pm

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-4013-1
commented on review

rejReason = INVALID REQUEST FORMAT

rejReason = INVALID REQUEST FORMAT

12:11 pm

Vendor - TEL - Vijay Pamula

More
4a822b3
changed 3 files
LDT-3970-edit-treatment-parameters-during-treatment, LDT-4027-pre-treatment---fw-implementation, staging LEAHI-TD-FIRMWARE-LDT-3970-1

LDT-3970: Merge latest staging and Addressed Review comments

- -0
- +1
/firmware/App/Services/Messaging.c
- History
- Source
- Diff
/firmware/App/Services/Messaging.c
- -0
- +1
/firmware/App/Services/Messaging.h
- History
- Source
- Diff
/firmware/App/Services/Messaging.h
- -2
- +10
/firmware/App/Services/TxParams.c
- History
- Source
- Diff
/firmware/App/Services/TxParams.c

Atlassian Fisheye Git analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2026-06-02 02:45 -0700