td-firmware / firmware

App

Clone Tools

Stats

Commits this week: 79
Total Committers: 17
Last Commit: 05 Aug
Commits this week: 79

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 04 Aug
1:31 pm

suresh

Addressed review comments

Options
    • -3
    • +3
    ./Drivers/BatteryDriver.c
    • -1
    • +1
    ./Drivers/BatteryDriver.h
    • -7
    • +7
    ./Monitors/Battery.c
1:14 pm

Vendor - TEL - Praneeth Bunne

initialized using resetRinsebackFlags()

initialized using resetRinsebackFlags()

1:03 pm

Vendor - TEL - Praneeth Bunne

those are initialized in resetTreatmentRecircFlags() and that is called in init

those are initialized in resetTreatmentRecircFlags() and that is called in init

11:34 am

Dara Navaei

LEAHI-TD-FIRMWARE-LDT-5358_Pre-Treatment - FW Implementation - 10/6:
LEAHI-TD-FIRMWARE-LDT-5358_Pre-Treatment - FW Implementation - 10/6:
11:16 am

Vendor - TEL - Arpita Srivastava

align comment

align comment

11:11 am

suresh

LDT-4063: Addressed review comments

Options
    • -1
    • +3
    ./Modes/OperationModes.c
    • -2
    • +4
    ./Services/Messaging.c
11:10 am

Vendor - TEL - Arpita Srivastava

Can we please break this line as to match our standard of 100 columns? SET_ALARM_WITH_2_U32_DATA( ALARM_ID_TD_AIR_PUMP_STALL, currentAirPumpPowerLevel, getU32OverrideValue( &currentAirPumpRPM ) );

Can we please break this line as to match our standard of 100 columns?

SET_ALARM_WITH_2_U32_DATA( ALARM_ID_TD_AIR_PUMP_STALL,
currentAirPumpPowerLevel,
getU32OverrideValue( &currentAirPumpRPM ) );

11:02 am

Vendor - TEL - Varshini Nagabooshanam

Merge conflicts

Options
    • -4
    • +4
    ./Modes/ModeTreatment.c
    • -5
    • +7
    ./Services/AlarmMgmtSWFaults.h
    • -11
    • +22
    ./Services/FpgaTD.c
    • -1
    • +3
    ./Services/Messaging.c
11:02 am

Vendor - TEL - Arpita Srivastava

10:52 am

Vendor - TEL - Arpita Srivastava

use FALSE

use FALSE

10:52 am

Vendor - TEL - Arpita Srivastava

use FALSE

use FALSE

10:39 am

Vendor - TEL - Arpita Srivastava

It looks like the rows may be misaligned with the alarm ID declarations. For example, ALARM_ID_TD_BATTERY_CHARGER_ERROR_DETECTED is declared as 204.

It looks like the rows may be misaligned with the alarm ID declarations.
For example, ALARM_ID_TD_BATTERY_CHARGER_ERROR_DETECTED is declared as 204.

10:22 am

Vendor - TEL - Varshini Nagabooshanam

Changes

Options
    • -9
    • +6
    ./Controllers/Valves.c
    • -48
    • +42
    ./Drivers/PinchValve.c
    • -1
    • +1
    ./Drivers/PinchValve.h
    • -1
    • +0
    ./Modes/ModeStandby.c
10:13 am

Vendor - TEL - Arpita Srivastava

When we send any message to UI, usually add the message id in the doxygen header like this. @details \b Message \b Sent: MSG_ID_TD_RESP_TREATMENT_PARAMS_TO_VALIDATE Please refer to the function s...

When we send any message to UI, usually add the message id in the doxygen header like this.

@details \b Message \b Sent: MSG_ID_TD_RESP_TREATMENT_PARAMS_TO_VALIDATE

Please refer to the function sendTreatmentParamsResponse()

10:05 am

Vendor - TEL - Arpita Srivastava

When we send any message to UI, usually add the message id in the doxygen header like this. *@details \b Message \b Sent: MSG_ID_TD_RESP_TREATMENT_PARAMS_TO_VALIDATE Please refer to the functi...

When we send any message to UI, usually add the message id in the doxygen header like this.

  • @details \b Message \b Sent: MSG_ID_TD_RESP_TREATMENT_PARAMS_TO_VALIDATE


Please refer to the function sendTreatmentParamsResponse()

10:05 am

Vendor - TEL - Arpita Srivastava

When we send any message to UI, usually add the message id in the doxygen header like this. *@details \b Message \b Sent: MSG_ID_TD_RESP_TREATMENT_PARAMS_TO_VALIDATE Please refer to the functi...

When we send any message to UI, usually add the message id in the doxygen header like this.

  • @details \b Message \b Sent: MSG_ID_TD_RESP_TREATMENT_PARAMS_TO_VALIDATE


Please refer to the function sendTreatmentParamsResponse()

9:55 am

Vendor - TEL - Arpita Srivastava

It looks like the rows may be misaligned with the alarm ID declarations. For example, ALARM_ID_TD_SAFETY_SHUTDOWN_POST_TEST_FAILED is declared as 207.

It looks like the rows may be misaligned with the alarm ID declarations.
For example, ALARM_ID_TD_SAFETY_SHUTDOWN_POST_TEST_FAILED is declared as 207.

9:53 am

Vendor - TEL - Arpita Srivastava

Should Instructions part be this? A problem was detected with the hemodialysis device.

Should Instructions part be this?

A problem was detected with the hemodialysis device.

9:50 am

Vendor - TEL - Arpita Srivastava

Please confirm if the source is DD?

Please confirm if the source is DD?

Monday 03 Aug
3:35 pm

Vendor - TEL - Varshini Nagabooshanam

Merge branch 'staging' of bitbucket.org:diality-cloud/td-firmware into LDT-4149-pinch-valves-fw-implementation

Options
    • -1
    • +1
    ./TDCommon.h
3:32 pm

Dara Navaei

Bamboo Commit: Updated TDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./TDCommon.h
3:32 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./Monitors/Pressures.c
3:30 pm

Vendor - TEL - Varshini Nagabooshanam

3:27 pm

Vendor - TEL - Arpita Srivastava and Sean Nash

3:01 pm

suresh

LDT-4063: Addressed review comments

Options
    • -1
    • +1
    ./Modes/ModeInitPOST.c
2:31 pm

suresh

LDT-4063: Addressed review comments

Options
    • -78
    • +61
    ./Modes/ModeInitPOST.c
    • -9
    • +18
    ./Modes/OperationModes.c
    • -3
    • +2
    ./Monitors/Buttons.c
    • -1
    • +1
    ./Services/CpldInterface.c
    • -4
    • +4
    ./Services/Messaging.c
    • -1
    • +1
    ./Services/Messaging.h
    • -1
    • +0
    ./Services/SystemCommTD.c
    • -1
    • +0
    ./Services/SystemCommTD.h
2:06 pm

suresh

LDT-4072: Addressed review comments

Options
    • -10
    • +17
    ./Drivers/BatteryDriver.c
    • -6
    • +7
    ./Drivers/BatteryDriver.h
    • -54
    • +85
    ./Monitors/Battery.c
    • -3
    • +3
    ./Monitors/Battery.h
1:55 pm

Dara Navaei

Bamboo Commit: Updated TDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./TDCommon.h
1:55 pm

Vendor - TEL - Varshini Nagabooshanam

Merge branch 'staging' of bitbucket.org:diality-cloud/td-firmware into LDT-4149-pinch-valves-fw-implementation

Options
    • -2
    • +2
    ./Services/FpgaTD.c
    • -1
    • +1
    ./TDCommon.h
1:51 pm

Vendor - TEL - Varshini Nagabooshanam

Merge branch 'LDT-4094-pressures-monitoring-fw-iteration' into develop

Options
    • -8
    • +8
    ./Monitors/Pressures.c