td-firmware

firmware

Clone Tools

Stats

Commits this week: 81
Total Committers: 17
Last Commit: 05 Aug
Commits this week: 81

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 05 Aug
1:21 pm

suresh

LDT-4072:Update battery monitoring enum indexing and validate charger data

Options
    • -1
    • +0
    ./App/Drivers/BatteryDriver.c
    • -2
    • +2
    ./App/Drivers/BatteryDriver.h
    • -4
    • +7
    ./App/Monitors/Battery.c
12:56 pm

Vendor - TEL - Arpita Srivastava and Sean Nash

12:45 pm

Sean Nash

What if we're in paused state (because your alarm has stop property set)? Should we return TRUE here if in paused state and interrupted state was the await syringe load confirmation state?

What if we're in paused state (because your alarm has stop property set)? Should we return TRUE here if in paused state and interrupted state was the await syringe load confirmation state?

12:40 pm

Sean Nash

Right now, the load syringe alarm indicates stop so we will go to paused state. Is that what we want to do? Don't we want to stay in this state and wait for confirmation?

Right now, the load syringe alarm indicates stop so we will go to paused state. Is that what we want to do? Don't we want to stay in this state and wait for confirmation?

12:37 pm

Sean Nash

Should this alarm have stop property set to FALSE?

Should this alarm have stop property set to FALSE?

9:58 am

Vendor - TEL - Varshini Nagabooshanam

Merge branch 'staging' of bitbucket.org:diality-cloud/td-firmware into LDT-4149-pinch-valves-fw-implementation

Options
    • -1
    • +1
    ./App/TDCommon.h
9:51 am

Vendor - TEL - Vijay Pamula

LDT-4029:Updated heparin setup state

Options
    • -4
    • +5
    ./App/Modes/StatePreTxHeparinSetup.c
9:31 am

Dara Navaei

Bamboo Commit: Updated TDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./App/TDCommon.h
9:23 am

Dara Navaei

Bamboo Commit: Updated TDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./App/TDCommon.h
Tuesday 04 Aug
2:16 pm

Vendor - TEL - Jashwant Gantyada

updated

updated

2:16 pm

Vendor - TEL - Jashwant Gantyada

updated

updated

2:15 pm

Vendor - TEL - Jashwant Gantyada

updated.

updated.

2:15 pm

Vendor - TEL - Jashwant Gantyada

updated

updated

2:14 pm

Vendor - TEL - Jashwant Gantyada

removed.

removed.

2:13 pm

Vendor - TEL - Praneeth Bunne

LDT-4040: Resolve CR comments, merge latest staging & resolve merge conflicts

Options
    • -17
    • +14
    ./App/Modes/ModeTreatment.c
    • -3
    • +3
    ./App/Modes/StateTxBloodPrime.c
    • -17
    • +30
    ./App/Modes/StateTxPaused.c
    • -5
    • +17
    ./App/Modes/StateTxRecirc.c
    • -39
    • +65
    ./App/Modes/StateTxRinseback.c
    • -11
    • +11
    ./App/Monitors/Pressures.c
    • -3
    • +6
    ./App/Services/AlarmMgmtSWFaults.h
    • -3
    • +58
    ./App/Services/AlarmMgmtTD.c
    • -2
    • +3
    ./App/Services/AlarmMgmtTD.h
    • -3
    • +8
    ./App/Services/Messaging.c
    • -179
    • +71
    ./App/Services/StateServices/FluidBolus.c
    • -13
    • +22
    ./App/Services/TxParams.c
1:52 pm

Vendor - TEL - Jashwant Gantyada

LDT-4009 addressed code review comments

Options
    • -1
    • +0
    ./App/Modes/ModeTreatment.c
    • -1
    • +1
    ./App/Modes/StateTxIsolatedUF.c
    • -1
    • +5
    ./App/Services/TxParams.c
1:31 pm

suresh

Addressed review comments

Options
    • -3
    • +3
    ./App/Drivers/BatteryDriver.c
    • -1
    • +1
    ./App/Drivers/BatteryDriver.h
    • -7
    • +7
    ./App/Monitors/Battery.c
1:14 pm

Vendor - TEL - Praneeth Bunne

initialized using resetRinsebackFlags()

initialized using resetRinsebackFlags()

1:03 pm

Vendor - TEL - Praneeth Bunne

those are initialized in resetTreatmentRecircFlags() and that is called in init

those are initialized in resetTreatmentRecircFlags() and that is called in init

11:34 am

Dara Navaei

LEAHI-TD-FIRMWARE-LDT-5358_Pre-Treatment - FW Implementation - 10/6:
LEAHI-TD-FIRMWARE-LDT-5358_Pre-Treatment - FW Implementation - 10/6:
11:16 am

Vendor - TEL - Arpita Srivastava

align comment

align comment

11:11 am

suresh

LDT-4063: Addressed review comments

Options
    • -1
    • +3
    ./App/Modes/OperationModes.c
    • -2
    • +4
    ./App/Services/Messaging.c
11:10 am

Vendor - TEL - Arpita Srivastava

Can we please break this line as to match our standard of 100 columns? SET_ALARM_WITH_2_U32_DATA( ALARM_ID_TD_AIR_PUMP_STALL, currentAirPumpPowerLevel, getU32OverrideValue( &currentAirPumpRPM ) );

Can we please break this line as to match our standard of 100 columns?

SET_ALARM_WITH_2_U32_DATA( ALARM_ID_TD_AIR_PUMP_STALL,
currentAirPumpPowerLevel,
getU32OverrideValue( &currentAirPumpRPM ) );

11:02 am

Vendor - TEL - Varshini Nagabooshanam

Merge conflicts

Options
    • -4
    • +4
    ./App/Modes/ModeTreatment.c
    • -5
    • +7
    ./App/Services/AlarmMgmtSWFaults.h
    • -11
    • +22
    ./App/Services/FpgaTD.c
    • -1
    • +3
    ./App/Services/Messaging.c
11:02 am

Vendor - TEL - Arpita Srivastava

10:52 am

Vendor - TEL - Arpita Srivastava

use FALSE

use FALSE

10:52 am

Vendor - TEL - Arpita Srivastava

use FALSE

use FALSE

10:39 am

Vendor - TEL - Arpita Srivastava

It looks like the rows may be misaligned with the alarm ID declarations. For example, ALARM_ID_TD_BATTERY_CHARGER_ERROR_DETECTED is declared as 204.

It looks like the rows may be misaligned with the alarm ID declarations.
For example, ALARM_ID_TD_BATTERY_CHARGER_ERROR_DETECTED is declared as 204.

10:22 am

Vendor - TEL - Varshini Nagabooshanam

Changes

Options
    • -9
    • +6
    ./App/Controllers/Valves.c
    • -48
    • +42
    ./App/Drivers/PinchValve.c
    • -1
    • +1
    ./App/Drivers/PinchValve.h
    • -1
    • +0
    ./App/Modes/ModeStandby.c
10:13 am

Vendor - TEL - Arpita Srivastava

When we send any message to UI, usually add the message id in the doxygen header like this. @details \b Message \b Sent: MSG_ID_TD_RESP_TREATMENT_PARAMS_TO_VALIDATE Please refer to the function s...

When we send any message to UI, usually add the message id in the doxygen header like this.

@details \b Message \b Sent: MSG_ID_TD_RESP_TREATMENT_PARAMS_TO_VALIDATE

Please refer to the function sendTreatmentParamsResponse()