control interval is different. Control interval must be separated else we don't get finer control on bicarb conductivity. also the dead band is different. need to figure out whether we can combine or not

This code looks very similar to bicarb code above. Do we really need separate handling?

Remove extra blank line.

Add unit of measure to definition name (e.g. _PSI). Should be done for all definitions w/ a unit of measure to prevent unit errors.

· /firmware/App/Controllers/BalancingChamber.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/ConcentratePumps.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/DryBiCart.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/DryBiCart.h	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Monitors/Conductivity.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Monitors/Level.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/FpgaDD.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/Messaging.c	(-2, +2)	| History	| Source	| Diff

]]> Thu, 16 Apr 2026 16:13:36 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/changelog/dd-firmware?cs=3d0c86bab8540914d9f3cfdbdd321f35db623999 https://devapps.diality.us/changelog/dd-firmware?cs=3d0c86bab8540914d9f3cfdbdd321f35db623999 Vendor - TEL - Sameer Poyil committed 3d0c86b on branch LDT-2004-dialysate-composition-dosing-control--dd, LDT-3749-ability-to-set-operation-sub-mode-latest and 8 more in dd-firmware LDT-2004 merging staging branch to LDT-2004-dialysate-composition-dosing-control--dd

· /firmware/App/Controllers/BalancingChamber.c	(-6, +6)	| History	| Source	| Diff
· /firmware/App/Controllers/DryBiCart.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Monitors/Conductivity.c	(-54, +148)	| History	| Source	| Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h	(-5, +7)	| History	| Source	| Diff
· /firmware/App/Services/FpgaDD.c	(-1180, +390)	| History	| Source	| Diff
· /firmware/App/Services/Messaging.c	(-19, +14)	| History	| Source	| Diff

]]> Thu, 16 Apr 2026 14:55:45 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/changelog/dd-firmware?cs=4412385100d2ed1a053234f7e5b8c31107683e1c https://devapps.diality.us/changelog/dd-firmware?cs=4412385100d2ed1a053234f7e5b8c31107683e1c Vendor - TEL - Sameer Poyil committed 4412385 on branch LDT-2004-dialysate-composition-dosing-control--dd, LDT-3749-ability-to-set-operation-sub-mode-latest and 8 more in dd-firmware LDT-2004 addressed review comments

· /firmware/App/Controllers/DryBiCart.c

(-5, +0)

| History

| Source

| Diff

]]> Thu, 16 Apr 2026 14:42:50 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/changelog/dd-firmware?cs=170255f14e4d105bb4f443f2a84e069955286243 https://devapps.diality.us/changelog/dd-firmware?cs=170255f14e4d105bb4f443f2a84e069955286243 Vendor - TEL - Sameer Poyil committed 170255f on branch LDT-2004-dialysate-composition-dosing-control--dd, LDT-3749-ability-to-set-operation-sub-mode-latest and 8 more in dd-firmware LDT-2004 adressed review comments

· /firmware/App/Controllers/DryBiCart.c

(-16, +9)

| History

| Source

| Diff

]]> Thu, 16 Apr 2026 14:28:01 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28452 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28452 Vendor - TEL - Sameer Poyil replied to Vinayakam Mani in LEAHI-DD-FIRMWARE-LDT-2004-9

Its static function and not used by external API to pass the wrong id.

· /firmware/App/Controllers/ConcentratePumps.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/DryBiCart.c	(-107, +55)	| History	| Source	| Diff

]]> Wed, 15 Apr 2026 21:33:44 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28433 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28433 Vendor - TEL - Sameer Poyil replied to Vinayakam Mani in LEAHI-DD-FIRMWARE-LDT-2004-9

0.0F is made by Sean.

Same comment applies here (removing resetPIController).

I think we can remove the balancing chamber fill in progress check for Opening D80 valve, as this does not impact the balancing chamber fill process.

Maintain space after and before parenthesis across the file.

Do we need to add another else statement and address an alarm if wrong mixId is passed? or Keep only else part instead of else if ( ACID_MIX_ID == mixID) check?? this change may be needed across the file.

Remove this comment.

You may use getF32OverrideValue for consistency (across the file).

The resetPIController is already invoked in InitializePIController with the InitialControlSignal. Instead of 0.0F, pass the STD_BICARB_DOSING as initialControlSignal ( in InitializePIController)

This is being repeated.

Please add comment. if it is not being used, delete it.

Can this be reused from ConcentratePumps.h?

Add a space after and before parenthesis.

This comment is same as previous lines comment, update something similar to 'Maximum pressure allowed at bicart fill during supply process/state"