Fisheye on dd-firmware/firmware/App/Monitors/Conductivity.c

dd-firmware (develop): LDT-4000: changed beta 2.0 test config to beta 1.9 test config

Michael Garthwaite — Thu, 30 Apr 2026 20:50:05 -0700

Michael Garthwaite committed f37bfe2 on branch LDT-4000-hdf-fw-implementation-1, develop in dd-firmware

LDT-4000: changed beta 2.0 test config to beta 1.9 test config

· /firmware/App/Controllers/Heaters.c	(-7, +7)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/RinsePump.c	(-11, +11)	\| History	\| Source	\| Diff
· /firmware/App/Monitors/Conductivity.c	(-4, +4)	\| History	\| Source	\| Diff
· /firmware/App/Monitors/Level.c	(-24, +22)	\| History	\| Source	\| Diff
· /firmware/App/Monitors/Temperature.c	(-12, +12)	\| History	\| Source	\| Diff
· /firmware/App/Services/FpgaDD.c	(-52, +32)	\| History	\| Source	\| Diff

dd-firmware (develop): LDT-4000: substitution pump implementation and fixes.

Michael Garthwaite — Thu, 30 Apr 2026 18:40:02 -0700

Michael Garthwaite committed 11fcfaf on branch LDT-4000-hdf-fw-implementation-1, develop in dd-firmware

LDT-4000: substitution pump implementation and fixes.

· /firmware/App/Controllers/SubstitutionPump.c	(-0, +554)	\| History	\| Source
· /firmware/App/Controllers/SubstitutionPump.h	(-0, +73)	\| History	\| Source
· /firmware/App/Drivers/ConductivitySensors.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Monitors/Conductivity.c	(-6, +0)	\| History	\| Source	\| Diff
· /firmware/App/Services/FpgaDD.c	(-1, +91)	\| History	\| Source	\| Diff
· /firmware/App/Services/FpgaDD.h	(-0, +4)	\| History	\| Source	\| Diff
· /firmware/App/Services/Messaging.c	(-0, +2)	\| History	\| Source	\| Diff
· /firmware/App/Tasks/TaskGeneral.c	(-0, +4)	\| History	\| Source	\| Diff
· /firmware/source/sys_main.c	(-0, +2)	\| History	\| Source	\| Diff

LEAHI-DD-FIRMWARE-LDT-3972-1: reviewers finished

Tue, 28 Apr 2026 09:20:33 -0700

Vendor - TEL - Arpita Srivastava finished reviewing LEAHI-DD-FIRMWARE-LDT-3972-1

LEAHI-DD-FIRMWARE-LDT-3972_Water Treatment and Degassing - FW Iteration - 1/4:

LEAHI-DD-FIRMWARE-LDT-4000-1: started by Dara Navaei

Dara Navaei — Mon, 27 Apr 2026 09:18:56 -0700

Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-4000-1

LEAHI-DD-FIRMWARE-LDT-3972-1: reviewers finished

Sun, 26 Apr 2026 12:45:03 -0700

Sean Nash finished reviewing LEAHI-DD-FIRMWARE-LDT-3972-1

LEAHI-DD-FIRMWARE-LDT-3972_Water Treatment and Degassing - FW Iteration - 1/4:

LEAHI-DD-FIRMWARE-LDT-3972-1: reviewers added to LEAHI-DD-FIRMWARE-LDT-3972_Water Treatment and Deg...

Sun, 26 Apr 2026 12:44:59 -0700

Sean Nash added Vendor - TEL - Arpita Srivastava and Vinayakam Mani to LEAHI-DD-FIRMWARE-LDT-3972-1

LEAHI-DD-FIRMWARE-LDT-3972_Water Treatment and Degassing - FW Iteration - 1/4:

LEAHI-DD-FIRMWARE-LDT-2004-9: closed by Vendor - TEL - Sameer Poyil

Vendor - TEL - Sameer Poyil — Mon, 20 Apr 2026 08:17:53 -0700

Vendor - TEL - Sameer Poyil Closed LEAHI-DD-FIRMWARE-LDT-2004-9

LEAHI-DD-FIRMWARE-LDT-3972-1: started by Dara Navaei

Dara Navaei — Fri, 17 Apr 2026 08:32:30 -0700

Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-3972-1

LEAHI-DD-FIRMWARE-LDT-2004-9: reviewers finished

Thu, 16 Apr 2026 23:17:41 -0700

Sean Nash and Vinayakam Mani finished reviewing LEAHI-DD-FIRMWARE-LDT-2004-9

LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD

LEAHI-DD-FIRMWARE-LDT-2004-9: started by Sean Nash

Sean Nash — Thu, 16 Apr 2026 23:13:27 -0700

Sean Nash started review LEAHI-DD-FIRMWARE-LDT-2004-9

LEAHI-DD-FIRMWARE-LDT-2004-9: started by Vendor - TEL - Sameer Poyil

Vendor - TEL - Sameer Poyil — Thu, 16 Apr 2026 16:23:22 -0700

Vendor - TEL - Sameer Poyil started review LEAHI-DD-FIRMWARE-LDT-2004-9

dd-firmware (LDT-3749-ability-to-set-operation-sub-mode-latest): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Thu, 16 Apr 2026 16:19:46 -0700

Dara Navaei committed fd897db on branch LDT-3272-software-update---dd-firmware, LDT-3749-ability-to-set-operation-sub-mode-latest and 14 more in dd-firmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/BalancingChamber.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ConcentratePumps.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DryBiCart.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DryBiCart.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Monitors/Conductivity.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Monitors/Level.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/FpgaDD.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/Messaging.c	(-2, +2)	\| History	\| Source	\| Diff

dd-firmware (LDT-3749-ability-to-set-operation-sub-mode-latest): LDT-2004 merging staging branch to LDT-2004-dialysate-composition-dosing-control--dd

Vendor - TEL - Sameer Poyil — Thu, 16 Apr 2026 16:13:36 -0700

Vendor - TEL - Sameer Poyil committed 3d0c86b on branch LDT-3272-software-update---dd-firmware, LDT-3749-ability-to-set-operation-sub-mode-latest and 14 more in dd-firmware

LDT-2004 merging staging branch to LDT-2004-dialysate-composition-dosing-control--dd

· /firmware/App/Controllers/BalancingChamber.c	(-6, +6)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DryBiCart.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Monitors/Conductivity.c	(-54, +148)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h	(-5, +7)	\| History	\| Source	\| Diff
· /firmware/App/Services/FpgaDD.c	(-1180, +390)	\| History	\| Source	\| Diff
· /firmware/App/Services/Messaging.c	(-19, +14)	\| History	\| Source	\| Diff

LEAHI-DD-FIRMWARE-LDT-2004-9: comment by Vendor - TEL - Sameer Poyil "Its static function and not used by external AP..."

Vendor - TEL - Sameer Poyil — Thu, 16 Apr 2026 14:28:01 -0700

Vendor - TEL - Sameer Poyil replied to Vinayakam Mani in LEAHI-DD-FIRMWARE-LDT-2004-9

Its static function and not used by external API to pass the wrong id.

dd-firmware (LDT-3749-ability-to-set-operation-sub-mode-latest): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Thu, 16 Apr 2026 14:08:03 -0700

Dara Navaei committed b6b17e4 on branch LDT-3272-software-update---dd-firmware, LDT-3749-ability-to-set-operation-sub-mode-latest and 14 more in dd-firmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Drivers/ConductivitySensors.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/ConductivitySensors.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Monitors/Conductivity.c	(-1, +1)	\| History	\| Source	\| Diff

LEAHI-DD-FIRMWARE-LDT-3777-1: closed by Michael Garthwaite

Michael Garthwaite — Thu, 16 Apr 2026 14:04:03 -0700

Michael Garthwaite Closed LEAHI-DD-FIRMWARE-LDT-3777-1

LEAHI-DD-FIRMWARE-LDT-3777-1: reviewers finished

Thu, 16 Apr 2026 09:11:41 -0700

Vendor - TEL - Jashwant Gantyada finished reviewing LEAHI-DD-FIRMWARE-LDT-3777-1

LEAHI-DD-FIRMWARE-LDT-3777_Sprint 25 fixes.

LEAHI-DD-FIRMWARE-LDT-2004-9: comment by Vendor - TEL - Sameer Poyil "0.0F is made by Sean."

Vendor - TEL - Sameer Poyil — Wed, 15 Apr 2026 21:33:44 -0700

Vendor - TEL - Sameer Poyil replied to Vinayakam Mani in LEAHI-DD-FIRMWARE-LDT-2004-9

0.0F is made by Sean.

LEAHI-DD-FIRMWARE-LDT-3777-1: reviewers finished

Wed, 15 Apr 2026 17:33:59 -0700

Sean Nash finished reviewing LEAHI-DD-FIRMWARE-LDT-3777-1

LEAHI-DD-FIRMWARE-LDT-3777_Sprint 25 fixes.

LEAHI-DD-FIRMWARE-LDT-3777-1: reviewers added to LEAHI-DD-FIRMWARE-LDT-3777_Sprint 25 fixes.

Wed, 15 Apr 2026 17:33:57 -0700

Sean Nash added Vinayakam Mani to LEAHI-DD-FIRMWARE-LDT-3777-1

LEAHI-DD-FIRMWARE-LDT-3777_Sprint 25 fixes.

dd-firmware (LDT-3749-ability-to-set-operation-sub-mode-latest): Merge branch 'staging' into LDT-3777-sprint-25-fixes

Michael Garthwaite — Wed, 15 Apr 2026 10:05:16 -0700

Michael Garthwaite committed 20d45b9 on branch LDT-3272-software-update---dd-firmware, LDT-3749-ability-to-set-operation-sub-mode-latest and 15 more in dd-firmware

Merge branch 'staging' into LDT-3777-sprint-25-fixes

· /firmware/App/Drivers/ConductivitySensors.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/ConductivitySensors.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Monitors/Conductivity.c	(-1, +1)	\| History	\| Source	\| Diff

LEAHI-DD-FIRMWARE-LDT-3777-1: comment by Michael Garthwaite "fixed"

Michael Garthwaite — Wed, 15 Apr 2026 07:45:38 -0700

Michael Garthwaite replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3777-1

fixed

LEAHI-DD-FIRMWARE-LDT-3777-1: comment by Michael Garthwaite "fixed"

Michael Garthwaite — Wed, 15 Apr 2026 07:45:33 -0700

Michael Garthwaite replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3777-1

fixed

LEAHI-DD-FIRMWARE-LDT-3777-1: comment by Michael Garthwaite "fixed"

Michael Garthwaite — Wed, 15 Apr 2026 07:45:26 -0700

Michael Garthwaite replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3777-1

fixed

LEAHI-DD-FIRMWARE-LDT-2004-9: comment by Vinayakam Mani "Same comment applies here (removing resetPICont..."

Vinayakam Mani — Tue, 14 Apr 2026 19:28:15 -0700

Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-2004-9

Same comment applies here (removing resetPIController).

LEAHI-DD-FIRMWARE-LDT-2004-9: comment by Vinayakam Mani "I think we can remove the balancing chamber fil..."

Vinayakam Mani — Tue, 14 Apr 2026 19:17:35 -0700

Vinayakam Mani replied to Vendor - TEL - Sameer Poyil in LEAHI-DD-FIRMWARE-LDT-2004-9

I think we can remove the balancing chamber fill in progress check for Opening D80 valve, as this does not impact the balancing chamber fill process.

LEAHI-DD-FIRMWARE-LDT-2004-9: comment by Vinayakam Mani "Maintain space after and before parenthesis acr..."

Vinayakam Mani — Tue, 14 Apr 2026 19:14:05 -0700

Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-2004-9

Maintain space after and before parenthesis across the file.

LEAHI-DD-FIRMWARE-LDT-2004-9: comment by Vinayakam Mani "Do we need to add another else statement and ad..."

Vinayakam Mani — Tue, 14 Apr 2026 19:06:55 -0700

Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-2004-9

Do we need to add another else statement and address an alarm if wrong mixId is passed? or Keep only else part instead of else if ( ACID_MIX_ID == mixID) check?? this change may be needed across the file.

LEAHI-DD-FIRMWARE-LDT-2004-9: comment by Vinayakam Mani "Remove this comment."

Vinayakam Mani — Tue, 14 Apr 2026 19:02:15 -0700

Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-2004-9

Remove this comment.

LEAHI-DD-FIRMWARE-LDT-2004-9: comment by Vinayakam Mani "You may use getF32OverrideValue for consistency..."

Vinayakam Mani — Tue, 14 Apr 2026 18:57:55 -0700

Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-2004-9

You may use getF32OverrideValue for consistency (across the file).