application

Clone Tools

Stats

Commits this week: 0
Total Committers: 14
Last Commit: 21 Jan 21
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 27 Jan 2021
10:54 am

Behrouz NematiPour

Merge branch 'master' into DEN-5736_UI_Heparin_Bolus

Options
Thursday 21 Jan 2021
5:21 pm

Behrouz NematiPour

Server coverage issue fixed

- This line was not covered on server although it was covered on local.

Tested locally and it is working.

Options
    • -1
    • +3
    /sources/view/hd/alarm/VAlarmStatus.cpp
1:11 pm

Behrouz NematiPour

Build failed on server because the fw common branch master was changed.

- commented out the removed enum from application.

Options
    • -2
    • +2
    /sources/model/hd/alarm/MAlarmStatusData.cpp
    • -4
    • +4
    /sources/view/hd/data/VHDTreatmentStatesData.cpp
Wednesday 20 Jan 2021
8:03 pm

Behrouz NematiPour

Merge branch 'DEN-5830_AlarmDesign'

Options
Tuesday 12 Jan 2021
5:56 pm

Behrouz NematiPour

DEN-5838: Code Review 0

Options
    • -1
    • +2
    /cr_objectives.sh
    • -1
    • +0
    /sources/model/hd/alarm/MAlarmStatusData.cpp
Friday 08 Jan 2021
6:51 pm

Behrouz NematiPour

DEN-5837: Code Analysis

Options
    • -5
    • +7
    /cppcheck.err
    • -94
    • +104
    /cppcheck.log
    • -0
    • +3
    /cr_objectives.sh
    • -1
    • +1
    /denali.pro.user
3:37 pm

Behrouz NematiPour

DEN-5836: Code Coverage

- 100.000% (4827/4827)

- added a unit test for the AlarmGenerator private method setBits.

Options
    • -1
    • +1
    /denali.pro.user
    • -1
    • +1
    /sources/AlarmGenerator.cpp
    • -3
    • +9
    /sources/AlarmGenerator.h
    • -0
    • +17
    /unittests/tst_messaging.cpp
    • -0
    • +2
    /unittests/tst_messaging.h
1:35 pm

Behrouz NematiPour

DEN-5836: Code Coverage

- 99.979% (4826/4827)

Options
    • -1
    • +1
    /sources/AlarmGenerator.cpp
    • -2
    • +2
    /sources/canbus/MessageDispatcher.cpp
    • -40
    • +41
    /sources/canbus/MessageInterpreter.cpp
    • -5
    • +16
    /sources/model/MModel.h
    • -0
    • +2
    /sources/view/hd/alarm/VAlarmStatus.cpp
Thursday 07 Jan 2021
5:13 pm

Behrouz NematiPour

DEN-5836: Code Coverage

- commented as manually tested the AlarmClearedCondition.

Options
    • -1
    • +1
    /denali.pro.user
    • -1
    • +2
    /sources/AlarmGenerator.cpp
    • -1
    • +2
    /sources/canbus/MessageInterpreter.cpp
    • -3
    • +3
    /sources/gui/GuiController.cpp
    • -1
    • +0
    /sources/gui/qml/components/TimeText.qml
    • -1
    • +1
    /sources/gui/qml/dialogs/NotificationDialog.qml
    • -2
    • +3
    /sources/model/hd/adjustment/MTreatmentAdjustRequests.h
    • -0
    • +2
    /sources/view/hd/alarm/VAlarmStatus.cpp
Tuesday 05 Jan 2021
5:20 pm

Behrouz NematiPour

DEN-5836: Alarm:Code Coverage

- 99.110% (4790/4833)

Options
    • -1
    • +1
    /denali.pro.user
    • -0
    • +2
    /sources/canbus/MessageDispatcher.cpp
    • -1
    • +1
    /sources/gui/qml/main.qml
    • -0
    • +2
    /sources/model/hd/alarm/MAlarmClearedCondition.cpp
    • -1
    • +2
    /sources/model/hd/alarm/MAlarmClearedCondition.h
    • -1
    • +1
    /sources/view/hd/alarm/VAlarmStatus.cpp
Monday 04 Jan 2021
2:43 pm

Behrouz NematiPour

DEN-5836: Alarm:Code Coverage

- updated the alarm message table

- fixed the -q parameter

Options
    • -1
    • +1
    /denali.pro.user
    • -59
    • +111
    /sources/model/hd/alarm/MAlarmStatusData.cpp
    • -9
    • +8
    /sources/view/hd/alarm/VAlarmStatus.cpp
Tuesday 22 Dec 2020
9:28 am

Behrouz NematiPour

DEN-5833: Implementation

- Added a UI "AlarmGenerator" class to handle the HD_COMM_TIMEOUT and later the BLE Cuff alarm (PRS 395).

Options
    • -0
    • +2
    /denali.pro
    • -0
    • +75
    /sources/AlarmGenerator.cpp
    • -0
    • +55
    /sources/AlarmGenerator.h
    • -6
    • +2
    /sources/gui/GuiController.cpp
    • -8
    • +9
    /sources/view/hd/alarm/VAlarmStatus.cpp
Thursday 17 Dec 2020
4:19 pm

Behrouz NematiPour

DEN-5833: Implementation

- Cleaned up the unit tests

Options
    • -25
    • +3
    /unittests/tst_canbus.cpp
    • -1
    • +0
    /unittests/tst_canbus.h
    • -225
    • +0
    /unittests/tst_messaging.cpp
    • -16
    • +0
    /unittests/tst_messaging.h
    • -1
    • +1
    /unittests/tst_models.cpp
1:19 pm

Behrouz NematiPour

DEN-5833: Implementation

- added a touch expanding area for the TouchArea so regardless of its visual size it can have expanded touchable area.

- the touch expanding for the mute button set to 25 so it can have a bigger touch area that its size which is little.

Options
    • -1
    • +1
    /sources/gui/qml/components/MuteButton.qml
    • -0
    • +1
    /sources/gui/qml/components/NotificationBar.qml
    • -1
    • +4
    /sources/gui/qml/components/TouchRect.qml
    • -0
    • +1
    /sources/gui/qml/dialogs/NotificationDialog.qml
Tuesday 15 Dec 2020
9:45 pm

Behrouz NematiPour

DEN-5833: Implementation

- Added a MACRO for convenience of empty payload messages handling.

Options
    • -1
    • +9
    /sources/canbus/MessageInterpreter.cpp
9:12 pm

Behrouz NematiPour

DEN-5833: Implementation

- Fixed the bug that alarm ID zero which is the clear the alarm indication wasn't updating the properties, so caused to alarm_ID changed notification signal not to raise and GUI wasn't getting updated.

Options
    • -6
    • +6
    /sources/view/hd/alarm/VAlarmStatus.cpp
Monday 14 Dec 2020
12:33 pm

Behrouz NematiPour

DEN-5833: Implementation

- Moved version and sd-card icon to to not to cover others.

Options
    • -6
    • +5
    /sources/gui/qml/main.qml
Friday 11 Dec 2020
6:06 pm

Behrouz NematiPour

DEN-5833: Implementation

- The message 63 has been tested

Options
    • -1
    • +1
    /denali.pro.user
    • -25
    • +26
    /sources/gui/qml/main.qml
    • -1
    • +15
    /sources/view/hd/alarm/VAlarmStatus.cpp
    • -0
    • +1
    /sources/view/hd/alarm/VAlarmStatus.h
3:47 pm

Behrouz NematiPour

DEN-5833: Implementation

- Added the message 63 (req/rsp)

Options
    • -4
    • +6
    /denali.pro
    • -1
    • +1
    /denali.pro.user
    • -13
    • +13
    /sources/canbus/MessageDispatcher.cpp
    • -0
    • +2
    /sources/canbus/MessageDispatcher.h
    • -1
    • +2
    /sources/canbus/MessageGlobals.h
    • -13
    • +20
    /sources/canbus/MessageInterpreter.cpp
    • -1
    • +2
    /sources/gui/GuiGlobals.h
    • -7
    • +4
    /sources/gui/qml/main.qml
    • -5
    • +10
    /sources/model/MModel.h
    • -7
    • +8
    /sources/model/hd/adjustment/MTreatmentAdjustRequests.h
    • -0
    • +41
    /sources/model/hd/alarm/MAlarmClearedCondition.cpp
    • -0
    • +79
    /sources/model/hd/alarm/MAlarmClearedCondition.h
    • -4
    • +4
    /sources/view/hd/alarm/VAlarmStatus.cpp
    • -4
    • +4
    /sources/view/hd/alarm/VAlarmStatus.h
Thursday 10 Dec 2020
10:04 pm

Behrouz NematiPour

DEN-5833: Implementation

- moved version and SD-Card icon to top which were covering the alarm bar.

- added list icon on the notification bar

- implemented the basics of the alarm list dialog.

- tweaked the Notification default coloring

-

Options
    • -1
    • +1
    /denali.pro.user
    • -0
    • +2
    /denali.qrc
    • binary
    /resources/images/AlarmBell.png
    • binary
    /resources/images/AlarmBellSilent.png
    • binary
    /resources/images/doted-list.png
    • binary
    /resources/images/list.png
    • -4
    • +28
    /sources/gui/qml/components/NotificationBar.qml
    • -0
    • +100
    /sources/gui/qml/dialogs/AlarmListDialog.qml
    • -3
    • +3
    /sources/gui/qml/dialogs/NotificationDialog.qml
    • -2
    • +2
    /sources/gui/qml/globals/Colors.qml
    • -1
    • +2
    /sources/gui/qml/globals/Variables.qml
    • -26
    • +51
    /sources/gui/qml/main.qml
7:19 pm

Behrouz NematiPour

DEN-5833: Implementation

- fix a naming bug.

Options
    • -1
    • +1
    /sources/canbus/MessageDispatcher.cpp
    • -1
    • +1
    /sources/model/hd/adjustment/MTreatmentAdjustRequests.h
6:39 pm

Behrouz NematiPour

DEN-5833: Implementation

- Fixed the bug of silence logic which was reverse

- Fixed the bug that length of the silence message payload was incorrectly set to 4 instead of 1.

- changed the name of the MAlarmSilenceReq member variable to silence instead of state which now implies it is silent (1) or not (0).

Options
    • -1
    • +1
    /sources/canbus/MessageGlobals.h
    • -1
    • +1
    /sources/gui/qml/main.qml
    • -2
    • +2
    /sources/model/hd/adjustment/MTreatmentAdjustRequests.h
    • -2
    • +2
    /sources/view/hd/alarm/VAlarmStatus.cpp
6:17 pm

Behrouz NematiPour

DEN-5833: Implementation

- made the mute button click optional and currently enabled.

- made minimize on silent on the Notification Dialog optional and is disabled currently.

- made separate slots for each user actions instead of one for all with 4 parameter cause I think it's easier and more convenient to use this way.

- increased the Notification Bar height a little bit more.

Options
    • -2
    • +4
    /sources/gui/qml/components/NotificationBar.qml
    • -2
    • +2
    /sources/gui/qml/globals/Variables.qml
    • -33
    • +30
    /sources/gui/qml/main.qml
    • -12
    • +45
    /sources/view/hd/alarm/VAlarmStatus.cpp
    • -2
    • +5
    /sources/view/hd/alarm/VAlarmStatus.h
5:29 pm

Behrouz NematiPour

DEN-5833: Implementation

- Implementation of the message 64: 'Alarm User Action'

- Cleaned up the VAlarmStatus class.

Options
    • -0
    • +1
    /sources/canbus/MessageGlobals.h
    • -1
    • +4
    /sources/gui/qml/components/ImageLogoD.qml
    • -4
    • +7
    /sources/gui/qml/main.qml
    • -13
    • +13
    /sources/model/hd/adjustment/MTreatmentAdjustRequests.h
    • -38
    • +35
    /sources/view/hd/alarm/VAlarmStatus.cpp
    • -20
    • +17
    /sources/view/hd/alarm/VAlarmStatus.h
2:35 pm

Behrouz NematiPour

DEN-5833: Implementation

- Added User Action message response model.

Options
    • -1
    • +1
    /denali.pro.user
    • -0
    • +12
    /sources/canbus/MessageDispatcher.cpp
    • -0
    • +1
    /sources/canbus/MessageInterpreter.cpp
    • -0
    • +3
    /sources/gui/GuiGlobals.h
    • -13
    • +28
    /sources/model/MModel.h
    • -0
    • +28
    /sources/model/hd/adjustment/MTreatmentAdjustRequests.h
12:35 pm

Behrouz NematiPour

DEN-5833: Implementation

- Fixed a bouncing bug of the message when sent for the first time with silenced flag on to show the alarm not maximized.

Options
    • -1
    • +12
    /sources/gui/qml/dialogs/NotificationDialog.qml
    • -5
    • +11
    /sources/view/hd/alarm/VAlarmStatus.cpp
Wednesday 09 Dec 2020
10:20 pm

Behrouz NematiPour

DEN-5833: Implementation

- Added 3 Alarm buttons

- created Mute Button

- created Up and Down Button (minimize/maximize)

- used FW alarm status flag enum (Alarm_State_Flag_Bit_Positions) instead of the UI version and removed UI one.

Code cleaned up

- modified and cleaned up Notification Dialog and Bar.

- modified Time Text component to be able to show sections with one zero only.

- cleaned up main.qml

Options
    • -6
    • +6
    /denali.pro.user
    • -0
    • +6
    /denali.qrc
    • binary
    /resources/images/audio.png
    • binary
    /resources/images/chevron-down.png
    • binary
    /resources/images/chevron-up.png
    • binary
    /resources/images/mute.png
    • -1
    • +1
    /sources/canbus/MessageInterpreter.cpp
    • -19
    • +21
    /sources/gui/GuiGlobals.h
    • -1
    • +0
    /sources/gui/qml/components/ModalDialog.qml
    • -0
    • +60
    /sources/gui/qml/components/MuteButton.qml
    • -37
    • +27
    /sources/gui/qml/components/NotificationBar.qml
    • -3
    • +8
    /sources/gui/qml/components/TimeText.qml
    • -0
    • +37
    /sources/gui/qml/components/UpDownButton.qml
    • -40
    • +87
    /sources/gui/qml/dialogs/NotificationDialog.qml
    • -12
    • +55
    /sources/gui/qml/globals/Colors.qml
  16. … 7 more files in changeset.
Thursday 03 Dec 2020
4:07 pm

Behrouz NematiPour

DEN-5833: Implementation

- Updated the old Alarm model structure to used the notify in the Message Interpreter.

- Updated the Alarm Trigger,Clear,Status to inherit from MAbstract to be able to the above.

- Added a macro to make the request messages handling easier.

Options
    • -7
    • +7
    /denali.pro.user
    • -0
    • +2
    /en_US.udic
    • -172
    • +32
    /sources/canbus/MessageInterpreter.cpp
    • -8
    • +0
    /sources/canbus/MessageInterpreter.h
    • -8
    • +5
    /sources/model/hd/alarm/MAlarmCleared.cpp
    • -12
    • +14
    /sources/model/hd/alarm/MAlarmCleared.h
    • -88
    • +79
    /sources/model/hd/alarm/MAlarmStatusData.cpp
    • -24
    • +31
    /sources/model/hd/alarm/MAlarmStatusData.h
    • -8
    • +5
    /sources/model/hd/alarm/MAlarmTriggered.cpp
    • -12
    • +15
    /sources/model/hd/alarm/MAlarmTriggered.h
3:18 pm

Behrouz NematiPour

Merge branch 'DEN-5736_UI_Heparin_Bolus'

Options
11:48 am

Behrouz NematiPour

DEN-5744: Code Review 0

- A typo to change the #3 to #4

Options
    • -1
    • +1
    /sources/model/hd/data/MTreatmentStatesData.h