dd-firmware / firmware / App / Controllers

Ultrafiltration.c

Clone Tools

Stats

Commits this week: 1
Total Committers: 3
Last Commit: 19 Feb
Commits this week: 1

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 19 Feb
3:46 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-1477_Ultrafiltration - DD - 04: DEV - Feature Implementation
LEAHI-DD-FIRMWARE-LDT-1477_Ultrafiltration - DD - 04: DEV - Feature Implementation
3:32 pm

Vinayakam Mani

LDT-1477 UF update

Options
    • -13
    • +28
    ./Ultrafiltration.c
  2. … 1 more file in changeset.
Friday 13 Feb
9:25 am

Vinayakam Mani

Wednesday 11 Feb
5:05 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./Ultrafiltration.c
  2. … 8 more files in changeset.
4:19 pm

Vendor - TEL - Sameer Poyil and Sean Nash

3:01 pm

Vinayakam Mani

Done.

Done.

2:49 pm

Vinayakam Mani

Updated.

Updated.

2:48 pm

Vendor - TEL - Sameer Poyil

copy paste error comment

copy paste error comment

2:39 pm

Sean Nash

Please convert bool expression to BOOL (TRUE or FALSE) before assigning (either in the expression with trinary or prior).

Please convert bool expression to BOOL (TRUE or FALSE) before assigning (either in the expression with trinary or prior).

2:02 pm

Vinayakam Mani

Done

Done

2:02 pm

Vinayakam Mani

Done.

Done.

9:44 am

Dara Navaei

Tuesday 10 Feb
5:25 pm

Sean Nash

Add a comment to right listing math functions used.

Add a comment to right listing math functions used.

5:24 pm

Sean Nash

Remove blank line.

Remove blank line.

11:02 am

Vinayakam Mani

Looks crucible is not seeing those. let me check once with Dara.

Looks crucible is not seeing those. let me check once with Dara.

11:00 am

Vinayakam Mani

Done.

Done.

11:00 am

Vinayakam Mani

Updated.

Updated.

10:59 am

Vinayakam Mani

Updated

Updated

Monday 09 Feb
9:10 pm

Vendor - TEL - Sameer Poyil

seems to be old , need to merge the staging code

seems to be old , need to merge the staging code

9:07 pm

Vendor - TEL - Sameer Poyil

align the comment

align the comment

9:06 pm

Vendor - TEL - Sameer Poyil

complicated check should be replaced with boolean flag

complicated check should be replaced with boolean flag

7:45 pm

Vendor - TEL - Sameer Poyil

Variable name is not understood -temDataCollectionTimeInterval ?

Variable name is not understood -temDataCollectionTimeInterval ?

5:32 pm

Vinayakam Mani

LDT-1473 latest from staging

Options
    • -1
    • +1
    ./Ultrafiltration.c
  2. … 7 more files in changeset.
5:04 pm

Vinayakam Mani

Yes. updated.

Yes. updated.

Friday 06 Feb
2:17 pm

Sean Nash

So shouldn't we stop trimmer heater here then?

So shouldn't we stop trimmer heater here then?

Wednesday 04 Feb
3:38 pm

Vinayakam Mani

Done.

Done.

3:38 pm

Vinayakam Mani

Done

Done

3:37 pm

Vinayakam Mani

Since trimmer heater is enabled, no need of temp compensation. only for testing purposes, temp compensation is needed. Hence by default, temp compensation is disabled.

Since trimmer heater is enabled, no need of temp compensation. only for testing purposes, temp compensation is needed. Hence by default, temp compensation is disabled.

3:36 pm

Vinayakam Mani

For spent chamber fill, we don't know how low the liquid level is ( in Chamber H) and hence decided not to turn on the trimmer heater for safety reasons. For bicarb fill, the dry bicart code should...

For spent chamber fill, we don't know how low the liquid level is ( in Chamber H) and hence decided not to turn on the trimmer heater for safety reasons. For bicarb fill, the dry bicart code should cover the actuators status. the current bicarb chamber fill code here should be updated with the newly implemented dry bi cart code changes.

Tuesday 03 Feb
5:32 pm

Sean Nash

I think cal data and count should be retrieved by same function and possibly needs some interrupt protection to ensure data and count stick together. If these functions are called from general task...

I think cal data and count should be retrieved by same function and possibly needs some interrupt protection to ensure data and count stick together. If these functions are called from general task, we could have situation where data is retrieved, then priority task updates fpga, and then counter is retrieved with wrong (incremented) counter.
If these two functions are being called from a driver that is executed in priority task, then we don't need to worry about this situation, but still ought to add a constraint/warning comment in function headers noting that these functions should only be called from priority task.