dd-firmware / firmware / App / Modes

ModeGenDialysate.c

Clone Tools

Stats

Commits this week: 2
Total Committers: 10
Last Commit: 19 Feb
Commits this week: 2

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 19 Feb
10:11 am

Sean Nash

I suspect this is temporary. If so, just add a TODO comment to restore later.

I suspect this is temporary. If so, just add a TODO comment to restore later.

Tuesday 17 Feb
4:38 pm

Vendor - TEL - Jashwant Gantyada

there was an issue with my VM and Dara Navaei when fixed it this got deleted and he told me that it is okay to commit this.

there was an issue with my VM and Dara Navaei when fixed it this got deleted and he told me that it is okay to commit this.

4:37 pm

Vendor - TEL - Jashwant Gantyada

changed.

changed.

4:36 pm

Vendor - TEL - Jashwant Gantyada

updated.

updated.

4:36 pm

Vendor - TEL - Jashwant Gantyada

done.

done.

4:36 pm

Vendor - TEL - Jashwant Gantyada

done.

done.

4:36 pm

Vendor - TEL - Jashwant Gantyada

changed.

changed.

4:36 pm

Vendor - TEL - Jashwant Gantyada

changed.

changed.

4:31 pm

Vendor - TEL - Jashwant Gantyada

Vinayakam Mani had it removed. Can you please let us know why you have this commented out in latest staging?

Vinayakam Mani had it removed. Can you please let us know why you have this commented out in latest staging?

Friday 13 Feb
3:47 pm

Sean Nash

Looks like we are doing a lot of the dialysate temp control in Gen Dialysate mode. Do we not do any heating in PreGen mode? Even if all dialysate heating is done in this mode, should we consider cr...

Looks like we are doing a lot of the dialysate temp control in Gen Dialysate mode. Do we not do any heating in PreGen mode?
Even if all dialysate heating is done in this mode, should we consider creating a service controller (like BC controller) to manage this complex temperature control?

3:38 pm

Sean Nash

Resolve merge conflicts.

Resolve merge conflicts.

9:40 am

Vinayakam Mani

9:25 am

Vinayakam Mani

Wednesday 11 Feb
4:19 pm

Vendor - TEL - Sameer Poyil and Sean Nash

3:01 pm

Vinayakam Mani

Done.

Done.

2:49 pm

Vinayakam Mani

Updated.

Updated.

2:48 pm

Vendor - TEL - Sameer Poyil

copy paste error comment

copy paste error comment

2:39 pm

Sean Nash

Please convert bool expression to BOOL (TRUE or FALSE) before assigning (either in the expression with trinary or prior).

Please convert bool expression to BOOL (TRUE or FALSE) before assigning (either in the expression with trinary or prior).

2:02 pm

Vinayakam Mani

Done

Done

2:02 pm

Vinayakam Mani

Done.

Done.

9:44 am

Dara Navaei

Tuesday 10 Feb
5:25 pm

Sean Nash

Add a comment to right listing math functions used.

Add a comment to right listing math functions used.

5:24 pm

Sean Nash

Remove blank line.

Remove blank line.

5:20 pm

Sean Nash

Can you follow up with whoever commented it out and find out if that was intentional? And, if so, will it be coming back? And, if so, should we at least put a TODO on this to restore later?

Can you follow up with whoever commented it out and find out if that was intentional? And, if so, will it be coming back? And, if so, should we at least put a TODO on this to restore later?

5:17 pm

Sean Nash

Why not "TRUE == "?

Why not "TRUE == "?

5:16 pm

Sean Nash

Why not "TRUE == "?

Why not "TRUE == "?

5:15 pm

Sean Nash

Remove blank line.

Remove blank line.

5:14 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

5:13 pm

Sean Nash

Outputs in none now I think.

Outputs in none now I think.

5:12 pm

Sean Nash

Looks like you updated wrong function (the one below instead of this one). It's an output in function below and it's an input in this function.

Looks like you updated wrong function (the one below instead of this one). It's an output in function below and it's an input in this function.