Activity dd-firmware/firmware/App/Monitors/Conductivity.c

3:47 pm

Dara Navaei

More
LEAHI-DD-FIRMWARE-LDT-2004-11
started review

LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD

3:37 pm

Dara Navaei

More
LEAHI-DD-FIRMWARE-LDT-3750-3
added Michael Garthwaite , Raghu Kallala and 5 others

2:46 pm

Dara Navaei

More
LEAHI-DD-FIRMWARE-LDT-3750-3
started review

LEAHI-DD-FIRMWARE-LDT-3750_DD_Staging_Rebase

10:52 am

Michael Garthwaite

More
bc7dad1
changed 4 files
LDT-2004-dialysate-composition-closed-loop--dd, LDT-2004-v2-conductivity-sensors, develop LEAHI-DD-FIRMWARE-LDT-2004-4 LEAHI-DD-FIRMWARE-LDT-2004-11

LDT-2004: reverted fpga init to be reflective in staging. setting raw resistance values to 1 when we see 0 to prevent nan's being injected into rolling average.

- -8
- +8
./Conductivity.c
- History
- Source
- Diff
./Conductivity.c
… 3 more files in changeset.

9:52 am

Sean Nash

More
LEAHI-DD-FIRMWARE-LDT-3372-1
resumed reviewing

9:50 am

Michael Garthwaite

More
7983907
changed 6 files
LDT-2004-dialysate-composition-closed-loop--dd, LDT-2004-v2-conductivity-sensors, develop LEAHI-DD-FIRMWARE-LDT-2004-4 LEAHI-DD-FIRMWARE-LDT-2004-11

LDT-2004: override fixes for v1 and v2 sensors.

- -0
- +73
./Conductivity.c
- History
- Source
- Diff
./Conductivity.c
… 5 more files in changeset.

9:18 am

Michael Garthwaite

More
202978f
changed 6 files
LDT-2004-dialysate-composition-closed-loop--dd, LDT-2004-v2-conductivity-sensors, develop LEAHI-DD-FIRMWARE-LDT-2004-4

Merge branch 'staging' into LDT-2004-v2-conductivity-sensors

- -1
- +1
./Conductivity.c
- History
- Source
- Diff
./Conductivity.c
… 5 more files in changeset.

9:06 am

Dara Navaei

More
46a4261
changed 5 files
LDT-2004-dialysate-composition-closed-loop--dd, LDT-2004-dialysate-composition-dosing-control--dd and 13 more LEAHI-DD-FIRMWARE-LDT-2004-4 LEAHI-DD-FIRMWARE-LDT-3372-1

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -1
- +1
./Conductivity.c
- History
- Source
- Diff
./Conductivity.c
… 4 more files in changeset.

9:06 am

Dara Navaei

More
019e570
changed 5 files
LDT-2004-dialysate-composition-closed-loop--dd, LDT-2004-dialysate-composition-mixing-beta-2.0--dd and 5 more LEAHI-DD-FIRMWARE-LDT-3750-3

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -1
- +1
./Conductivity.c
- History
- Source
- Diff
./Conductivity.c
… 4 more files in changeset.

7:00 pm

Vendor - TEL - Sameer Poyil and Sean Nash

More
LEAHI-DD-FIRMWARE-LDT-3372-2
finished reviewing

2:29 pm

Michael Garthwaite

More
a5d119a
changed 1 file
LDT-2004-dialysate-composition-closed-loop--dd, LDT-2004-dialysate-composition-dosing-control--dd and 14 more LEAHI-DD-FIRMWARE-LDT-3372-2

LDT-3372: code review comments

- -1
- +0
./Conductivity.c
- History
- Source
- Diff
./Conductivity.c

2:29 pm

Michael Garthwaite

More
2483040
changed 1 file
LDT-2004-dialysate-composition-closed-loop--dd, LDT-2004-dialysate-composition-mixing-beta-2.0--dd and 5 more

LDT-3750 cherry-picked a5d119a

- -2
- +10
./Conductivity.c
- History
- Source
- Diff
./Conductivity.c

2:25 pm

Michael Garthwaite

More
f87a631
changed 1 file
LDT-2004-dialysate-composition-closed-loop--dd, LDT-2004-dialysate-composition-dosing-control--dd and 14 more LEAHI-DD-FIRMWARE-LDT-3372-2

LDT-3372: code review comments

- -1
- +1
./Conductivity.c
- History
- Source
- Diff
./Conductivity.c

2:22 pm

Michael Garthwaite

More
17bccac
changed 1 file
LDT-2004-dialysate-composition-closed-loop--dd, LDT-2004-dialysate-composition-mixing-beta-2.0--dd and 5 more

LDT-3750 cherry-picked f87a631

- -2
- +10
./Conductivity.c
- History
- Source
- Diff
./Conductivity.c

2:21 pm

Michael Garthwaite

J1 - P9 J2 - P18 J3 - D17 J4 - D27 J5 - D29 J6 - D43 No sensor - D74 (redundant, so we should be able to live without it in short run)

J1 - P9
J2 - P18
J3 - D17
J4 - D27
J5 - D29
J6 - D43
No sensor - D74 (redundant, so we should be able to live without it in short run)

2:20 pm

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3372-2
commented on review

Remove extra blank line.

2:20 pm

Michael Garthwaite

build switch fixes will be completed in the v2 conductivity sensor branch. Per what was agreed on back in November: J1 - P9 J2 - P18 J3 - D17 J4 - D27 J5 - D29 J6 - D43 No sensor - D74 (redundant,...

build switch fixes will be completed in the v2 conductivity sensor branch. Per what was agreed on back in November:

J1 - P9
J2 - P18
J3 - D17
J4 - D27
J5 - D29
J6 - D43
No sensor - D74 (redundant, so we should be able to live without it in short run)

2:20 pm